Message-ID: <a6d27ad18452d13840cb4cdd2f17cef7dbe0275c.camel@linux.intel.com>
Subject: Re: [PATCH 2/2] platform/x86/intel/pmt/telemetry: Add driver version
From:   "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To:     Hans de Goede <hdegoede@redhat.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     irenic.rajneesh@gmail.com, markgross@kernel.org,
        linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
Date:   Mon, 20 Mar 2023 10:03:26 -0700
In-Reply-To: <87382b5e-f3f8-601c-77ff-ecd44d911042@redhat.com>
References: <20230316225736.2856521-1-david.e.box@linux.intel.com>
         <20230316225736.2856521-2-david.e.box@linux.intel.com>
         <CAHp75VcP5jf4Tt-U7cs77gnTcUpQbQ+exXjOOc5epPRDfT0h0Q@mail.gmail.com>
         <87382b5e-f3f8-601c-77ff-ecd44d911042@redhat.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-03-20 at 15:18 +0100, Hans de Goede wrote:
> Hi,
>=20
> On 3/17/23 14:35, Andy Shevchenko wrote:
> > On Fri, Mar 17, 2023 at 12:57=E2=80=AFAM David E. Box
> > <david.e.box@linux.intel.com> wrote:
> > >=20
> > > Add a driver version number to make it easier to track changes in
> > > backported kernels.
> >=20
> > Sorry, but NAK. As Greg KH said, we do not use this anymore (in Git
> > era) =C2=AD=E2=80=94 the SHA from the Git _is_ the version of the drive=
r.
>=20
> I agree with Andy per driver version numbers are really not useful.
>=20
> Generally speaking the version number will get updated say once
> per upstream kernel-release in a separate commit,=C2=A0

> but there is
> no guarantee that commit will get cherry-picked together with
> other cherry-picked fixes.

Good point. Thanks.

David


>=20
> So for downstream kernels these version numbers really don't
> have any meaning and as such are useless.
>=20
> Regards,
>=20
> Hans
>=20