Message-ID: <0453c753-681e-4d42-65e5-a5967697f6ca@os.amperecomputing.com>
Date:   Mon, 20 Mar 2023 10:21:51 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.0
Content-Language: en-US
To:     rafael@kernel.org, viresh.kumar@linaro.org,
        george.cherian@cavium.com, pprakash@codeaurora.org
Cc:     scott@os.amperecomputing.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
From:   Yang Shi <yang@os.amperecomputing.com>
Subject: [QUESTION] The delay between sampling for CPPC
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnlDY3BoYjdlL0k0QkFOdjVScVN1TndQcUxDdGM4eHA5U3NKbVFZRG1yd2N5?=
 =?utf-8?B?b05BNmg2QU5MamhNUGk3UzQrY2hPMEpOYUZzblluRnZjbEtNMk1wS082TFg0?=
 =?utf-8?B?RVFzTm9neFpxMEVtc3JHeEgzdlFMMEZaakxPdGlHRDdVQVY2YTRjMWpJSEhz?=
 =?utf-8?B?M010aDI4Sm1BTGNGYnpEaU83cHZmR3hZK1czNXVWOXNnOXZiRGF6em56dkZ4?=
 =?utf-8?B?UC82OUF6NjFnWENiaGRCaFBLeUlTcjJ1Ri9IbDg0N3Axc0k5UEdQYWJ6N2N2?=
 =?utf-8?B?cXRuUHJHclpvNnNxaXI0b0lTOU1xTmtENDc5Q1UzcGlLMjhweUdnakRqbDBa?=
 =?utf-8?B?NTZyZVNVVFlLaitNWlFUSFh3VWQ1S3F0RnFtT2lTU3d4NitOY25vSmtRbDlK?=
 =?utf-8?B?UHRYNjlURjBINXk2NDB5Wk9Fd2pySThxQmJsSU1EdXUwN2VTajlxejVRSmtV?=
 =?utf-8?B?Y2tDSkhzT3oxU3RJb2JTUjI5bHFjRGM2bEQzU2E0VkcvTjltTWdHTzhJMFQw?=
 =?utf-8?B?OXpQb3d0OVVITnZnZmN5VkdITERHR1FhajhmNUs4Um5zOXJxVVNZUDRUN0d2?=
 =?utf-8?B?USt5RnV6N1gvL1ROOG42OTdJdDg3YkwxU04wRklzZHdJWUN2YW1adTNiRUlQ?=
 =?utf-8?B?ay9FSTc5Y0RwWEZQdG1nd2VZZng4WXd6b1dJa1RQSE4zWU1rRm85eHEyb1lE?=
 =?utf-8?B?QkdURWtvYk1Nemh4c25iYlBXZU5hMXFHbHVzME9HcjZHQllBQnh6RkVRVTlt?=
 =?utf-8?B?SDhaNTBBZUcvdXRkeUpaalVYVXVqWDN6UzZnZ0Z2Q3dLc1psQzRLa3NuY0lQ?=
 =?utf-8?B?NGZGb1hTbDdJa0FYbnk5M2dxTndaVElhOUxaOENvVjRHREdXL0hCYkdqa3FL?=
 =?utf-8?B?VUFOOFhVTmVhNnZQK093dWI0TTFtR0pwWC9URm5JRmJsbGtwVlF6NGdkcVRE?=
 =?utf-8?B?U0lJT2QzemZKMjgxUlFMOEFsTm1LMXdzRW4xbzB4SWF4MTBoVXZlS1FxSndr?=
 =?utf-8?B?dkR3dGMzcEduT1VUVFV0NXBBb3hRZ0NHWTBrM3JQcWEwUHNKWDZOSkh6UjFl?=
 =?utf-8?B?U3A4b2ZYdTl5bXB5dDVISTdFRSs2WEF5Sjd6bXkwZUhTTTFJRE9Va2NITWhx?=
 =?utf-8?B?NmI2NzBlVHF6THpGMVQwekF5citaN3k1dUVldDNBdlA3L2pnSUZubmMwSG5J?=
 =?utf-8?B?SEhtMVN4TWtpZmY0SEJNQnpLTElRbkE3VHJkTEl5aGtnU0FOMFlwVUN1a3ly?=
 =?utf-8?B?bUJtYlEvRG5zU3ExQ2xRL1dtUmVLVFRCeVBvREVadlBDUDJKYWtZZGkxTlBZ?=
 =?utf-8?B?THg1dmxIYVZTL3Z0ZjRtanZPblFzYVVnWU1nSjJsODhjaFY4RWFqU3grcFhE?=
 =?utf-8?B?d01ZRkZxWFlUZzJaRDI4allGVGRwN2lVeWFWcHYzVmkyKzUrTWs4OC9JL2N0?=
 =?utf-8?B?ZTdlc3Q1T2YrMkY1cnF3Vkt5SHJSSnpRa21HN3QrVDVpS3ZHYXRaV1gxZVh0?=
 =?utf-8?B?VjREOXc1bXFZSEQzQTFkVFBETE5RbWYzc1VNRHZaaWs4NXBidUgzS05SRUN1?=
 =?utf-8?B?cCt0N09QUThvUDRsNHdPeFhZNVdTeFd3bUNyQmd3dG9XSHBWaFpDMDBxbkk2?=
 =?utf-8?B?QUNUMDNEY2F5WCsraW1RWEE5OTNteDZCaHpFVWZnenlmZlNqVWo4UUxibTUy?=
 =?utf-8?B?Ym9qRHM1Tm91WGcxeGNVNTR1NldJZDcxNGNIRVRQb1JycWpVbnZCcU9Bemx2?=
 =?utf-8?B?ckwxOVlyUVoxdXRYVm9FVzN0Y0liY1g0R0c4MzBoTDNiNTdUaDBBd0ZCUlNN?=
 =?utf-8?B?YXhkSEdaMHZHc3dhV2VNSUQwSWVLZ0d6cVlIMHcxcnhTUXVxYTg0SXdET0R3?=
 =?utf-8?B?YWtBNmVoTjMzY3o5T0dWY3MwOU90bnh3NUtTLzlRdjhNWUY3bnRkUTU4bGJx?=
 =?utf-8?B?VjBzazdvMzYvZURJY0NZblFKd292VWV0Y1ZEaE9ia0haVi9DVTdqTHNHRlF5?=
 =?utf-8?B?M05TVGNOY0xaL09kZklMSFMydFJTRUlid1RmVDQ4NisvVlB2K0YwVERUK2FL?=
 =?utf-8?B?Yld4Rm5STE8rWEdGbzRoUXZ6K2l5Ni9rOHZhTkRiekVEVUtuSTdvN1k4b2lo?=
 =?utf-8?B?TmFJM3ZqTTlFOXFxdm40dExYeXVrbzlISW9hQlprc0tLUzlXQlZiTGlWRFFE?=
 =?utf-8?Q?a8wlFpMMvV+HNjUxhQsaRCM=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 567bca8b-cd63-46bb-77c8-08db29679a22
X-MS-Exchange-CrossTenant-AuthSource: BL3PR01MB7027.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 17:21:54.8846
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WRzF45ChC2tSvWzP6vDvqVwglAMBE5yqN+Z339//3pM66fJWwnlrmVTgC5dxHnwFSSEBH+6tmY5LzEg/3Eytc25RvCYChyZ80BeBz5pWZHk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR01MB7854
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi folks,

When testing CPPC cpufreq on our platform, we noticed the error may be 
quite high and it (high error) may happen quite often. For example, our 
platform max freq is 2.8GHz, when the CPUs were fully loaded (100% 
load), we saw cpuinfo_cur_freq may show 4GHz, it means > 40% error. And 
the high error (> 1%) happened 256 times out of 2127 samples (sampled 
every 3 seconds) in 2hrs test.

We tried to change the delay to 100us, things got improved although we 
still saw high error, but it happened much less often (22 times out of 
3623 samples).

So why was 2us used as the delay? Does it make sense to use a larger 
delay, for example, 100us used by our test, or even larger, for example, 
ms granularity?

Thanks,
Yang