MIME-Version: 1.0
References: <20230314004611.48583-1-tony.luck@intel.com>
In-Reply-To: <20230314004611.48583-1-tony.luck@intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 20 Mar 2023 18:34:27 +0100
Message-ID: <CAJZ5v0hNQUfWViqxbJ5B4JCGJUuHpWWSpqpCFWPNpGuagoFbsQ@mail.gmail.com>
Subject: Re: [PATCH] ACPI: APEI: EINJ: Add CXL error types
To:     Tony Luck <tony.luck@intel.com>
Cc:     "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Borislav Petkov <bp@alien8.de>, x86@kernel.org,
        linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, Mar 14, 2023 at 1:47 AM Tony Luck <tony.luck@intel.com> wrote:
>
> ACPI 6.5 added six new error types for CXL. See chapter 18
> table 18.30.
>
> Add strings for the new types so that Linux will list them in the
> /sys/kernel/debug/apei/einj/available_error_types file.
>
> It seems no other changes are needed. Linux already accepts
> the CXL codes (on a BIOS that advertises them).
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  drivers/acpi/apei/einj.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
> index b4373e575660..39bee5a067cc 100644
> --- a/drivers/acpi/apei/einj.c
> +++ b/drivers/acpi/apei/einj.c
> @@ -584,6 +584,12 @@ static const char * const einj_error_type_string[] = {
>         "0x00000200\tPlatform Correctable\n",
>         "0x00000400\tPlatform Uncorrectable non-fatal\n",
>         "0x00000800\tPlatform Uncorrectable fatal\n",
> +       "0x00001000\tCXL.cache Protocol Correctable\n",
> +       "0x00002000\tCXL.cache Protocol Uncorrectable non-fatal\n",
> +       "0x00004000\tCXL.cache Protocol Uncorrectable fatal\n",
> +       "0x00008000\tCXL.mem Protocol Correctable\n",
> +       "0x00010000\tCXL.mem Protocol Uncorrectable non-fatal\n",
> +       "0x00020000\tCXL.mem Protocol Uncorrectable fatal\n",
>  };
>
>  static int available_error_type_show(struct seq_file *m, void *v)
> --

Applied as 6.4 material, thanks!