MIME-Version: 1.0
References: <20230316173811.1223508-1-revest@chromium.org> <20230316173811.1223508-5-revest@chromium.org>
 <ZBcqWqWyq0uW/wj7@krava> <20230319135550.22aaa04b@rorschach.local.home>
 <ZBdTA0gKh2xAk5Ay@krava> <20230319204731.6691dedc@rorschach.local.home> <ZBgT0FINOmW7c4pK@krava>
In-Reply-To: <ZBgT0FINOmW7c4pK@krava>
From:   Florent Revest <revest@chromium.org>
Date:   Mon, 20 Mar 2023 18:41:46 +0100
Message-ID: <CABRcYmJcYgJBvzCXapbmyLdFiY+SFFEN6My5EofFqMT0TGbCSQ@mail.gmail.com>
Subject: Re: [PATCH 4/7] ftrace: Rename _ftrace_direct_multi APIs to
 _ftrace_direct APIs
To:     Jiri Olsa <olsajiri@gmail.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org, mhiramat@kernel.org,
        mark.rutland@arm.com, ast@kernel.org, daniel@iogearbox.net,
        kpsingh@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Mar 20, 2023 at 9:05=E2=80=AFAM Jiri Olsa <olsajiri@gmail.com> wrot=
e:
>
> On Sun, Mar 19, 2023 at 08:47:31PM -0400, Steven Rostedt wrote:
> > On Sun, 19 Mar 2023 19:22:59 +0100
> > Jiri Olsa <olsajiri@gmail.com> wrote:
> >
> > > > > >  config SAMPLE_FTRACE_DIRECT_MULTI
> > > > >
> > > > > nit, we could perhaps remove this config option as well
> > > > > and use SAMPLE_FTRACE_DIRECT_MULTI
> > > >
> > > > Remove SAMPLE_FTRACE_DIRECT_MULTI for SAMPLE_FTRACE_DIRECT_MULTI?
> > > >
> > >
> > > sorry typo, I meant SAMPLE_FTRACE_DIRECT
> >
> > I believe this was discussed before, and I thought we decided to keep
> > them separate. Or perhaps that was at least for testing?
> >
> > Anyway, we could merge this in the future, but I don't think that's
> > necessary now.
>
> yes, I said it's nit earlier

Happy to send a follow up cleanup later on if that helps. :)