Feedback-ID: iad51458e:Fastmail
Date:   Mon, 20 Mar 2023 10:50:32 -0700
From:   Boqun Feng <boqun.feng@gmail.com>
To:     Davidlohr Bueso <dave@stgolabs.net>
Cc:     rcu@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        Waiman Long <longman@redhat.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Josh Triplett <josh@joshtriplett.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Frederic Weisbecker <frederic@kernel.org>,
        Neeraj Upadhyay <quic_neeraju@quicinc.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Shuah Khan <shuah@kernel.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        seanjc@google.com, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH rcu 1/7] locking/lockdep: Introduce lock_sync()
Message-ID: <ZBic6FfmVmMERQXm@boqun-archlinux>
References: <20230317031339.10277-1-boqun.feng@gmail.com>
 <20230317031339.10277-2-boqun.feng@gmail.com>
 <20230320170614.ttnqyhemnelgmzgd@offworld>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230320170614.ttnqyhemnelgmzgd@offworld>
Precedence: bulk

On Mon, Mar 20, 2023 at 10:06:14AM -0700, Davidlohr Bueso wrote:
> On Thu, 16 Mar 2023, Boqun Feng wrote:
> 
> > +/*
> > + * lock_sync() - A special annotation for synchronize_{s,}rcu()-like API.
> > + *
> > + * No actual critical section is created by the APIs annotated with this: these
> > + * APIs are used to wait for one or multiple critical sections (on other CPUs
> > + * or threads), and it means that calling these APIs inside these critical
> > + * sections is potential deadlock.
> > + *
> > + * This annotation acts as an acqurie+release anontation pair with hardirqoff
> 				^acquire

Good eye! Applied locally.

Regards,
Boqun