Message-ID: <9b1efced-605e-1088-946f-06a4c1a27260@intel.com>
Date:   Mon, 20 Mar 2023 19:24:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.0
Subject: Re: [Intel-gfx] [PATCH v4 03/10] lib/ref_tracker: add printing to
 memory buffer
Content-Language: en-US
To:     Andi Shyti <andi.shyti@linux.intel.com>
Cc:     Chris Wilson <chris.p.wilson@intel.com>, netdev@vger.kernel.org,
        intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Chris Wilson <chris@chris-wilson.co.uk>,
        Eric Dumazet <edumazet@google.com>,
        dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        David Airlie <airlied@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>
References: <20230224-track_gt-v4-0-464e8ab4c9ab@intel.com>
 <20230224-track_gt-v4-3-464e8ab4c9ab@intel.com>
 <ZBeYNaTUmvAxrzoU@ashyti-mobl2.lan>
From:   Andrzej Hajda <andrzej.hajda@intel.com>
Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298
 Gdansk - KRS 101882 - NIP 957-07-52-316
In-Reply-To: <ZBeYNaTUmvAxrzoU@ashyti-mobl2.lan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20.03.2023 00:18, Andi Shyti wrote:
> Hi Andrzej,
> 
> This looks also good, just few questions.
> 
> On Mon, Mar 06, 2023 at 05:31:59PM +0100, Andrzej Hajda wrote:
>> In case one wants to show stats via debugfs.
> 
> shall I say it? I'll say it... you can do better with the log
> here. It's not a typo fix :)
> 
>> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> 
> [...]
> 
>> +void __ref_tracker_dir_print(struct ref_tracker_dir *dir,
>> +			   unsigned int display_limit)
>> +{
>> +	struct ostream os = {};
>> +
>> +	__ref_tracker_dir_pr_ostream(dir, display_limit, &os);
>> +}
>>   EXPORT_SYMBOL(__ref_tracker_dir_print);
>>   
>>   void ref_tracker_dir_print(struct ref_tracker_dir *dir,
>> @@ -114,6 +141,19 @@ void ref_tracker_dir_print(struct ref_tracker_dir *dir,
>>   }
>>   EXPORT_SYMBOL(ref_tracker_dir_print);
>>   
>> +int ref_tracker_dir_snprint(struct ref_tracker_dir *dir, char *buf, size_t size)
> 
> nit: snprintf is normally referred to its variable parameter
> counterpart... I would choose a different name... how about
> ref_tracker_dir_fetch_print()?


Hmm, original ref_tracker_dir_print prints the stats to dmesg,
ref_tracker_dir_snprint prints to memory buffer, like:
- stack_depot_print and stack_depot_snprint,
- stack_trace_print and stack_trace_snprint.


> 
>> +{
>> +	struct ostream os = { .buf = buf, .size = size };
>> +	unsigned long flags;
>> +
>> +	spin_lock_irqsave(&dir->lock, flags);
>> +	__ref_tracker_dir_pr_ostream(dir, 16, &os);
>> +	spin_unlock_irqrestore(&dir->lock, flags);
> 
> What are you trying to protect with this spinlock? what if
> the caller has already locked here? do we need a _locked()
> version?

spinlock is to serialize access to dir,
at the moment _locked version is not necessary, but it can be easily 
added if needed.

Regards
Andrzej


> 
> Thanks,
> Andi
> 
>> +	return os.used;
>> +}
>> +EXPORT_SYMBOL(ref_tracker_dir_snprint);
>> +
>>   void ref_tracker_dir_exit(struct ref_tracker_dir *dir)
>>   {
>>   	struct ref_tracker *tracker, *n;
>>
>> -- 
>> 2.34.1