Message-ID: <111e712f-96c7-7c58-5b55-05a11634469b@amd.com>
Date:   Mon, 20 Mar 2023 14:53:05 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v3 5/7] x86/resctrl: Display the RMID and COSID for
 resctrl groups
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, corbet@lwn.net,
        reinette.chatre@intel.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de
Cc:     fenghua.yu@intel.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <167778850105.1053859.14596357862185564029.stgit@bmoger-ubuntu>
 <167778869402.1053859.6094569492538617564.stgit@bmoger-ubuntu>
 <f4808265-f136-631e-0220-9019e64ee9d3@arm.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <f4808265-f136-631e-0220-9019e64ee9d3@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THNwZmZDbEVHN3hiNksyOEsvR0RLTEw5eEtyaER4Qi9PR2NMdG5ISit6Yk5E?=
 =?utf-8?B?ZWc3UkpqNDZpTmtuSTRBYXNrdGszd2hncmczclNZdkVFM2wyTEdoQnQ2OEZZ?=
 =?utf-8?B?NURwWUFFQjJhZnlhWXd6dUdpalhVK0MxM1RFMUVhWGp4RHdzcE9DQlFnWjdU?=
 =?utf-8?B?QUJ2M1dCYStmRS9Rb1pRLzVuUlhxelRPWWVnaWU1clR6M0NVZVhBaHBlL29K?=
 =?utf-8?B?RWZhV0h2QUQrZWFXRjhKbUVNWldOZk9DWVJtaTJwRS9ScWdwdUlud0FNN3VF?=
 =?utf-8?B?V3RocSs1eEFUQWhMRm5aR2FlaU5KYUo1N2lXdWpXWUNhN0VNU1doc3lET0FV?=
 =?utf-8?B?dDFuQjRSNXVvOUtTZVdXeHpDN013WGwwV2NndHR4NTljb3N0bWovcmZLVW92?=
 =?utf-8?B?b21HUmEvditOSXp1cm4wbkUzU09NNFZoWDdBcEQ3NW9ka0NtM1ViNHJ6TkNq?=
 =?utf-8?B?UGVqbWJUd1pPSWQwSllkUHU2WEJSMzdKYlJzZm5RZDRmMk9SM3RqMExORTBB?=
 =?utf-8?B?TDNqeDdtWlFxdFRsSGJ0bFArM1N3eDh6eEd2Y0d0Z3RKZElDVjFmS2VXdmxt?=
 =?utf-8?B?aGxieTE2cVBTbGxFU29yUjkzZklzbEM5N3BHbVNyWTM0NjdEUmdyblgyUyt3?=
 =?utf-8?B?MDBkWFp4VXZlN2d6TkphbmhRK3h2NlVhY1Z4RHh1RWMvNCtrdUxUNURzbCtp?=
 =?utf-8?B?bTVJZkdzNUU5NWVSZUdyYWRWL0xMdExqZC9jQkt1NWY0U1gvalVEUklkZEJT?=
 =?utf-8?B?MWloNnFCcWJjR2JPMEJKREgvZnhhVFM5UFRIQ25wckUxVVEvTXBjenlJUWFj?=
 =?utf-8?B?TFU4WWtxa2J6RnllTkhsNVFwNHRzc2pKM1lyWkNMRVdyb3lLWFR4QysvbmZ5?=
 =?utf-8?B?VlFCR0JJQnN5dmhCUkdURFlma2N3N3ZTMVdnaVpWbUJWZ01qWVh2MWlLUkM4?=
 =?utf-8?B?VW5hcjRpSE9HL3dsK3JxZnB4WGovWldXVG8zUGZrcGxMZUZKVlVmQmtUc1NS?=
 =?utf-8?B?a1F3cElIaERJOE5GdS9pa2pBQ1g4d1ZzdXdqWllKbkdSY1JseGdIQlZ5Vm1h?=
 =?utf-8?B?SjIrYi9HZTNjYktGSEtQMmZ3TXhkRU1JK2drMkpJKzlZMmxGTWYydVlaU0hM?=
 =?utf-8?B?Rm81M2JvY3ppK2lFSnloQVlMekZFWHdJb2V0SXlBaFc2eUJwaUYrTkpBR2E2?=
 =?utf-8?B?Q3FIQ1JDNEJEUExXVGRjd2t6Q2ZOVVFTS3ZqZFo3eEFCbUpoV1A0aHVoY0h0?=
 =?utf-8?B?SEc5Y25HQUhFSVZNcnMwbUs3R25mcGIvdFlkbzBTdldtTHFBMHA3b0ZYaXZY?=
 =?utf-8?B?bjZEOVRYanhCTWxGS29QRjRESHFMQ0QveEZQcGZjSWtOZnJEUEY0cDBLcVhN?=
 =?utf-8?B?dytqcHlnWmt2dzQ4T2x0WlBGdUViOE5BTWdOVG51ZlV2eUxDY2xydXo5bHNT?=
 =?utf-8?B?aW5NbjRiOEdmaldVcmNFZHlzL25KRk0wc1NCQVZ1TlFJMGxGMmI2Z0VRaXJG?=
 =?utf-8?B?UUVLRnJxanB2Q0dqT1ZkNXQvOGo5WlArTlVQYU9XNU40ZElYbFRjcVk3NzBY?=
 =?utf-8?B?dzE1MTRUbTBIQ0VPdWNiVDRuckJmQnMra1J6OWFtaUpNUjJmeUc3bmhhZHoz?=
 =?utf-8?B?bHBUMktqSkV0SllCNjJuRStXdElnRnNOT2NHRHJGcEJaRkt5VWxJc2RmVlNh?=
 =?utf-8?B?dkxKOXRzUlVoOE1RMittVnlqMUcxcHdabUlMaVd3T2R0eDVyZGp2ZElHM0xZ?=
 =?utf-8?B?U3J1RzkzT0lZQ01RYnBYRExYVTVUVFMxNFVDeW1ndktoSy9MbHo3bXBTNjRM?=
 =?utf-8?B?cWhLZmdpL1hpWnIwKy9wZFVXMnlhdmJVa1FJYXdZYlJLbUw1bkNmbXFvRFBM?=
 =?utf-8?B?Qm44TTFmYUVTNS9DeUgzbHZqNmRMQU1oM0hRR3Q2UG1ZaWFzdm5ZZnNLN2Qw?=
 =?utf-8?B?cGhyWHB6czRjdnpuUHJoQ2FwRnVqLzYrazY4Y2RWN3J0Y3lwOUszV0lUNWFw?=
 =?utf-8?B?RHdCOFI2ems0cDJ0VWx0UXVMVmVrQnovcDBBTCszUFgzRU1VbDdBejdjTWlr?=
 =?utf-8?B?VTZjaktDOEZrWlRlVHFpSERzSnd3dmRheVdmbnlyOXkrZ3dBSXdDVFh3bUoz?=
 =?utf-8?Q?ypdPGn9gW3nTtN9qLtJGovRN2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe9a2472-06b2-484c-bf89-08db297cb8d4
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 19:53:05.8409
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yFFZce56llqtmd3Wg3//mqmmX3vGKhznLSVzGGSFWa1Y1Ui0x52whR0xLWestDF1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5802
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 3/20/23 12:10, James Morse wrote:
> Hi Babu,
> 
> On 02/03/2023 20:24, Babu Moger wrote:
>> When a user creates a control or monitor group, the CLOSID or RMID
>> are not visible to the user. These are architecturally defined entities.
> 
> On x86. Any other architecture is going to have a hard time supporting this.
> 
> 
>> There is no harm in displaying these in resctrl groups. Sometimes it
>> can help to debug the issues.
> 
> By comparing it with what? Unless user-space can see into the hardware, resctrl is the
> only gateway to this stuff. What difference does the allocated value here make?
> 
> Could you elaborate on what issues this can help debug?

While ago, we had an issue with one of the RMID's event reporting. There
were numerous active RMIDs on the system. As a kernel developer, we
couldn't pinpoint which RMID was reporting wrong information. That
information was important for hardware guys to debug further. We had to
patch the kernel to print that information for debugging. This is one of
the cases.

> 
> 
>> Add CLOSID and RMID to the control/monitor groups display in resctrl
>> interface.
>>
>> $cat /sys/fs/resctrl/clos1/closid
>> 1
>> $cat /sys/fs/resctrl/mon_groups/mon1/rmid
>> 3
> 
> Er. Please don't expose this to user-space!
> MPAM has no equivalent value to RMID, so whatever this is for, can't work on MPAM.
> 
> 
> Where I have needed this value for MPAM is to pass the closid/rmid to another kernel
> interface. Because the user-space interface needs to be architecture agnostic, I proposed
> it as a u64 called 'id' that each architecture can encode/decode as appropriate. [0]
> 
> To prevent user-space trying to base anything on the raw closid/rmid values, I went as far
> as obfuscating them with a random value picked at boot, to ensure scripts always read the
> current value when passing the control/monitor group.
> 
> 
> I'm curious what the raw value is useful for.

It is mostly for debugging when there are issues.

I think we need to have a way to print generic as well as architecture
specific details.

Thanks
Babu
> 
> 
> Thanks,
> 
> James
> 
> [0]
> https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/commit/?h=mpam/snapshot/v6.2&id=d568cf2ba58b7c4970ce41a8d4d6224e285a177e
> 
> 
> 
>