MIME-Version: 1.0
References: <20230320155024.164523-1-noltari@gmail.com> <20230320155024.164523-3-noltari@gmail.com>
 <ZBi56yI4CnY2AAtH@corigine.com>
In-Reply-To: <ZBi56yI4CnY2AAtH@corigine.com>
From:   =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= <noltari@gmail.com>
Date:   Mon, 20 Mar 2023 20:56:58 +0100
Message-ID: <CAKR-sGf1XFP1pE1KmQVQmZADc6udS_8+qqM5NvrNZ266VPkMtw@mail.gmail.com>
Subject: Re: [PATCH 2/4] net: dsa: b53: mmap: add more BCM63xx SoCs
To:     Simon Horman <simon.horman@corigine.com>
Cc:     f.fainelli@gmail.com, andrew@lunn.ch, olteanv@gmail.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

El lun, 20 mar 2023 a las 20:54, Simon Horman
(<simon.horman@corigine.com>) escribi=C3=B3:
>
> On Mon, Mar 20, 2023 at 04:50:22PM +0100, =C3=81lvaro Fern=C3=A1ndez Roja=
s wrote:
> > BCM6318, BCM6362 and BCM63268 are SoCs with a B53 MMAP switch.
> >
> > Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas <noltari@gmail.com>
> > ---
> >  drivers/net/dsa/b53/b53_mmap.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_m=
map.c
> > index 70887e0aece3..464c77e10f60 100644
> > --- a/drivers/net/dsa/b53/b53_mmap.c
> > +++ b/drivers/net/dsa/b53/b53_mmap.c
> > @@ -331,8 +331,11 @@ static void b53_mmap_shutdown(struct platform_devi=
ce *pdev)
> >
> >  static const struct of_device_id b53_mmap_of_table[] =3D {
> >       { .compatible =3D "brcm,bcm3384-switch" },
> > +     { .compatible =3D "brcm,bcm6318-switch" },
> >       { .compatible =3D "brcm,bcm6328-switch" },
> > +     { .compatible =3D "brcm,bcm6362-switch" },
> >       { .compatible =3D "brcm,bcm6368-switch" },
> > +     { .compatible =3D "brcm,bcm63268-switch" },
>
> This patch adds support to this driver for "brcm,bcm63268-switch".
> However, less I am mistaken, this support doesn't work without
> patches 3/4 and 4/4 of this series.

It works for those devices which only use ports 0-3 (Comtrend VR-3032u
for example).
If the device has a external switch or uses any of the RGMIIs then it
won't configure those ports properly.

>
> I think it would be better to re-range this series so
> that support for "brcm,bcm63268-switch" works when it is
> added to/enabled in the driver.
>
> >       { .compatible =3D "brcm,bcm63xx-switch" },
> >       { /* sentinel */ },
> >  };
> > --
> > 2.30.2
> >