Date:   Mon, 20 Mar 2023 21:11:38 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     =?utf-8?B?w4FsdmFybyBGZXJuw6FuZGV6?= Rojas <noltari@gmail.com>
Cc:     f.fainelli@gmail.com, andrew@lunn.ch, olteanv@gmail.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] net: dsa: b53: mmap: add more BCM63xx SoCs
Message-ID: <ZBi9+ulgaBxX37MK@corigine.com>
References: <20230320155024.164523-1-noltari@gmail.com>
 <20230320155024.164523-3-noltari@gmail.com>
 <ZBi56yI4CnY2AAtH@corigine.com>
 <CAKR-sGf1XFP1pE1KmQVQmZADc6udS_8+qqM5NvrNZ266VPkMtw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAKR-sGf1XFP1pE1KmQVQmZADc6udS_8+qqM5NvrNZ266VPkMtw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXpnaWk4SXd1d3NaYWNDUEoycENYdUpEZEJUT3Jobyt2R05EdU9JbStxaWpT?=
 =?utf-8?B?S1RmOE15bnVpUlNUZmdTdnNmZWw3WWg0YUZxZGdnZnAzaExyekZDMlNIS3pD?=
 =?utf-8?B?akl4aHdTaTNYcWpwOGFlYmhpUnZ1OHpSZDhocGFSellYSHI5dmN3dWY2ek1z?=
 =?utf-8?B?RXY4dUkvMVlTZUpFYkNyOVRqNC9RN3JoV3FMTUVET1NtaWRKc0Vtekx2Nno3?=
 =?utf-8?B?NkgzdWJCbEl5S1pjeGNJU1BPTkNsR2k1Vk5GZmlhU2hUaU9kVzJkbE8xVUF0?=
 =?utf-8?B?UFNEVTZrMlR3dUdUaGpBT0VEWm9uSktseEVMOW15d2JtTkFxQmRMeGpXcms4?=
 =?utf-8?B?Y28vRW9KRzhBTEFOM1ZMNm05bHJEc3F0cWdGdlBKbDNzNHRZeDk4YVJvZndY?=
 =?utf-8?B?R2REZVhYck0xZ1ZaV3NSSkNua2JOejZ0QWhvbWNJVkRYYmloMGVaZ1JlRmhp?=
 =?utf-8?B?T0h5bjVjbWNXNGltbWMyZGR2dkh6NzBvayt3K1VKZTB2QlN1eWx4R2R6OTFW?=
 =?utf-8?B?Tkh1SDBJSnRPc3FncXRiZ3VKbTN5L3BQZkJDa295bmFXZUJkbjE3ZHdCeWt5?=
 =?utf-8?B?RjBhWkJYMlR4c0I2WjQ0NnJNdmZKQVYxL0tvZDlUbGdlZ2pEcDlCUFlEcXl0?=
 =?utf-8?B?MUd5eDJyUUhMdzF0OEdHeFRKdGIxaTZsdThHNUVBK3FUUWpmWXVUSE5GUzA2?=
 =?utf-8?B?SHlUQVlJbzNTQUFnWVpTd05IUStqcXZ0VG42THRaUm5Wa0JNcmE0NU4rc3Q3?=
 =?utf-8?B?QTc1YmpMVGRQTnd1TkpNNVFNZktveXB4cDQ1QzNjSm9vZ2tZL2RGWXZCWjlD?=
 =?utf-8?B?U1A2QlJKMEVOS3RHTUhKdVhLdWNxbzJ5cEw4cmFSdVBaZVNFMXJJRldRRXRB?=
 =?utf-8?B?VFdTOUI3ODRzNXBUTHIwc3pYaEsxMXZpWlhsK1VXS09xZ1ZuRkI1ZVhSQzNx?=
 =?utf-8?B?eS80SnZoNi8vOEUxUXNwNlB1Y0Y4NTl6UmlLUnFZOXNnQWtqeGhYSnJRaEkr?=
 =?utf-8?B?OU0zQVpITEJaVU5tTVMrUTVZN0hLdWRFbkVSdXprOVhxbnhPY0hpazFpU1Zo?=
 =?utf-8?B?d1hka0pNNS9CNlc2UHFxb295NDFkSWU4R0UxUlN6am9jVmV5ZU92cnNmcjJx?=
 =?utf-8?B?SFFWbEdVOGYyS3phNjUwVHNiUzdYWTJWdEZLQ1RKbFlqcHFwcUEyNVB1SHVS?=
 =?utf-8?B?OFovR3I2SE4wdDVLOHV6TVVsdlBWZnpJdWU2UnhsNjJ0cnNoTzBTNnlmS2F1?=
 =?utf-8?B?WDFNQmh4dTM1enlwZVk0dFRFWnFlNGczeFEwZm1VQUNHcVpoQlVzaThpU1Q5?=
 =?utf-8?B?dm8wb3JGK1NhWjlsYXRXOW0xck53S0lKajFUMXR3YmJ5SnFTVmovVDZhQTh0?=
 =?utf-8?B?M1dETllQeTZ6RlI5WTFtWVh1bTQrcGtCZThxTGRVOFJTVDdtQ0xwT1NRQ0Rv?=
 =?utf-8?B?VnV1Uksvek9xOUdTeTI0dGhXRDc5RVUwQnU5UFpuN0dFZFZTZUdzeTc4UVVK?=
 =?utf-8?B?STR2YXZ1MEFNMjJHaCtxVGJrQW5PZDJCUW1TSTZXcmtKRlZmY2tmVDA3YVBB?=
 =?utf-8?B?ZWoxTDlxYjZnaFZOVWtZZHorUnlIRDgwQW5GcXVHWW4zZXdwc1ppMUxnWG1N?=
 =?utf-8?B?aEt1UzVUTzhYQ09tamdzMmI2dmt4L09rRzBBenUzVDRzVnBnRlBKTHYyb0FM?=
 =?utf-8?B?R0J6bkFJbld3blViRFIzSUVVTVo4M3BWUHJhVERpUWREYlN4eFk4VnU0amg1?=
 =?utf-8?B?YmdHMTJOazVHdG5GcXBVM0xkdkFkU1MzZHpEREJLdmsvK3FjemZMcUx4YkpC?=
 =?utf-8?B?REM1dUJQVS9FTERwbFhZNWZOdGtnOGd4dVN5RGdjTDAxQ1dQQWsvMjVqVW9H?=
 =?utf-8?B?WTZWRXpUZ0FzWnE4OVVQWVZsY1dzZVU4TEJNbzViVW5SUDdPaHhpenJEc3NO?=
 =?utf-8?B?OWdTNlpuUVBVb0JoZS80TGd6aEQ0c09zZStDcm5XSFU5dUV3dGFCZ2FQcGN0?=
 =?utf-8?B?WU1lUHYwSzlYVmV1RlZRYXBiOVpyZkhjbkk4K2NnQUpFRkNmejFSSjNXRkwv?=
 =?utf-8?B?UzFaVnVaNEFIVDNLNTYwenhuZkltZ1YraWE3bkw4aEZkR1JNWGZlYjJvZTdF?=
 =?utf-8?B?NzNJcWpkREg5akllb1NMU01BT2dadCtmRktlSzQ3U09wY2VmcGY0d0hHcVZv?=
 =?utf-8?B?d2pXaC9uQzdzNE9XbTdkRFNRZlozY2x5dTV2YVQwN0JBM0wxcCs4MDFPc09Y?=
 =?utf-8?B?OGcxR3dzSWJqMFRxaVdYNEZna1ZnPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a4ad888-3ce5-4d4f-ff96-08db297f576f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 20:11:50.9474
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gw1dA5H20IwciTmNLu66bt5ojUkcrYxiZu/X2XFyLHIl9gP0txnKLKiH1KhrJ60eEJNGvtSQwOiOCNdR8cZZRqLjwPUQ8p5maBzW8ToN5rM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR13MB6307
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 20, 2023 at 08:56:58PM +0100, Álvaro Fernández Rojas wrote:
> El lun, 20 mar 2023 a las 20:54, Simon Horman
> (<simon.horman@corigine.com>) escribió:
> >
> > On Mon, Mar 20, 2023 at 04:50:22PM +0100, Álvaro Fernández Rojas wrote:
> > > BCM6318, BCM6362 and BCM63268 are SoCs with a B53 MMAP switch.
> > >
> > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> > > ---
> > >  drivers/net/dsa/b53/b53_mmap.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c
> > > index 70887e0aece3..464c77e10f60 100644
> > > --- a/drivers/net/dsa/b53/b53_mmap.c
> > > +++ b/drivers/net/dsa/b53/b53_mmap.c
> > > @@ -331,8 +331,11 @@ static void b53_mmap_shutdown(struct platform_device *pdev)
> > >
> > >  static const struct of_device_id b53_mmap_of_table[] = {
> > >       { .compatible = "brcm,bcm3384-switch" },
> > > +     { .compatible = "brcm,bcm6318-switch" },
> > >       { .compatible = "brcm,bcm6328-switch" },
> > > +     { .compatible = "brcm,bcm6362-switch" },
> > >       { .compatible = "brcm,bcm6368-switch" },
> > > +     { .compatible = "brcm,bcm63268-switch" },
> >
> > This patch adds support to this driver for "brcm,bcm63268-switch".
> > However, less I am mistaken, this support doesn't work without
> > patches 3/4 and 4/4 of this series.
> 
> It works for those devices which only use ports 0-3 (Comtrend VR-3032u
> for example).
> If the device has a external switch or uses any of the RGMIIs then it
> won't configure those ports properly.

Ok, I guess that all drivers have incomplete support,
so from that point of view I guess this is fine.

> > I think it would be better to re-range this series so
> > that support for "brcm,bcm63268-switch" works when it is
> > added to/enabled in the driver.
> >
> > >       { .compatible = "brcm,bcm63xx-switch" },
> > >       { /* sentinel */ },
> > >  };
> > > --
> > > 2.30.2
> > >