MIME-Version: 1.0
References: <20230310202922.2459680-1-martin.blumenstingl@googlemail.com>
 <20230310202922.2459680-10-martin.blumenstingl@googlemail.com> <6413750b.4a0a0220.cfd67.2a0b@mx.google.com>
In-Reply-To: <6413750b.4a0a0220.cfd67.2a0b@mx.google.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Mon, 20 Mar 2023 21:29:20 +0100
Message-ID: <CAFBinCBdEuCKZqXEtcV8mVnOGRbk+DeTiZ1WNpU-HVR+eCiJjQ@mail.gmail.com>
Subject: Re: [PATCH v2 RFC 9/9] wifi: rtw88: Add support for the SDIO based
 RTL8821CS chipset
To:     Chris Morgan <macroalpha82@gmail.com>
Cc:     linux-wireless@vger.kernel.org,
        Yan-Hsuan Chuang <tony0620emma@gmail.com>,
        Kalle Valo <kvalo@kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        linux-mmc@vger.kernel.org, Nitin Gupta <nitin.gupta981@gmail.com>,
        Neo Jou <neojou@gmail.com>, Pkshih <pkshih@realtek.com>,
        Jernej Skrabec <jernej.skrabec@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Chris,

On Thu, Mar 16, 2023 at 8:59=E2=80=AFPM Chris Morgan <macroalpha82@gmail.co=
m> wrote:
[...]
> > +MODULE_AUTHOR("Martin Blumenstingl <martin.blumenstingl@googlemail.com=
>");
> > +MODULE_DESCRIPTION("Realtek 802.11ac wireless 8821cs driver");
> > +MODULE_LICENSE("Dual BSD/GPL");
> > --
> > 2.39.2
> >
>
> Overall it works well for me, but when I resume from suspend I get the
> following filling up my dmesg:
>
> rtw_8821cs mmc3:0001:1: sdio read8 failed (0x86): -110
>
> So suspend/resume seems to be an issue, but otherwise it works well
> for me.
Thanks for reporting this issue! I have a fix in my local tree and I'm
testing it currently. If you want to try it for yourself (before I
send an updated series) you can just replace one function in sdio.c:
static int __maybe_unused rtw_sdio_suspend(struct device *dev)
{
    struct sdio_func *func =3D dev_to_sdio_func(dev);
    struct ieee80211_hw *hw =3D dev_get_drvdata(dev);
    struct rtw_dev *rtwdev =3D hw->priv;
    int ret;

    ret =3D sdio_set_host_pm_flags(func, MMC_PM_KEEP_POWER);
    if (ret)
        rtw_err(rtwdev, "Failed to host PM flag MMC_PM_KEEP_POWER");

    return ret;
}


Best regards,
Martin