Date:   Mon, 20 Mar 2023 14:10:33 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Sumitra Sharma <sumitraartsy@gmail.com>,
        Julia Lawall <julia.lawall@inria.fr>
CC:     Marc Dietrich <marvin24@gmx.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <ac100@lists.launchpad.net>, <linux-tegra@vger.kernel.org>,
        <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <outreachy@lists.linux.dev>
Subject: Re: [PATCH] Staging: nvec: Change container_of macro to an inline
 function.
Message-ID: <6418cbc98b225_2c274e29437@iweiny-mobl.notmuch>
References: <20230318170514.GA49181@sumitra.com>
 <alpine.DEB.2.22.394.2303181811260.2914@hadrien>
 <20230318175532.GA49651@sumitra.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230318175532.GA49651@sumitra.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6ck2RHVD/PgyBcaJOw9tnWUCJk7LHLFP1E0kAzgeNeWYk16CeIgiyi+JxhlC?=
 =?us-ascii?Q?4CFkWlNZbbHFw+ccdBkMkWRDsVSVjW7B2mWIaXw7KyvFr0T5T22kpVJ+6ucz?=
 =?us-ascii?Q?ZFw82oIOfyg8NxDZoZCj55YEkQU7tl+vRrWr5dsGF2rK1xfprhRSjDcF9Z+M?=
 =?us-ascii?Q?s0sp/Kj/1aIfDfBIum+21FIFRLN+ENCTEFs/JXvGqpz9VWk+V788TussrXm9?=
 =?us-ascii?Q?K73QDNYlOw745qiupny6ukyOK/rN2yzyNeP4jZv48UFIZuYKL3sxnn1RnOy+?=
 =?us-ascii?Q?194/y4sTOZBeQX51WvYsBimgqy5wORq1i2n1tqozSckOXVexVmBRqf21msQj?=
 =?us-ascii?Q?We1OGq076Lp1IlDYlYZXvr9t13Kr1/1zDlXOaY/aWb5jgjxqyIDB2mx8C1Oe?=
 =?us-ascii?Q?7dj2GKyAGyrshXP99qrAsILwLA1Qkx9r13j0jtD6+uQXzCtZBdYcRWVVonYV?=
 =?us-ascii?Q?xu0w9HmLHlS0d2Y9i5zAMoTctAA+fAPPvSV5PpSOj8ZMId/ON+QKxLSkTIxF?=
 =?us-ascii?Q?Ke+TLoxWDmyeUZIRqDi7VyjW6RwwjnTrRsNTvoJoHSghF+e/l1qsPMSuowvo?=
 =?us-ascii?Q?DhBl6hW1J22bRIUXuPExsmNwfNejX06c6h5UcAqTmOyuY2+TLBmnEJZEJu/Y?=
 =?us-ascii?Q?yJ6L2u5ll/bqMTqsB+ZT8JTx0lrTyiiPcxl8Z3jvG+5kgKyplt+NmO8vpFMa?=
 =?us-ascii?Q?pQ9OjAGivPNF7LYAIfM53H++ZMXscpFn4N7X06LUqwpiFgfcaX33GnNlAqRO?=
 =?us-ascii?Q?+MsBnEOIj1VD9D2j8UKW2HijEw4XPQvIS8jSzVU3qjxVCjMMQ8gbfEMtvi5r?=
 =?us-ascii?Q?Hncixlczr0KOlxDiS9poA3sIBVMrZlZGrpQoYiwpVQiFSTMqABxSG5EtCToF?=
 =?us-ascii?Q?D1GUIxru8zbawxEeYobjGzMFBrTxmheTor4l39gXV/mc9YqPz7bcASp6nNaT?=
 =?us-ascii?Q?DtTisiMQwNVB1BaXpC6ZVSlbq+8teekxp4hZNwdtyWUXOUMwP/CDBqjMRvxS?=
 =?us-ascii?Q?49Iy11r7VUNi5XnMLi42l0C1drY8xzvpcm7HP1ByX6n+XsfGIGlKgw0ug/od?=
 =?us-ascii?Q?/jlG6/bEOEpPrxBwn+QG0gm7tYT1hsM5HHjWR5B0xkMUix7vMhAg8wHYLu98?=
 =?us-ascii?Q?a3CtYErRtEDdDCVPQfwqBn58lkdSG0IRzAsl8xQ7kiXhd2UxqdEt6axBg8ES?=
 =?us-ascii?Q?0V5Es61144KorwIZECUuW5ubF00frkjgFQNO9c4NKUg2lu4m6/IwThQcjlaK?=
 =?us-ascii?Q?bppCvMP0m3jDXppOYQjJkdUVIW/LjcfKPdv/JP2jp9r3lUVC5sfDv9JSlqXP?=
 =?us-ascii?Q?AyujL75XhtL1rZC/lX1U/HSjXE1PYcW4gpp2mYzCnNqHlWkmAkTp467dqBaf?=
 =?us-ascii?Q?hUlyxn9DxjQQleXLZVN/KtkveKvFuG3rCNUDFko+Ye78Aerf/nm1Reuzffb2?=
 =?us-ascii?Q?FYBtgu6x/zJeIAv/vL2w385XT8NkeK3jcCIXl3hK0+03Ny0RCKmhtp1Pg5ra?=
 =?us-ascii?Q?Ii0iiUGefQn/0shC9qWPSO4hW4U62Z9yB3kXbsXyLfM+tM1hy7DUsY5b0ShR?=
 =?us-ascii?Q?I8x4XrfsOOha9vNxlArQFrgrjEDf88kq0SzX7iI8?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 922ee535-0183-4c33-8ecc-08db29878cf4
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 21:10:36.7887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dheW8l1OKb4EiKuIQ7GM+BQFBsk2MDqIpCECqijLc0wYim1jiXsM6HWMXvkUjG1tbQePzyKefevhJbuIUq8eWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5008
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sumitra Sharma wrote:
> On Sat, Mar 18, 2023 at 06:14:50PM +0100, Julia Lawall wrote:
> > 
> > 
> > On Sat, 18 Mar 2023, Sumitra Sharma wrote:
> > 
> > > The macro has the drawback that one cannot determine
> > > what type it applies to by looking at the definition.
> > > Hence this macro definition is not type-safe.
> > >
> > > The inline function gives the same benefits as the
> > > macro and only accepts the specific type of arguments.
> > > Use static because the definition only requires it to be
> > > visible in the current file.
> > 
> > Sumitra,
> > 
> > The subject line and log message could be a little less generic.  For the
> > subject line, one has the impression that you are changing the definition
> > of container_of itself.
> > 
> > The log message is also a bit wordy.  Something like the following would
> > be more concise and still present the issue:
> >
> 
> Okay. I will focus more on writing better patch subject and description.

Sumitra,

I can't tell for sure via email if you are getting discouraged.  But if you are
don't feel bad.  Writing good commit messages is hard.

That said, I see a couple of build errors from 0day on this patch.  Do use the
tools to correct things like that before submitting.

Ira