Date:   Mon, 20 Mar 2023 18:42:55 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     Longfang Liu <liulongfang@huawei.com>,
        shameerali.kolothum.thodi@huawei.com, jonathan.cameron@huawei.com,
        cohuck@redhat.com, linux-kernel@vger.kernel.org,
        linuxarm@openeuler.org
Subject: Re: [PATCH v9 1/5] vfio/migration: Add debugfs to live migration
 driver
Message-ID: <ZBjTXwZQs603zHy3@nvidia.com>
References: <20230320092338.2889-1-liulongfang@huawei.com>
 <20230320092338.2889-2-liulongfang@huawei.com>
 <20230320153336.74b853c7.alex.williamson@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230320153336.74b853c7.alex.williamson@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9ib/N46x9dKlYB1mlMwqkC/6uExXroGCyc/RQJQiIiPj1yZsF01O8yUTxORb?=
 =?us-ascii?Q?iC2PtreDDbzUqG/DXmFzmWVRVa205NJUGAMFjFTtgK6Z5dPvzZVdVa424rtV?=
 =?us-ascii?Q?94JXnNyROclfn2ATa4etVp4LOtZGENQvjyB6IiV5GNJqaE6vldCMKcslUUEU?=
 =?us-ascii?Q?whyPKq9rJI6jqTCTLpT4n//ewoc2MymAkjC+BaR10H7W6sk3ddGDEOId5wqo?=
 =?us-ascii?Q?uUkB7Mu1WPNjgO5b6ysmoMnzm1s07t2yuKsPNtKfT0HfLs5U70AE+ZzcKsK7?=
 =?us-ascii?Q?L1u66N5M/B0uRZwX/igX9n7Vhdr6CVBEZKU+G9ScFUN3XX1ntB6JeVGQOIaG?=
 =?us-ascii?Q?ZChYm5B5WZRx8TSKqNBdAPPoQ8ncXZuCluI52fxmSdu/NL7Ti1ZhcqfTDGkc?=
 =?us-ascii?Q?mNMfuJsrofnJ7Mq+8BWf4w0V+eDeAutWNRqJvogbgcySg4+cPYPnTHOCOys1?=
 =?us-ascii?Q?H0FIa9Svw+fmD9DcRlgiw4kjtB4+DTeIZ+VrQ6+D5TnLF6Q6RqgbekwYZQ7w?=
 =?us-ascii?Q?6pxt/RGORH0JEWFKvOD/oIAH0XA3m/l7zWdtSvl5HiUhuq9KL9CARG2Lz11w?=
 =?us-ascii?Q?6CLUTjov09SzRydeGnRw+unnRDIpQQmT38rkNWfAeLBuIhwSy45W3MsvF5ir?=
 =?us-ascii?Q?CImJwB4k28SioQrQrNPmxN7ZLI4yvd9C9LaYZ5NBXXkn+MKZFlldqn6XRbyc?=
 =?us-ascii?Q?XC2S/nfxFSNIEe0rUYwlpXH+sBE+x7hPUiLlZ2iLbtv+7Oahce6fBdjHdtf/?=
 =?us-ascii?Q?+D45rW0Z9cSSZ/jL0xPyID0LkTpx8oG+Di0X2QTDdOHo8GblDG87LwLc2arY?=
 =?us-ascii?Q?5pXZM9O0XKwx5VbDQa9nQEnzqttSga7h9lPma/xIsqJSirxDwYIrtRXNxVri?=
 =?us-ascii?Q?PaiI89kDI9wy4ABy84eaLEADUgJ5ec9n87HwUF5JFE1epOL1MMUX2+rMRkx+?=
 =?us-ascii?Q?W6wUc7uhLa5a4VzAnRzxyI5OQd7o66QWNl5Y3N/dDyUJbvTdb47IVXeJ6KvB?=
 =?us-ascii?Q?RjiukkcV7H5+7wnopUuQ2PxWj2cktHG+ZJalcibzukkZ/CVmlwEaxlC/hTuz?=
 =?us-ascii?Q?0g+c+fZoWd/Aipe3hOoU3Ix3II9NNNx7ffUz5V9LezZA4a87THDBUEXBBXE/?=
 =?us-ascii?Q?jUtumSNmBJ4WR+k88J9xasvv1nMfKHjN32tLmZr9lKfD/DKoV6DfFw7FnbGI?=
 =?us-ascii?Q?R20mI78duxe8EejsM9p+DRLOG+OBr82FqqyCN3Mi1zEJPS7nS/L/HyppvH1J?=
 =?us-ascii?Q?rCutGivUYEsmFFbqchDYFV56uqTfBI53DSmEiw7xzQ6AY4vHWy42eyuk0cP4?=
 =?us-ascii?Q?j4eXG8rJCBefMKJni4GNMKNt27ai0aIGCCPfLZhUXUeDC6UOvJwMyREWRwZr?=
 =?us-ascii?Q?K9w5tU3LKHD8IOAXbfzwUiQvyF1AFFOgWov7gIEo1V+hPf2LlLIfuFnwJlM3?=
 =?us-ascii?Q?PyJTjInsTGdRkQYesuKp+OvsBmDvuszQ4yRA5SCMPSsxtcXum1SzQ/jArGb6?=
 =?us-ascii?Q?1lZD7K4+xIdWi72IfIliVjhx44fl4jDadIAg5mKSj+8vRblCM1AsZl/EG+Po?=
 =?us-ascii?Q?JY44AAee70kx56SzgeS7MbEiWizmF9agGWLO+ttb?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 399b3f3c-2dc7-4dd3-ab38-08db298c1125
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 21:42:56.4004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /zFycZnDHNtQlOtstsHxU1ZzSM6d4gWBZ2YpAtgWM3jsiIf/2GX1vAOpW0B/+aKN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4456
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 20, 2023 at 03:33:36PM -0600, Alex Williamson wrote:

> This would allow that mlx5 and future drivers automatically get this
> with no driver code, and in fact all devices would get debugfs dev_name
> directories for better test coverage.  hisi_acc would only need to add
> driver specific entries after registering the device and free any
> related data after unregistering the device.  In this way, none of the
> entry points here would need to be exported for drivers, which is
> perhaps the direction Jason was thinking with his prior comments.

Yes, my point was more not to add more ops specifically to wrapper
debugfs stuff. If drivers want a special debugfs file then there is
lots of infrastructure to just create that off a common point

Jason