Date:   Mon, 20 Mar 2023 22:46:39 -0100
From:   Melissa Wen <mwen@igalia.com>
To:     Lee Jones <lee@kernel.org>
Cc:     dri-devel@lists.freedesktop.org,
        Haneen Mohammed <hamohammed.sa@gmail.com>,
        Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
        linux-kernel@vger.kernel.org, Melissa Wen <melissa.srw@gmail.com>
Subject: Re: [PATCH 06/37] drm/vkms/vkms_composer: Fix a few different
 kerneldoc formatting
Message-ID: <20230320234639.va6an7gton3u6eke@mail.igalia.com>
References: <20230317081718.2650744-1-lee@kernel.org>
 <20230317081718.2650744-7-lee@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="crh4fbey2rj7tisg"
Content-Disposition: inline
In-Reply-To: <20230317081718.2650744-7-lee@kernel.org>
Precedence: bulk


--crh4fbey2rj7tisg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 03/17, Lee Jones wrote:
> Fixes the following W=3D1 kernel build warning(s):
>=20
>  drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Function parameter or =
member 'frame_info' not described in 'pre_mul_alpha_blend'
>  drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Excess function parame=
ter 'src_frame_info' description in 'pre_mul_alpha_blend'
>  drivers/gpu/drm/vkms/vkms_composer.c:72: warning: Cannot understand  * @=
wb_frame_info: The writeback frame buffer metadata
>=20
> Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
> Cc: Melissa Wen <melissa.srw@gmail.com>
> Cc: Haneen Mohammed <hamohammed.sa@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
>  drivers/gpu/drm/vkms/vkms_composer.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/=
vkms_composer.c
> index 8e53fa80742b2..41668eedf4272 100644
> --- a/drivers/gpu/drm/vkms/vkms_composer.c
> +++ b/drivers/gpu/drm/vkms/vkms_composer.c
> @@ -22,7 +22,7 @@ static u16 pre_mul_blend_channel(u16 src, u16 dst, u16 =
alpha)
> =20
>  /**
>   * pre_mul_alpha_blend - alpha blending equation
> - * @src_frame_info: source framebuffer's metadata
> + * @frame_info: source framebuffer's metadata
>   * @stage_buffer: The line with the pixels from src_plane
>   * @output_buffer: A line buffer that receives all the blends output
>   *
> @@ -69,11 +69,13 @@ static void fill_background(const struct pixel_argb_u=
16 *background_color,
>  }
> =20
>  /**
> - * @wb_frame_info: The writeback frame buffer metadata
> + * blend
As we are already here:
* blend - blend pixels from a given row and calculate crc

Reviewed-by: Melissa Wen <mwen@igalia.com>

> + * @wb: The writeback frame buffer metadata
>   * @crtc_state: The crtc state
>   * @crc32: The crc output of the final frame
>   * @output_buffer: A buffer of a row that will receive the result of the=
 blend(s)
>   * @stage_buffer: The line with the pixels from plane being blend to the=
 output
> + * @row_size: Size of memory taken up by row data (line_width * pixel_si=
ze)
>   *
>   * This function blends the pixels (Using the `pre_mul_alpha_blend`)
>   * from all planes, calculates the crc32 of the output from the former s=
tep,
> --=20
> 2.40.0.rc1.284.g88254d51c5-goog
>=20

--crh4fbey2rj7tisg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEd8WOo/JViG+Tu+XIwqF3j0dLehwFAmQY8FcACgkQwqF3j0dL
ehxK+BAApuPXoLtr8GnXAFyOAoewA7QqIHpu2g1NWQqVTrPBD4CATrh1hqatgwOB
K5Emv+0dkVwdlggEmhemq6yPs0Tr1ZUVisWqnXXvDTqvVSPXgqgjvQsea/cuygyh
RLD2tLCRFz0Cf2rq7J2hTuoMXz4w4DXeqpN+v2TbDvJoGMER17bNJ0Yu6zTaP2z1
37Mu1e1yCu9h2MjUTPJVhjLIMVBsfCUrEVmE3CyrQRf5fRhWk9fkVHI/YQq5Qwm+
zpGyPC0yPidGVXaHw+8cw1EaeKj5zo4UYs/5FbXK7VFVLijbos66iDdQi4mTrJbV
tsv21LjG4cXtNlk69syrr3HLF/V7GaEQBWGJlw9AxW8hZeMu5OfRD/mknwnDJzT5
ca7XHATQQI1FcMA/ynXTpGBxsaJIqxpCPpz5pLgs67X2IoWtQL9Lp1D3yiqtGpfP
JI2xKnvzHiePnOQ4GDo2OKb5wrfCoSFdU/1sEdkb1N/qJZUfBhfoJpwqe7KiSz/8
nO+CAiU2U3ys9x2w08KPIVWBEPtgLFsF+IssGlTxHSVj9Rbk1XGUgP2KEsCtvSnl
h7aiWaZNHboIQJsu4hqlHjcTduhIylhn5YCIuSwo5F4l1zct/2FIfwCCtM5vK1QF
HE1PCzani4c9Ka/4m3uhnmq6XfYXFrNkXBoEMTeXM8LkxM4C/nc=
=LlH9
-----END PGP SIGNATURE-----

--crh4fbey2rj7tisg--