Message-ID: <cc53723d-e7ab-5e75-aaa1-33da75118d9d@kernel.org>
Date:   Tue, 21 Mar 2023 10:09:57 +1000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] m68k: Kconfig.machine: remove obsolete configs ROMBASE
 and ROMSIZE
Content-Language: en-US
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        linux-m68k@lists.linux-m68k.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230320135418.2055-1-lukas.bulwahn@gmail.com>
From:   Greg Ungerer <gerg@kernel.org>
In-Reply-To: <20230320135418.2055-1-lukas.bulwahn@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Lukas,

On 20/3/23 23:54, Lukas Bulwahn wrote:
> The configs ROMBASE and ROMSIZE were used in arch/m68k/68360/head-ram.S,
> which was removed with commit a3595962d824 ("m68knommu: remove obsolete
> 68360 support").
> 
> Remove the obsolete configs ROMBASE and ROMSIZE.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Looks good thanks.

I have pushed this into the m68knommu git tree, for next branch,
after adding Geerts Fixes and Reviewed-by tags.

Regards
Greg


> ---
>   arch/m68k/Kconfig.machine | 17 -----------------
>   1 file changed, 17 deletions(-)
> 
> diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine
> index e2f961208f18..255d50574065 100644
> --- a/arch/m68k/Kconfig.machine
> +++ b/arch/m68k/Kconfig.machine
> @@ -439,15 +439,6 @@ config ROM
>   	  that can be stored in flash, with possibly the text, and data
>   	  regions being copied out to RAM at startup.
>   
> -config ROMBASE
> -	hex "Address of the base of ROM device"
> -	default "0"
> -	depends on ROM
> -	help
> -	  Define the address that the ROM region starts at. Some platforms
> -	  use this to set their chip select region accordingly for the boot
> -	  device.
> -
>   config ROMVEC
>   	hex "Address of the base of the ROM vectors"
>   	default "0"
> @@ -465,14 +456,6 @@ config ROMSTART
>   	  Define the start address of the system image in ROM. Commonly this
>   	  is strait after the ROM vectors.
>   
> -config ROMSIZE
> -	hex "Size of the ROM device"
> -	default "0x100000"
> -	depends on ROM
> -	help
> -	  Size of the ROM device. On some platforms this is used to setup
> -	  the chip select that controls the boot ROM device.
> -
>   choice
>   	prompt "Kernel executes from"
>   	help