Date:   Mon, 20 Mar 2023 18:58:06 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     f.fainelli@gmail.com
Cc:     =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6?= Rojas <noltari@gmail.com>,
        andrew@lunn.ch, jonas.gorski@gmail.com, olteanv@gmail.com,
        davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [PATCH v2] net: dsa: tag_brcm: legacy: fix daisy-chained
 switches
Message-ID: <20230320185806.5dd71c90@kernel.org>
In-Reply-To: <20230319095540.239064-1-noltari@gmail.com>
References: <20230317120815.321871-1-noltari@gmail.com>
        <20230319095540.239064-1-noltari@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, 19 Mar 2023 10:55:40 +0100 =C3=81lvaro Fern=C3=A1ndez Rojas wrote:
> When BCM63xx internal switches are connected to switches with a 4-byte
> Broadcom tag, it does not identify the packet as VLAN tagged, so it adds =
one
> based on its PVID (which is likely 0).
> Right now, the packet is received by the BCM63xx internal switch and the =
6-byte
> tag is properly processed. The next step would to decode the corresponding
> 4-byte tag. However, the internal switch adds an invalid VLAN tag after t=
he
> 6-byte tag and the 4-byte tag handling fails.
> In order to fix this we need to remove the invalid VLAN tag after the 6-b=
yte
> tag before passing it to the 4-byte tag decoding.

Is it good to go in, Florian?