Message-ID: <a9d9ad38-3743-1cff-2b47-75d1ecdc6f81@collabora.com>
Date:   Tue, 21 Mar 2023 05:07:44 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 2/2] mfd: tps6586x: register restart handler
To:     Benjamin Bara <bbara93@gmail.com>, lee@kernel.org,
        Wolfram Sang <wsa@kernel.org>
Cc:     jonathanh@nvidia.com, treding@nvidia.com,
        richard.leitner@linux.dev, benjamin.bara@skidata.com,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230320220345.1463687-1-bbara93@gmail.com>
 <20230320220345.1463687-3-bbara93@gmail.com>
Content-Language: en-US
From:   Dmitry Osipenko <dmitry.osipenko@collabora.com>
In-Reply-To: <20230320220345.1463687-3-bbara93@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/21/23 01:03, Benjamin Bara wrote:
> +static int tps6586x_restart_handler(struct sys_off_data *data)
> +{
> +	unsigned long flags;
> +	struct device *tps6586x_dev = (struct device *)data->cb_data;
> +
> +	/* bring pmic into HARD REBOOT state, enforce atomic i2c xfer */
> +	local_irq_save(flags);
> +	tps6586x_set_bits(tps6586x_dev, TPS6586X_SUPPLYENE, SOFT_RST_BIT);
> +	local_irq_restore(flags);

Please change i2c_in_atomic_xfer_mode() to use preemptible() instead of
irqs_disabled() and drop the local_irq_save/restore.

-- 
Best regards,
Dmitry