Message-ID: <53675327-d708-d441-4cef-d493d0766911@collabora.com>
Date:   Tue, 21 Mar 2023 05:17:08 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 1/2] mfd: tps6586x: use devm-based power off handler
Content-Language: en-US
To:     Benjamin Bara <bbara93@gmail.com>, lee@kernel.org
Cc:     jonathanh@nvidia.com, treding@nvidia.com,
        richard.leitner@linux.dev, benjamin.bara@skidata.com,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230320220345.1463687-1-bbara93@gmail.com>
 <20230320220345.1463687-2-bbara93@gmail.com>
From:   Dmitry Osipenko <dmitry.osipenko@collabora.com>
In-Reply-To: <20230320220345.1463687-2-bbara93@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/21/23 01:03, Benjamin Bara wrote:
> +static int tps6586x_power_off_handler(struct sys_off_data *data)
>  {
> -	if (tps6586x_clr_bits(tps6586x_dev, TPS6586X_SUPPLYENE, EXITSLREQ_BIT))
> -		return;
> +	int ret;

Nit: "int ret" should be put after "struct tps6586x_dev" to adhere
canonical kernel coding style

> +	struct device *tps6586x_dev = (struct device *)data->cb_data;

No need for casting of the void* type

-- 
Best regards,
Dmitry