Subject: Re: [PATCH v9 1/5] vfio/migration: Add debugfs to live migration
 driver
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Alex Williamson <alex.williamson@redhat.com>
CC:     <shameerali.kolothum.thodi@huawei.com>,
        <jonathan.cameron@huawei.com>, <cohuck@redhat.com>,
        <linux-kernel@vger.kernel.org>, <linuxarm@openeuler.org>
References: <20230320092338.2889-1-liulongfang@huawei.com>
 <20230320092338.2889-2-liulongfang@huawei.com>
 <20230320153336.74b853c7.alex.williamson@redhat.com>
 <ZBjTXwZQs603zHy3@nvidia.com>
From:   liulongfang <liulongfang@huawei.com>
Message-ID: <41e59e5d-9bf7-2834-4fd1-09ec4c48fa24@huawei.com>
Date:   Tue, 21 Mar 2023 10:21:40 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <ZBjTXwZQs603zHy3@nvidia.com>
Content-Type: text/plain; charset="gbk"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/3/21 5:42, Jason Gunthorpe wrote:
> On Mon, Mar 20, 2023 at 03:33:36PM -0600, Alex Williamson wrote:
> 
>> This would allow that mlx5 and future drivers automatically get this
>> with no driver code, and in fact all devices would get debugfs dev_name
>> directories for better test coverage.  hisi_acc would only need to add
>> driver specific entries after registering the device and free any
>> related data after unregistering the device.  In this way, none of the
>> entry points here would need to be exported for drivers, which is
>> perhaps the direction Jason was thinking with his prior comments.
> 
> Yes, my point was more not to add more ops specifically to wrapper
> debugfs stuff. If drivers want a special debugfs file then there is
> lots of infrastructure to just create that off a common point
> 

OK! I understand what you and Alex are asking for.
I will re-debug a version based on your request.

Thanks.
Longfang.
> Jason
> .
>