From:   Peng Fan <peng.fan@nxp.com>
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        "andersson@kernel.org" <andersson@kernel.org>
CC:     "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "patrice.chotard@foss.st.com" <patrice.chotard@foss.st.com>,
        "mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
        "alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
        "arnaud.pouliquen@st.com" <arnaud.pouliquen@st.com>,
        Hongxing Zhu <hongxing.zhu@nxp.com>,
        "S.J. Wang" <shengjiu.wang@nxp.com>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 4/5] remoteproc: imx_rproc: Call of_node_put() on
 iteration error
Thread-Topic: [PATCH 4/5] remoteproc: imx_rproc: Call of_node_put() on
 iteration error
Thread-Index: AQHZW3npeLvbR93VJ06DycG3baoUhK8Eixew
Date:   Tue, 21 Mar 2023 03:00:02 +0000
Message-ID: <DU0PR04MB941720004CECD8CFC6AE5B5A88819@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20230320221826.2728078-1-mathieu.poirier@linaro.org>
 <20230320221826.2728078-5-mathieu.poirier@linaro.org>
In-Reply-To: <20230320221826.2728078-5-mathieu.poirier@linaro.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bEWpMj0yJVFr0U6aZ9h1V51N4ySXA8D2Xt2cqJDiNyxla37rSbdtScDtf514?=
 =?us-ascii?Q?cxY2H0+fifa6PWGkv/SjGhBGx90+ERInd2c2tWhrtMU+a5OeHaGzcoLBij7o?=
 =?us-ascii?Q?UbMTRj5idrgFEYohYNhbMpMMNFvbrrf7xWHRpepPhTbfO5LoRLemAg759l1z?=
 =?us-ascii?Q?oypxu4IRiAqhDrlE479ixiczPBKMnQ01Hqr5Fvs25izAdLtofo1x6Q4NaAng?=
 =?us-ascii?Q?4UJhnnqvDn1plJSteoa4HJV9MNHwd/IHS+gSQoQf0q5SLZLLKGQdTmfj0vqd?=
 =?us-ascii?Q?uwiAX3/0FBvGzlDLYhY4UbsyUmK8H0zCwRh85+2u1tKVmmraQlVFVAKK4lvy?=
 =?us-ascii?Q?zIJVC+s6GnreAn7I7lwxVDdG8nojTq4PpTXjM+w9cHPky6U23yhuu2TVX1cY?=
 =?us-ascii?Q?JnRPXoJNlLw0vxwXfchjTNuKE5gUcFJVDI16J0o2p6Trf7mbUJOfLYRmsYXu?=
 =?us-ascii?Q?Zid9O4UxoIuly0fKPwjjR6tn1cqD1vLk8tp+1CMykQVtvyE0lu6478nIEbCB?=
 =?us-ascii?Q?8EewfCita4npkKtXNVzloQ3cVTLfxKANeMVDvpir5GbLJeqPpOy1xrDnsnuf?=
 =?us-ascii?Q?3xGtRetNOPbT03847wqAOrYt3WTwvevGMxmW7n4UZz+wIijK1KAow5AmRMQA?=
 =?us-ascii?Q?aUG6A86nUdI7yTK8WZmf375M69oSq5Y1BSkiBH6XPEnHY3TgfNhrSFr8YXER?=
 =?us-ascii?Q?+H4AmtGIt8yI6JDyiLYA3baF05i7cJf0cYcSvW8YwrK7Chb3oDLvz1uQoWdB?=
 =?us-ascii?Q?/cTZ/IONNByPUGUd21hm5IZ39vFzpdSBdMJO7+xFf8Irrqd8uEqbVwKIo7Pw?=
 =?us-ascii?Q?JPfTwCXIkrruBrU9aNzFcSSo/AVLZvkzd3Tsftxu3C4LCD+RUb+xZd7zeP/1?=
 =?us-ascii?Q?U1ORPQFCm8YYNMwDrJNCjRPvzD7502jktCdDTHElod6C5X5FScgKL6FTV6G6?=
 =?us-ascii?Q?SXUYGRKq4B5YCHweGNXWdVVs/YNtbv7iWfE76NwLAlPOlsFn5vKWtAOVBzel?=
 =?us-ascii?Q?7s6a/YXpgaATUi3OwZi+2jW35BOi8MS+/dKFvg9Zy5tO8rbeEUHgwr39Gxxm?=
 =?us-ascii?Q?JU+wrcDEgdoJf4iChDomOffACbTcZqfPSB/zKP0gXMAYGdZg8qfE9+n/DP+p?=
 =?us-ascii?Q?im63BeJX0+0GQJYfdfmFbz6tzJkfeOruwskJ/XX3znbCRkdjo6Dkv8puwFxX?=
 =?us-ascii?Q?0bgR1mfESAZQ4Yp3/dfyiRKkXu2WUcPsCj5AHgt8RetMp2HMxXcCGPKl1RNt?=
 =?us-ascii?Q?aCfiUZ3WxnTDpuPc1Z3EIffEWH5ioF0YEdXqKx4UYQhu76vMJJ5JXgyNNj/Q?=
 =?us-ascii?Q?izU2q1tmz4/m+0ADuYA6iinIIUj0ZhpbJ6ANgQwdUWJs/ugsBzx2YLYEPUZy?=
 =?us-ascii?Q?HDdkicwl0lWuZVwcCOW4HnN8ThscdlN4raweSvqlTYuEGMtDKSLq09MRusHa?=
 =?us-ascii?Q?NKkFbgzHaxXYk/+s2WfLZoym2/Vg+rePBns+YViwriqyAq5oz/jA1oGZwtzr?=
 =?us-ascii?Q?jibQ3JNla8zO/QPlfeyir/Q9g6/4No8Dy1HDW0XpyiOLeoQUixZyAM9Sn4mT?=
 =?us-ascii?Q?gowX4HM1OlGGzBodbKA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b77f1791-d251-4730-09cb-08db29b85d9a
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2023 03:00:02.3998
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 01lI+N3xtxfxhLxZPERGXI01Hx2Zz5MSTz6YIc8Qa67sbGIvvGug5qM9+opy+rWz5gcKCl+PnWo1875KTnqyRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7564
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH 4/5] remoteproc: imx_rproc: Call of_node_put() on
> iteration error
>=20
> Function of_phandle_iterator_next() calls of_node_put() on the last
> device_node it iterated over, but when the loop exits prematurely it has =
to
> be called explicitly.
>=20
> Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse fw
> hook")
> Cc: stable@vger.kernel.org
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

LGTM:
Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  drivers/remoteproc/imx_rproc.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/remoteproc/imx_rproc.c
> b/drivers/remoteproc/imx_rproc.c index 9fc978e0393c..0ab840dc7e97
> 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -541,6 +541,7 @@ static int imx_rproc_prepare(struct rproc *rproc)
>=20
>  		rmem =3D of_reserved_mem_lookup(it.node);
>  		if (!rmem) {
> +			of_node_put(it.node);
>  			dev_err(priv->dev, "unable to acquire memory-
> region\n");
>  			return -EINVAL;
>  		}
> @@ -553,10 +554,12 @@ static int imx_rproc_prepare(struct rproc *rproc)
>  					   imx_rproc_mem_alloc,
> imx_rproc_mem_release,
>  					   it.node->name);
>=20
> -		if (mem)
> +		if (mem) {
>  			rproc_coredump_add_segment(rproc, da, rmem-
> >size);
> -		else
> +		} else {
> +			of_node_put(it.node);
>  			return -ENOMEM;
> +		}
>=20
>  		rproc_add_carveout(rproc, mem);
>  	}
> --
> 2.25.1