MIME-Version: 1.0
References: <20230320161823.1424278-1-sergio.paracuellos@gmail.com>
 <20230320161823.1424278-8-sergio.paracuellos@gmail.com> <966523bee1d28d546969a24eff60d315.sboyd@kernel.org>
 <CAMhs-H-y6TsSoKsJzM0gkFk6wx7xNigXKJb7wm8rBzrigtJANg@mail.gmail.com> <90dd1f841e7941d8b5931ef68cd6d14e.sboyd@kernel.org>
In-Reply-To: <90dd1f841e7941d8b5931ef68cd6d14e.sboyd@kernel.org>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Tue, 21 Mar 2023 05:23:26 +0100
Message-ID: <CAMhs-H8A-c0wo0vExRP_e9my6vzuOkoYwJ2WBTsnjh-X5iK08A@mail.gmail.com>
Subject: Re: [PATCH 07/10] mips: ralink: remove clock related function prototypes
To:     Stephen Boyd <sboyd@kernel.org>
Cc:     linux-clk@vger.kernel.org, linux-mips@vger.kernel.org,
        tsbogend@alpha.franken.de, john@phrozen.org,
        linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
        mturquette@baylibre.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
        devicetree@vger.kernel.org, arinc.unal@arinc9.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Mar 20, 2023 at 10:21=E2=80=AFPM Stephen Boyd <sboyd@kernel.org> wr=
ote:
>
> Quoting Sergio Paracuellos (2023-03-20 13:17:47)
> > Hi Stephen,
> >
> > On Mon, Mar 20, 2023 at 8:38=E2=80=AFPM Stephen Boyd <sboyd@kernel.org>=
 wrote:
> > >
> > > Quoting Sergio Paracuellos (2023-03-20 09:18:20)
> > > > Clock related code has been removed from 'arch/mips/ralink' folder =
and put
> > > > into drivers space. Hence remove clock related prototypes which are=
 not
> > > > used anymore.
> > > >
> > > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > > > ---
> > > >  arch/mips/ralink/common.h | 3 ---
> > > >  1 file changed, 3 deletions(-)
> > > >
> > > > diff --git a/arch/mips/ralink/common.h b/arch/mips/ralink/common.h
> > > > index 87fc16751281..fcdfc9dc6210 100644
> > > > --- a/arch/mips/ralink/common.h
> > > > +++ b/arch/mips/ralink/common.h
> > > > @@ -23,9 +23,6 @@ extern struct ralink_soc_info soc_info;
> > > >
> > > >  extern void ralink_of_remap(void);
> > > >
> > > > -extern void ralink_clk_init(void);
> > >
> > > Why isn't this removed in the patch that removes the function?
> >
> > Because the function exists for all the SoCs code and there are
> > several patches removing it; one per SoC, so I decided to remove this
> > at the end. Should I squash all patches together instead?
>
> No. But you should squash this with whatever patch removes the last one.

Ah, ok. I see your point. I will squash this with the last removal, then.

Thanks,
    Sergio Paracuellos