Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 642BFC74A5B for ; Tue, 21 Mar 2023 04:26:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbjCUE0s (ORCPT ); Tue, 21 Mar 2023 00:26:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbjCUE0q (ORCPT ); Tue, 21 Mar 2023 00:26:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 602BD25B89; Mon, 20 Mar 2023 21:26:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA98161956; Tue, 21 Mar 2023 04:26:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DD53C433EF; Tue, 21 Mar 2023 04:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679372804; bh=gFv2aJXUNwQ6ce5qb8/S45PJIP1goGD7SztFmscEBK4=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=ZCQ3QoI8+QJQc3XlXdyZ5dh78y+QsEnWOJq3FJxxT+AYDI8yAcLPIgHDexL3QYmog jbcz0K6urVz2e5uVwyAE2HcqpJb5zWKxHCAhSpwmHwAr4rl+mfb2VgeBlwBa6YZg3l 6qNpgIcCgrwPQ367VOpkVwVDKBeLfzD2wIBVieqIsbbeMVKHOMeddR/MCzCkcdd1nN TmreiErhxzI2QWthem3VKjPOOmaR8rd4l5b5CuxRC0aTlx35coaxPAElChpyf+aYlS iXq+PVl2ejh21v/rKLYAAbDCq8oj7vddR7CZt35lVdvgi/6evNaXZTb+UAjghHuikm tW0n1XMLERNYg== Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id EB8F91540395; Mon, 20 Mar 2023 21:26:43 -0700 (PDT) Date: Mon, 20 Mar 2023 21:26:43 -0700 From: "Paul E. McKenney" To: "Zhuo, Qiuxu" Cc: "dave@stgolabs.net" , "frederic@kernel.org" , "jiangshanlai@gmail.com" , "joel@joelfernandes.org" , "josh@joshtriplett.org" , "linux-kernel@vger.kernel.org" , "mathieu.desnoyers@efficios.com" , "quic_neeraju@quicinc.com" , "rcu@vger.kernel.org" , "rostedt@goodmis.org" Subject: Re: [PATCH v2 1/1] rcu/rcuscale: Stop kfree_scale_thread thread(s) after unloading rcuscale Message-ID: <72ba8619-88cb-4bf4-8232-18d8a1b6b5bf@paulmck-laptop> Reply-To: paulmck@kernel.org References: <2bbaa13a-bfcc-45b7-acce-8da59a2a0c32@paulmck-laptop> <20230317055006.46365-1-qiuxu.zhuo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2023 at 01:21:21AM +0000, Zhuo, Qiuxu wrote: > > From: Paul E. McKenney > > Sent: Tuesday, March 21, 2023 4:41 AM > > [...] > > > > > > Fixes: e6e78b004fa7 ("rcuperf: Add kfree_rcu() performance Tests") > > > Signed-off-by: Qiuxu Zhuo > > > > Much better! > > > > Except that someone glancing at this patch would be hard pressed to see > > what changed. > > Indeed. > > > So could you please split this into two patches, the first of which does > > nothing but move code, and the second of which makes the actual change? > > OK. > Will split this patch into two patches in the v3. > > > The commit log for the first patch needs to clearly state that the it is code- > > motion-only, with no change in behavior. > > OK. > Thanks so much for your suggestions ;-) Looking forward to seeing the next version! Thanx, Paul