Message-ID: <4a1f33bb-882a-ed49-9e0e-b463203e0ea9@ti.com>
Date:   Tue, 21 Mar 2023 10:07:13 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH V3 1/2] arm64: dts: ti: k3-am62-wakeup: Introduce RTC node
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Tero Kristo <kristo@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Julien Panis <jpanis@baylibre.com>, <bb@ti.com>
References: <20230320165123.80561-1-nm@ti.com>
 <20230320165123.80561-2-nm@ti.com>
From:   Dhruva Gole <d-gole@ti.com>
In-Reply-To: <20230320165123.80561-2-nm@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 20/03/23 22:21, Nishanth Menon wrote:
> Introduce digital RTC node in wakeup domain. Even though this has
> no specific battery backup supply, this on-chip RTC is used in
> cost-optimized board designs as a wakeup source.
>
> Reviewed-by: Dhruva Gole <d-gole@ti.com>
> Reviewed-by: Bryan Brattlof <bb@ti.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Changes since v2:
> - Just reviewed-by pickups
>
> V2: https://lore.kernel.org/all/20230315170706.1598977-2-nm@ti.com/
> V1: https://lore.kernel.org/all/20230311105850.21811-2-nm@ti.com/
>
>  arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> index 38dced6b4fef..fec81546fbbd 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> @@ -40,4 +40,14 @@ wkup_i2c0: i2c@2b200000 {
>  		clock-names = "fck";
>  		status = "disabled";
>  	};
> +
> +	wkup_rtc0: rtc@2b1f0000 {
> +		compatible = "ti,am62-rtc";
> +		reg = <0x00 0x2b1f0000 0x00 0x100>;
> +		interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&k3_clks 117 6> , <&k3_clks 117 0>;
> +		clock-names = "vbus", "osc32k";
> +		power-domains = <&k3_pds 117 TI_SCI_PD_EXCLUSIVE>;
> +		wakeup-source;
> +	};
>  };

I was just wondering why some of the rtctests show failures on this platform:

https://gist.github.com/DhruvaG2000/5c6d8bb99b087308b916985d70f0c440

pass:5 fail:2

the test is compiled from tools/testing/selftests/rtc/rtctest.c for arm64 target

Is this expected?

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated