MIME-Version: 1.0
References: <20230311114248.36587-1-adobriyan@gmail.com> <20230311114248.36587-3-adobriyan@gmail.com>
In-Reply-To: <20230311114248.36587-3-adobriyan@gmail.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Tue, 21 Mar 2023 15:02:01 +0900
Message-ID: <CAK7LNASCCKXGo2ODHFdijgJ7b0CTyK50Lo4VUsJyBfsfZWSMog@mail.gmail.com>
Subject: Re: [PATCH 3/3] menuconfig: reclaim vertical space
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Mar 11, 2023 at 8:43=E2=80=AFPM Alexey Dobriyan <adobriyan@gmail.co=
m> wrote:
>
> Menuconfig has lots of vertical space wasted: on my system there are
> 17 lines of useful information about config options and 14 lines of
> useless fluff: legend, horizontal separators and shadows.
>
> Sitation is even worse on smaller terminals because fixed vertical
> lines do not go away, but config option lines do, further decreasing
> informational density. Minimum reasonable 80=C3=9724 text console has onl=
y
> 10(!) lines of menus presented which is less than half of the screen.


I think nconfig is a better fit for your system.


In my understanding, the concept of menuconfig
is to use a similar appearance to the 'dialog' tool
although we have largely modified the code.


>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>  scripts/kconfig/lxdialog/menubox.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialo=
g/menubox.c
> index 5eb67c04821f..dc608914c636 100644
> --- a/scripts/kconfig/lxdialog/menubox.c
> +++ b/scripts/kconfig/lxdialog/menubox.c
> @@ -183,14 +183,14 @@ int dialog_menu(const char *title, const char *prom=
pt,
>         if (height < MENUBOX_HEIGTH_MIN || width < MENUBOX_WIDTH_MIN)
>                 return -ERRDISPLAYTOOSMALL;
>
> -       height -=3D 4;
> +       height -=3D 2;
>         menu_height =3D height - 10;
>
>         max_choice =3D MIN(menu_height, item_count());
>
>         /* center dialog box on screen */
> -       x =3D (getmaxx(stdscr) - width) / 2;
> -       y =3D (getmaxy(stdscr) - height) / 2;
> +       x =3D 0;
> +       y =3D 2;
>
>         dialog =3D newwin(height, width, y, x);
>         keypad(dialog, TRUE);
> --
> 2.39.2
>


You missed to adjust dialog_textbox().


(1) Run 'make menuconfig'
(2) Press < Help > button to show help message
(3) Press < Exit > button to get back


When you do (2) and (3), please make sure
the size of the grey window is not changed.

This is how the current menuconfig works.


I want to leave the blue frame.
My personal preference is

  height -=3D 3;
  width -=3D 2;


--
Best Regards
Masahiro Yamada