From:   Gaurav Jain <gaurav.jain@nxp.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Horia Geanta <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH] crypto: caam: Clear some memory in
 instantiate_rng()
Thread-Topic: [EXT] Re: [PATCH] crypto: caam: Clear some memory in
 instantiate_rng()
Thread-Index: AQHZW6T8qM2pEJHQqE6oUcuL8PwIJ68ErEqQgAACSYCAABtSoA==
Date:   Tue, 21 Mar 2023 06:55:11 +0000
Message-ID: <AM0PR04MB60043E404C9175C7918BD676E7819@AM0PR04MB6004.eurprd04.prod.outlook.com>
References: <16d6bf3bd7a6e96a8262fcd4680e3ccbb5a50478.1679355849.git.christophe.jaillet@wanadoo.fr>
 <ZBkj9tUFl8OJeoic@gondor.apana.org.au>
 <AM0PR04MB6004F6DC17B8CB859D13EF1EE7819@AM0PR04MB6004.eurprd04.prod.outlook.com>
 <ZBk7ZdSacxFzJSxJ@gondor.apana.org.au>
In-Reply-To: <ZBk7ZdSacxFzJSxJ@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MG5TtHbnQ8zaBvtWGIgeCCH23s837KxOq8QDkIjxKenl7KsLn1LR0rpTnIc1?=
 =?us-ascii?Q?H8b1Xe2+2lLhq+P/KG4JLgjru91bgZhblOk0jidQpFOVrWv1+wqCLHz58LIZ?=
 =?us-ascii?Q?yw8+rumKmU1sJWoOyN6iw8YFFQDY7AMUVPT6lQ1NGyIAeC2bff7hK9tluiBb?=
 =?us-ascii?Q?couKqjNGX/rXUHTWFpdiRz7vKHkf5ZsaESCReIOzjEevpc74sSJBhaS5ii8q?=
 =?us-ascii?Q?1FfY2fCe8YknZ56MB80SrHIZpEpHWoYct7w4HLJtcKyTYO6QjjadO00EZiXz?=
 =?us-ascii?Q?zSEFC4fRWS4xsjf9jeURF4xVBabrIHGSLQUchARppho4W8Tm88yUUJO7UvjR?=
 =?us-ascii?Q?7HzLW2mJly5weA37ZLd3Q7XZjk1QSYFeA7qf6niev5o0cfAmEj7fF9ZWkeRl?=
 =?us-ascii?Q?pEvLuNIJSxexu8j7zdkPSoT63C3HWt82/oee4cz4W7JR1oSGr0xX70to0/7P?=
 =?us-ascii?Q?TP4Obr/cWDFsX0xnskZ0usTyYzzpzBe8csAt+wqRpELEZF5E3WdO2G5OFM/X?=
 =?us-ascii?Q?PJVZ75wPpbQRG8YjJvVbhDoC8OuTCWnn8NL8v3Ylx3xNrdMduD/UxlzhqXYn?=
 =?us-ascii?Q?30rQhcCKvOBiahCL4XeavBk11uiI6D+3hfBZ31JpW2WO//INuFzNqC7F7GH+?=
 =?us-ascii?Q?dWKp08KS2WzE5KxYyf/A/Fw02iAR8YajDvpC+FcMUiffvQsxiDn3pta3xtfw?=
 =?us-ascii?Q?hc5Bcp6XCKOFxYeYDvOJS+nWUcrXbYuH38UF2nFV7WwL7uwOhAosonAZfppZ?=
 =?us-ascii?Q?1iuYrP+aGmJ3T735jujUD5XpyrN25VY+a7fuZA3abMCEl1fPgizJQAAAEIBc?=
 =?us-ascii?Q?9Bq4bOxWJcsMqsRqvhZBES+E5+u0f7MCJNnow2HJF2QqU67I1Gr+RAD9bsjM?=
 =?us-ascii?Q?kn7NChiVavcJRzrJuSXIWo/OIM8eP4ffmwdNM7urOVn6NNWo1CiTuFcRz6w9?=
 =?us-ascii?Q?R0uYiLGYMxfj7Cptxx6kl7CcJF4NUUJF35DJjxa3KqnqBzfNaxKs6lcO/91G?=
 =?us-ascii?Q?XbFR9pjmgixm6qCRlxSh5BzEso7LipWYB+WMsjE2gqzh16yyfhc91RKUUB7w?=
 =?us-ascii?Q?O057nk5YwNs+9XOoWk9i8j5YvNjJ84MQFbe+1xcOs+I1GU0hUbCSztl8UQUh?=
 =?us-ascii?Q?51JTf7dfxPj4ogLTlYhLIDCcqmKMOqE4GeqR5jB4LxN+oChdaASJbReNZ2Zn?=
 =?us-ascii?Q?fAlGzyjdQwzH6+SWpRZ7haP0AxyZD3O3JO0yw+ksgDcMW+wAk6xIWsWtbeti?=
 =?us-ascii?Q?Oh+bZJ8p+TLKxIXvy83RdUANpxt/4wSlwShJdVqTng0eoNlIVL5gbaXVoR3p?=
 =?us-ascii?Q?MUROV6IQkTFv7UbIuEluTWMHwAjkZPdf3qD5miUn1x0YXOI3ZlIXyUL269xU?=
 =?us-ascii?Q?Ss3HRWtBhzXaaLsTrmu3l2blld5smMHoHFi4xUKBpKrKv0KoqenhKUcOK0pg?=
 =?us-ascii?Q?2ItH7zU5roZcl0Ybm0c/mJRR4K/pKNwlMKvVlCPHAPF7tWh7Fd3VE0swTmGO?=
 =?us-ascii?Q?UXvm6sReAqrBcymXdKGACzoudWF8UkWFfZ+t2gQMbd+oo5duRT143HSVu5a1?=
 =?us-ascii?Q?aFMlo3Dxao86GkCMyHHbZdLh0cszutEZzH+4SKDd?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6004.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b20e6b98-228b-4b85-025a-08db29d93740
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2023 06:55:11.4484
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LYgQpA3DL4Hj3NsVLi6YxETF+SUktA/1G2fRKF0Qe2MO/qYBO9774w9bZg/sxIqLfCZGEHCLO1pjBKJYKtBNEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7823
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi

> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Tuesday, March 21, 2023 10:37 AM
> To: Gaurav Jain <gaurav.jain@nxp.com>
> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>; Horia Geanta
> <horia.geanta@nxp.com>; Pankaj Gupta <pankaj.gupta@nxp.com>;
> davem@davemloft.net; linux-crypto@vger.kernel.org; linux-
> kernel@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: Re: [EXT] Re: [PATCH] crypto: caam: Clear some memory in
> instantiate_rng()
>=20
> Caution: EXT Email
>=20
> On Tue, Mar 21, 2023 at 05:03:24AM +0000, Gaurav Jain wrote:
> >
> > memset() is needed to clear the desc for each state handle before
> recreating descriptor.
> > So it is required.
>=20
> OK so we should move it to the top of the loop then.
kzalloc() will zeroize the contents of desc for the first time.
In this case memset() is ok at the end for instantiating other rng handles.
=20
Thanks
Gaurav

>=20
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fgondor
> .apana.org.au%2F~herbert%2F&data=3D05%7C01%7Cgaurav.jain%40nxp.com%
> 7C46125a50355a466bbd6208db29ca159a%7C686ea1d3bc2b4c6fa92cd99c5c3
> 01635%7C0%7C0%7C638149720177317067%7CUnknown%7CTWFpbGZsb3d8
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> D%7C3000%7C%7C%7C&sdata=3DDmvSAsFT0dY%2FL%2FP5lcw90hR0FYAKRdnI
> kZxiaMN1MVk%3D&reserved=3D0
> PGP Key:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fgondor
> .apana.org.au%2F~herbert%2Fpubkey.txt&data=3D05%7C01%7Cgaurav.jain%4
> 0nxp.com%7C46125a50355a466bbd6208db29ca159a%7C686ea1d3bc2b4c6fa
> 92cd99c5c301635%7C0%7C0%7C638149720177317067%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> CI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D8NA1ediu3cnWLFbisXecjq5Z%2BuK
> uztPYtlcRDCPSMno%3D&reserved=3D0