MIME-Version: 1.0
References: <20230319133732.1702841-1-trix@redhat.com>
In-Reply-To: <20230319133732.1702841-1-trix@redhat.com>
From:   Jun Nie <jun.nie@linaro.org>
Date:   Tue, 21 Mar 2023 15:05:07 +0800
Message-ID: <CABymUCMha=XE_=LDNXiJDzhNCpGU4bckuNkoCAmb_bWO8bPu0w@mail.gmail.com>
Subject: Re: [PATCH] usb: typec: tipd: remove unused tps6598x_write16,32 functions
To:     Tom Rix <trix@redhat.com>
Cc:     heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
        nathan@kernel.org, ndesaulniers@google.com, sven@svenpeter.dev,
        agx@sigxcpu.org, Jonathan.Cameron@huawei.com,
        u.kleine-koenig@pengutronix.de, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Tom Rix <trix@redhat.com> =E4=BA=8E2023=E5=B9=B43=E6=9C=8819=E6=97=A5=E5=91=
=A8=E6=97=A5 21:37=E5=86=99=E9=81=93=EF=BC=9A
>
> clang with W=3D1 reports
> drivers/usb/typec/tipd/core.c:180:19: error: unused function
>   'tps6598x_write16' [-Werror,-Wunused-function]
> static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val)
>                   ^
> drivers/usb/typec/tipd/core.c:185:19: error: unused function
>   'tps6598x_write32' [-Werror,-Wunused-function]
> static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val)
>                   ^
> These static functions are not used, so remove them.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/usb/typec/tipd/core.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
Reviewed-by: Jun Nie <jun.nie@linaro.org>