Message-ID: <b651a7f5-3d61-fe8b-13b0-7f0caf0f21fd@ti.com>
Date:   Tue, 21 Mar 2023 13:02:55 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2 0/4] arm64: dts: ti: j7: Add device-tree nodes for
 MCSPI
To:     Vaishnav Achath <vaishnav.a@ti.com>, <nm@ti.com>,
        <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <u-kumar1@ti.com>, <j-luthra@ti.com>
References: <20230321065447.6997-1-vaishnav.a@ti.com>
Content-Language: en-US
From:   "J, KEERTHY" <j-keerthy@ti.com>
In-Reply-To: <20230321065447.6997-1-vaishnav.a@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/21/2023 12:24 PM, Vaishnav Achath wrote:
> This series adds device tree nodes for Multi Channel Serial Peripheral
> Interface (MCSPI) on J721E, J7200, J721S2 and J784S4 platforms. All the
> MCSPI instances are disabled by default and can be enabled through overlays
> as required, the changes were tested using spidev loopback test for all
> instances and the data verified only for main_spi4 which is connected
> internally as slave to mcu_spi2 for all existing J7 devices.
> 
> V1->V2:
>    * Address Nishanth's feedback, combine main, mcu domain
>    MCSPI node addition changes to single commit per SoC.

Vaishnav,


As per TRM "MCSPI4 is directly connected as a slave to MCU_MCSPI2 by 
default at power-up. MCSPI4 and MCU_MCSPI2 are not pinned out externally".

The above is applicable to J721e/J7200. Similar mapping might be 
existing for j721s2 & j784s4 as well. Add this information in
the commit log. Other than that For the series:

Reviewed-by: Keerthy <j-keerthy@ti.com>

Regards,
Keerthy

> 
> Vaishnav Achath (4):
>    arm64: dts: ti: k3-j721e: Add MCSPI nodes
>    arm64: dts: ti: k3-j7200: Add MCSPI nodes
>    arm64: dts: ti: k3-j721s2: Add MCSPI nodes
>    arm64: dts: ti: k3-j784s4: Add MCSPI nodes
> 
>   arch/arm64/boot/dts/ti/k3-j7200-main.dtsi     | 88 +++++++++++++++++++
>   .../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi      | 33 +++++++
>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 88 +++++++++++++++++++
>   .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi      | 33 +++++++
>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi    | 88 +++++++++++++++++++
>   .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi     | 33 +++++++
>   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi    | 88 +++++++++++++++++++
>   .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi     | 33 +++++++
>   8 files changed, 484 insertions(+)
>