Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3839C74A5B for ; Tue, 21 Mar 2023 07:34:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229927AbjCUHeh (ORCPT ); Tue, 21 Mar 2023 03:34:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbjCUHef (ORCPT ); Tue, 21 Mar 2023 03:34:35 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3D8135EC4 for ; Tue, 21 Mar 2023 00:34:06 -0700 (PDT) Received: from kwepemm600013.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PgjwL6MvWzKq3Z; Tue, 21 Mar 2023 15:31:46 +0800 (CST) Received: from [10.174.178.46] (10.174.178.46) by kwepemm600013.china.huawei.com (7.193.23.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 21 Mar 2023 15:34:02 +0800 Subject: Re: [PATCH] ubifs: remove return in compr_exit() To: Yangtao Li , Richard Weinberger CC: , References: <20230321071136.68872-1-frank.li@vivo.com> From: Zhihao Cheng Message-ID: <61bd9c01-5e5d-76b0-103a-323a5bf0fa33@huawei.com> Date: Tue, 21 Mar 2023 15:34:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20230321071136.68872-1-frank.li@vivo.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600013.china.huawei.com (7.193.23.68) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > It's redundant, let's remove it. > > Signed-off-by: Yangtao Li > --- > fs/ubifs/compress.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Zhihao Cheng > > diff --git a/fs/ubifs/compress.c b/fs/ubifs/compress.c > index 3a92e6af69b2..75461777c466 100644 > --- a/fs/ubifs/compress.c > +++ b/fs/ubifs/compress.c > @@ -217,7 +217,6 @@ static void compr_exit(struct ubifs_compressor *compr) > { > if (compr->capi_name) > crypto_free_comp(compr->cc); > - return; > } > > /** >