MIME-Version: 1.0
References: <20230320163823.886-1-clin@suse.com> <20230320163823.886-5-clin@suse.com>
 <CAHp75VfFTjPFMQ91yHC4O1enTJqtww7ur8ppwa1rqT_7WNzDTQ@mail.gmail.com> <ZBk7/h4nquwZShv1@linux-8mug>
In-Reply-To: <ZBk7/h4nquwZShv1@linux-8mug>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 21 Mar 2023 09:39:28 +0200
Message-ID: <CAHp75VdbUH6D2drFwpdX06EwqqJhkNm1jq8ABrw5oZw79frziw@mail.gmail.com>
Subject: Re: [PATCH v2 4/4] pinctrl: s32cc: embed generic struct pingroup and pinfunction
To:     Chester Lin <clin@suse.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        NXP S32 Linux Team <s32@nxp.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Ghennadi Procopciuc <Ghennadi.Procopciuc@oss.nxp.com>,
        Andrei Stefanescu <andrei.stefanescu@nxp.com>,
        Radu Pirea <radu-nicolae.pirea@nxp.com>,
        =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>,
        Matthias Brugger <mbrugger@suse.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Mar 21, 2023 at 7:09=E2=80=AFAM Chester Lin <clin@suse.com> wrote:
> On Mon, Mar 20, 2023 at 07:10:40PM +0200, Andy Shevchenko wrote:
> > On Mon, Mar 20, 2023 at 6:39=E2=80=AFPM Chester Lin <clin@suse.com> wro=
te:

...

> > >         for_each_child_of_node(np, child) {
> > > -               func->groups[i] =3D child->name;
> > > +               groups[i] =3D (char *)child->name;

Here is also questionable casting.

...

> > > +       func->groups =3D (const char **)groups;
> >
> > Hmm... Why is casting needed?
>
> It's used for fulfilling the type checking done by kbuild otherwise an er=
ror will occur:
>
> drivers/pinctrl/nxp/pinctrl-s32cc.c:815:22: error: assignment to 'const c=
har * const*' from incompatible pointer type 'char **' [-Werror=3Dincompati=
ble-pointer-types]
>
> In 'struct pinfunction', the member 'groups' is declared as (const char *=
 const *).

So, please decouple `struct pingroup` change to a separate patch and
hence `struct pinfunction` on its own.

After, consider changing types elsewhere that are following the types
in that data structures.

--=20
With Best Regards,
Andy Shevchenko