Message-ID: <61ee85961cbab30f9e7e56771bbe8f9b5b7753b8.camel@redhat.com>
Subject: Re: [RFC PATCH v2 0/6] Deduplicating RISCV cmpxchg.h macros
From:   Leonardo =?ISO-8859-1?Q?Br=E1s?= <leobras@redhat.com>
To:     Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>
Cc:     linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Tue, 21 Mar 2023 04:44:04 -0300
In-Reply-To: <20230321063430.2218795-1-leobras@redhat.com>
References: <20230321063430.2218795-1-leobras@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-03-21 at 03:34 -0300, Leonardo Bras wrote:
> While studying riscv's cmpxchg.h file, I got really interested in=20
> understanding how RISCV asm implemented the different versions of=20
> {cmp,}xchg.
>=20
> When I understood the pattern, it made sense for me to remove the=20
> duplications and create macros to make it easier to understand what exact=
ly=20
> changes between the versions: Instruction sufixes & barriers.
>=20
> I split those changes in 3 levels for each cmpxchg and xchg, resulting a=
=20
> total of 6 patches. I did this so it becomes easier to review and remove=
=20
> the last levels if desired, but I have no issue squashing them if it's=
=20
> better.
>=20
> Please provide comments.
>=20
> Thanks!
> Leo
>=20
> Changes since v1:
> - Fixed patch 4/6 suffix from 'w.aqrl' to '.w.aqrl', to avoid build error
>=20
> Leonardo Bras (6):
>   riscv/cmpxchg: Deduplicate cmpxchg() asm functions
>   riscv/cmpxchg: Deduplicate cmpxchg() macros
>   riscv/cmpxchg: Deduplicate arch_cmpxchg() macros
>   riscv/cmpxchg: Deduplicate xchg() asm functions
>   riscv/cmpxchg: Deduplicate xchg() macros
>   riscv/cmpxchg: Deduplicate arch_xchg() macros
>=20
>  arch/riscv/include/asm/cmpxchg.h | 316 +++++++------------------------
>  1 file changed, 64 insertions(+), 252 deletions(-)
>=20

Re-sending, since it seems to have not worked with patchwork properly.