Date:   Tue, 21 Mar 2023 09:01:43 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Sean Anderson <seanga2@gmail.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 7/9] net: sunhme: Clean up mac address init
Message-ID: <ZBlkZxOxxfFnIMyu@corigine.com>
References: <20230314003613.3874089-1-seanga2@gmail.com>
 <20230314003613.3874089-8-seanga2@gmail.com>
 <ZBV+cK8YAXI15tsL@corigine.com>
 <7389fef5-8fe8-4f24-f762-4f3597ad0943@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7389fef5-8fe8-4f24-f762-4f3597ad0943@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?R4zfSVuMQV5BIqlXH/VgljqwK9n7dBTl76JxIHW1FBY6TrXGr3u2Qu2gy5DJ?=
 =?us-ascii?Q?fg4Nd1+Dcv6CKOLU1SNfBvc0AIBoqr6zSgQxyi3XfrKN9jwV+1XBIaYwvm0I?=
 =?us-ascii?Q?sVlDkEoZKGuyU+5V9i2kt0MIGQ19vX6Yu/KRiU6L6xjllw1oga2Tu4VzJMmZ?=
 =?us-ascii?Q?GyQ2CMs0ZIw/0ddPDyFpe40PGnkTwWcleJsAkrCsN3nzMHQ4kaSJAdznE0ZE?=
 =?us-ascii?Q?Bza2t3LOlh8fQjGXp1ouB/FralJ/5CsUDu+HqUPAxqy6gPqTWSsdzZDrtT3u?=
 =?us-ascii?Q?edp9z5OqpjzjrF1b1J0y54hr6uODFNTdc9N224m16KVVNE2lxuUxMlMr5q9X?=
 =?us-ascii?Q?EQyFOFEe+GW4TcrUYi96LtI0QN1UX7eNuflpX3xpaInzoiFpdtlVWekcIMVX?=
 =?us-ascii?Q?XtwkkeNisTRTqc1+OFiNgrv6cWl4x0nSa6Edbvdg5XoE+o2HNXzGy3acRl8S?=
 =?us-ascii?Q?RxFe/+h8HfVpAed7QKUlbp3iTZ7KYQBmOSk3IzblR441rBwVx67hlek9t7H4?=
 =?us-ascii?Q?zftU6ZmIqtA1qyE/t0HUQZZDmVZnfF0CunpAOUIe5IhCp5qIJSOk0G09YS9V?=
 =?us-ascii?Q?2rAQO0F85a3+VsOq/9ksFYZ42EwbeiBEcMzK/HZLdrRxBdaMRtYcU1CGIVtd?=
 =?us-ascii?Q?M3N5ln7H13N9ecirPMXKLzYnk9yL44+DZ5K3ZyIvBgftbw3iI6t/z5Bm0t59?=
 =?us-ascii?Q?SN2Ouv5zxcYCZnWRC8U6R2Oq2OC34URzJYP7bUM3hsUqiC/+bfb5EbvbVrU9?=
 =?us-ascii?Q?ktjMzy+15CRubSJJsfXkv82xXuThPTemjnZZll8RZj5O937gwXnVQvnkRK9Q?=
 =?us-ascii?Q?TNFGmLQtM4PL2whLFXfMD1iuMnjHKnKaMHZbLTYbcNDF1oxc4ad0ecy3mcVm?=
 =?us-ascii?Q?vC1DgzI0EIamOYSxayhk/88AJf0RWPwtByhvp/JoiMek/cHFGT1cl1BSQgPq?=
 =?us-ascii?Q?bADgrs9WzOPL59GJioo1zJZfwwLMF/udkJ3uZWGZiRPPAoAqpD8PMFzZPZT/?=
 =?us-ascii?Q?w+WGfFTFpunIY/UBdd3Xpga05YgAtGPQ0thgcSs1S01vLTCAmo4ApKvsyMiu?=
 =?us-ascii?Q?GjAoSXj7l5Z5vDU9Q2FrK8pCSsmGoFox1tBPzbRfiY7QS4JNqhH0fVaAq1YS?=
 =?us-ascii?Q?Cnmzirf11mzHdekwQ1vf5lnTa4uD//Zv+ud2wgbITEHSUxXc18GHm1eU8BIq?=
 =?us-ascii?Q?JK3BJTKiZy+e1qF8YopyokMaJ6ZAsQ5oztbvgr1B99B1e2YDAM7XbMoWrvw2?=
 =?us-ascii?Q?G8u2ZiyVs0BYMVwz6ZTQj27qJa5D+VCbD8DKnCxM7haZrzN2JZqFWqXE5LC9?=
 =?us-ascii?Q?NdhB1mcwNJBg83ASLWm2nqSI7q61JL77q0gQVlU/bdOVng9H9ZGFQ775wGeU?=
 =?us-ascii?Q?GhEglp2a5q95kp4f7fvfl+G246LZffW9Q3a/2jv2RpJGDVRXhGn41bYJAo1W?=
 =?us-ascii?Q?oPm+ILhxOHSuNyPIwQqktHVZXBNmLe1lOz8ePutVbR58cVwtwGKf4tZv352r?=
 =?us-ascii?Q?tf6V2Nn9haekWgI1UA8H2ociaGU1ZYYCoiv6qrd14crzCQZ2Ay7P4ZsVpjqR?=
 =?us-ascii?Q?AAsXJT+lnuopKjS8WbV8L9aOszS3jHHMRmHHyNbs3G3jKY/gH2xetsVTm7s1?=
 =?us-ascii?Q?llCN0tkDDkr5Ju5ZYOZfsfHglb52YFY63OwPl5laNl+LYX4uHQENelM6MXQb?=
 =?us-ascii?Q?CBkUbA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 246091d2-d288-49a2-1ec7-08db29e285ba
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 08:01:48.7378
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hsGibkSTuyMvzXJkiiSNnYafr2Zs0ktsbnLuJTm18KJ4GqZaoV34kRBqx24b0fjZ6BNkNXOUhtU6pOl8x1bh7eFeQRnPxjsA5MGLmJfv9d4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB4494
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Mar 18, 2023 at 11:43:16AM -0400, Sean Anderson wrote:
> On 3/18/23 05:03, Simon Horman wrote:
> > On Mon, Mar 13, 2023 at 08:36:11PM -0400, Sean Anderson wrote:
> > > Clean up some oddities suggested during review.
> > > 
> > > Signed-off-by: Sean Anderson <seanga2@gmail.com>

...

> > > @@ -2386,7 +2385,7 @@ static void __maybe_unused get_hme_mac_nonsparc(struct pci_dev *pdev,
> > >   	dev_addr[2] = 0x20;
> > >   	get_random_bytes(&dev_addr[3], 3);
> > >   }
> > > -#endif /* !(CONFIG_SPARC) */
> > > +#endif
> > 
> > Hi Sean,
> > 
> > I think this problem was added by patch 6/9,
> > so perhaps best to squash it into that patch.
> 
> > Actually, I'd squash all these changes into 6/9.
> > But I don't feel strongly about it.
> 
> 6/9 just moves code around. I am keeping the modifications for other commits.

Ack.