Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5212AC761A6 for ; Tue, 21 Mar 2023 08:15:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231177AbjCUIPH (ORCPT ); Tue, 21 Mar 2023 04:15:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231165AbjCUIOW (ORCPT ); Tue, 21 Mar 2023 04:14:22 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2618615C89 for ; Tue, 21 Mar 2023 01:14:18 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id x3so56295491edb.10 for ; Tue, 21 Mar 2023 01:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679386456; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/GlY80fVC6uH/ZqU7yXSUIACPGr/6fR1rzfz7PKIC1U=; b=XTHClEkFj9/GzezOJiRBJAo+Tywih9fsnGLCx2EvfPO7EkU3qr0lhvujZ4rV/hC0bA AQzYjyLPOMFzqaZRQNA1Hxz63j2WJ92NwAyEG19ijt2gJb1h1nT92mk7a+ADJpaLc2e7 jFytPhvYu6J1WM7YTxzs57YNFmKYVV2BWBRBjnOwgUHjAuopWFAQUVCrzb1Wb5KZnHrY VelFH6I+KLmKhYtvQdVPZca5ss7DQZTbQ2Z6wf1VUAasYPb848o2f3kJqWRkWA/7vJxa xXaYt68thkNcW5U3sUxorS9a6d+oVSnF1fyvyTfSyWb5H8c9CClCTZuj2H3xTQNJFAV9 IonQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679386456; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/GlY80fVC6uH/ZqU7yXSUIACPGr/6fR1rzfz7PKIC1U=; b=7izntjw6/7XwsgM5kjgF7sCMChX40W50y38L6Dztia6XAIG3NL8EOuaSLXfgYjIMJ6 KVTzuHNSPQ+MkaQwSJbwvR5xmiVh8hEGY3uQ9bshi3itq9Bn14bYJ3eK/Vqxr31LJZmI XHnLX4UEpRzF2kg5UZ+2qpCKxYKSMDTvQNrgB6K1M3pyGikMEEjhYrgTmeplYKcWUq1r gVuAOt+2J8nVuagElYbqan6jYkVfiET4iq4/eSzJ+2SMPT4qyOkUEd+B1ZjZletBdTVh 0JyC1JVcMCvzgGjauzu97YW0/TJdCJ2uKVN7ZuVXjf1vRczUoM2148CN0cYUoizQl6/U hBmw== X-Gm-Message-State: AO0yUKX/NKhLij9+oWn6DSI8wpDICkKbeF5cJRulU5XZrwXfOfzpyqDs 9A1e+C48xsx3Qdtz2fYyTrebqQ== X-Google-Smtp-Source: AK7set+KavFTi/5gL3fFGZNK4zqO5JayQgZGCYyegKnxMgWSDSLPf/Gpn9hgDWKSYK0FTrdYRdNBLA== X-Received: by 2002:a17:906:2756:b0:931:d350:9aef with SMTP id a22-20020a170906275600b00931d3509aefmr2159037ejd.25.1679386456630; Tue, 21 Mar 2023 01:14:16 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:2142:d8da:5ae4:d817? ([2a02:810d:15c0:828:2142:d8da:5ae4:d817]) by smtp.gmail.com with ESMTPSA id m20-20020a170906259400b0092b8c1f41ebsm5411140ejb.24.2023.03.21.01.14.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Mar 2023 01:14:16 -0700 (PDT) Message-ID: Date: Tue, 21 Mar 2023 09:14:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/3] dt-bindings: wireless: add ath11k pcie bindings Content-Language: en-US To: Johan Hovold , Kalle Valo , Bjorn Andersson Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230320104658.22186-1-johan+linaro@kernel.org> <20230320104658.22186-2-johan+linaro@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20230320104658.22186-2-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/03/2023 11:46, Johan Hovold wrote: > Add devicetree bindings for Qualcomm ath11k PCIe devices such as WCN6856 > for which the calibration data variant may need to be described. > > Signed-off-by: Johan Hovold > --- > .../bindings/net/wireless/pci17cb,1103.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml > > diff --git a/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml b/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml > new file mode 100644 > index 000000000000..df67013822c6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml PCI devices are kind of exception in the naming, so this should be qcom,ath11k-pci.yaml or qcom,wcn6856.yaml (or something similar) > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2023 Linaro Limited > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/wireless/pci17cb,1103.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies ath11k wireless devices (PCIe) > + > +maintainers: > + - Kalle Valo > + > +description: | > + Qualcomm Technologies IEEE 802.11ax PCIe devices. > + > +properties: > + compatible: > + enum: > + - pci17cb,1103 # WCN6856 > + > + reg: > + maxItems: 1 > + > + qcom,ath11k-calibration-variant: qcom,calibration-variant > + $ref: /schemas/types.yaml#/definitions/string > + description: calibration data variant Your description copies the name of property. Instead say something more... > + Best regards, Krzysztof