MIME-Version: 1.0
References: <20230319142320.1704336-1-trix@redhat.com>
In-Reply-To: <20230319142320.1704336-1-trix@redhat.com>
From:   Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Date:   Tue, 21 Mar 2023 09:20:36 +0100
Message-ID: <CAMeQTsZmJP-RCXfMcLntLx-M=-O=D=hAvu5kNVJWwUzG3Emm=g@mail.gmail.com>
Subject: Re: [PATCH] drm/gma500: remove unused gma_pipe_event function
To:     Tom Rix <trix@redhat.com>
Cc:     airlied@gmail.com, daniel@ffwll.ch, nathan@kernel.org,
        ndesaulniers@google.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Mar 19, 2023 at 3:23=E2=80=AFPM Tom Rix <trix@redhat.com> wrote:
>
> clang with W=3D1 reports
> drivers/gpu/drm/gma500/psb_irq.c:35:19: error: unused function
>   'gma_pipe_event' [-Werror,-Wunused-function]
> static inline u32 gma_pipe_event(int pipe)
>                   ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>

Applied to drm-misc-next

Thanks
Patrik

> ---
>  drivers/gpu/drm/gma500/psb_irq.c | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/ps=
b_irq.c
> index d421031462df..343c51250207 100644
> --- a/drivers/gpu/drm/gma500/psb_irq.c
> +++ b/drivers/gpu/drm/gma500/psb_irq.c
> @@ -32,17 +32,6 @@ static inline u32 gma_pipestat(int pipe)
>         BUG();
>  }
>
> -static inline u32 gma_pipe_event(int pipe)
> -{
> -       if (pipe =3D=3D 0)
> -               return _PSB_PIPEA_EVENT_FLAG;
> -       if (pipe =3D=3D 1)
> -               return _MDFLD_PIPEB_EVENT_FLAG;
> -       if (pipe =3D=3D 2)
> -               return _MDFLD_PIPEC_EVENT_FLAG;
> -       BUG();
> -}
> -
>  static inline u32 gma_pipeconf(int pipe)
>  {
>         if (pipe =3D=3D 0)
> --
> 2.27.0
>