Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3862C74A5B for ; Tue, 21 Mar 2023 08:22:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230523AbjCUIWl (ORCPT ); Tue, 21 Mar 2023 04:22:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231206AbjCUIWR (ORCPT ); Tue, 21 Mar 2023 04:22:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F9EC311D1; Tue, 21 Mar 2023 01:22:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0478361A24; Tue, 21 Mar 2023 08:22:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9680C433EF; Tue, 21 Mar 2023 08:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679386931; bh=qmL5btKZB/IZvUgdpQ2K3dkSP/h1TPOeFV45YDB0j48=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iDH45JkBdnLdoWiKQ0q1CDsjmo2Siaxp3tbsD99aFYKfI0fR/+LZfvb+DYcZFHNqG QRGW6YTroRRsfjw5lD6xNtWKcmtXDa/xNiaH4ZVOwEEub17SIIlG9P02WZxbEkIHRY TfoeBeJZHyUHZedvNcORUvWs4lErCj7W9LkkxGPpXCBEh0PtdOMLaR6t8TYAKYleOY 6KRFp0Q3vk2S9fjrBTRNIxibz6v7bsq4TZF/HYRULcMyhvAk6v6dEnp/4CtzUVgd4Z 9STXDiBFQBYK+W4RACElN+sVwFwEZnesUvKto3u9xFFhvRwaXkOCn89MXxeqFSB4td cCNwYFNMvF27g== Date: Tue, 21 Mar 2023 10:22:06 +0200 From: Leon Romanovsky To: Wolfram Sang Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven , Sergey Shtylyov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] sh_eth: remove open coded netif_running() Message-ID: <20230321082206.GS36557@unreal> References: <20230321065826.2044-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230321065826.2044-1-wsa+renesas@sang-engineering.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2023 at 07:58:26AM +0100, Wolfram Sang wrote: > It had a purpose back in the days, but today we have a handy helper. > > Reported-by: Geert Uytterhoeven > Signed-off-by: Wolfram Sang > --- > > Based on 6.3-rc3 and tested on a Renesas Lager board (R-Car H2). > > drivers/net/ethernet/renesas/sh_eth.c | 6 +----- > drivers/net/ethernet/renesas/sh_eth.h | 1 - > 2 files changed, 1 insertion(+), 6 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky