Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-221-gec32977366-fm-20230306.001-gec329773
Mime-Version: 1.0
Message-Id: <86431868-488b-4a72-944b-231b6d0382b0@app.fastmail.com>
In-Reply-To: <20230312131318.351173-20-krzysztof.kozlowski@linaro.org>
References: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org>
 <20230312131318.351173-20-krzysztof.kozlowski@linaro.org>
Date:   Tue, 21 Mar 2023 09:11:36 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
        "Joe Tessler" <jrt@google.com>,
        "Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
        "Mauro Carvalho Chehab" <mchehab@kernel.org>,
        "Neil Armstrong" <neil.armstrong@linaro.org>,
        "Kevin Hilman" <khilman@baylibre.com>,
        "Jerome Brunet" <jbrunet@baylibre.com>,
        "Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
        "Thierry Reding" <thierry.reding@gmail.com>,
        "Jon Hunter" <jonathanh@nvidia.com>,
        "Manivannan Sadhasivam" <mani@kernel.org>,
        "Michael Tretter" <m.tretter@pengutronix.de>,
        "Pengutronix Kernel Team" <kernel@pengutronix.de>,
        "Jacopo Mondi" <jacopo+renesas@jmondi.org>,
        "Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
        "Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
        =?UTF-8?Q?Niklas_S=C3=B6derlund?= 
        <niklas.soderlund+renesas@ragnatech.se>,
        "Rui Miguel Silva" <rmfrfs@gmail.com>,
        "Wenyou Yang" <wenyou.yang@microchip.com>,
        "Bin Liu" <bin.liu@mediatek.com>,
        "Matthias Brugger" <matthias.bgg@gmail.com>,
        "AngeloGioacchino Del Regno" 
        <angelogioacchino.delregno@collabora.com>,
        "Minghsiu Tsai" <minghsiu.tsai@mediatek.com>,
        "Houlong Wei" <houlong.wei@mediatek.com>,
        "Andrew-CT Chen" <andrew-ct.chen@mediatek.com>,
        "Andrzej Pietrasiewicz" <andrzejtp2010@gmail.com>,
        "Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
        "Sylwester Nawrocki" <s.nawrocki@samsung.com>,
        "Patrice Chotard" <patrice.chotard@foss.st.com>,
        "Yong Deng" <yong.deng@magewell.com>,
        "Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
        "Chen-Yu Tsai" <wens@csie.org>,
        "Jernej Skrabec" <jernej.skrabec@gmail.com>,
        "Samuel Holland" <samuel@sholland.org>,
        Prabhakar <prabhakar.csengg@gmail.com>,
        "Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>,
        "Philipp Zabel" <p.zabel@pengutronix.de>,
        "Sean Young" <sean@mess.org>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org,
        linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-rockchip@lists.infradead.org,
        oushixiong <oushixiong@kylinos.cn>
Subject: Re: [PATCH 20/28] media: platform: jpeg: always reference OF data
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Mar 12, 2023, at 14:13, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be alwa=
ys
> used and the of_match_ptr does not have any sense (this also allows AC=
PI
> matching via PRP0001, even though it might not be relevant here).  This
> also fixes !CONFIG_OF error:
>
>   drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:1890:38: error:=20
> =E2=80=98mtk8195_jpegdec_drvdata=E2=80=99 defined but not used=20
> [-Werror=3Dunused-const-variable=3D]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

I see now that we both submitted the same patch, but now Hans
merged a worse fix [1] without a changelog text.

    Arnd

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/comm=
it/?h=3D4ae47770d57bff01