Date:   Tue, 21 Mar 2023 09:49:26 +0100
From:   Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To:     Jes Sorensen <jes@trained-monkey.org>
Cc:     NeilBrown <neilb@suse.de>, Song Liu <song@kernel.org>,
        Linux regressions mailing list <regressions@lists.linux.dev>,
        linux-raid <linux-raid@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Nikolay Kichukov <hijacker@oldum.net>
Subject: Re: [PATCH - mdadm] mdopen: always try create_named_array()
Message-ID: <20230321094926.00007a38@linux.intel.com>
In-Reply-To: <c36ee145-c258-5a02-f268-30c145996759@trained-monkey.org>
References: <167875238571.8008.9808655454439667586@noble.neil.brown.name>
        <318ff554-0694-64e1-72bd-d941a775a16f@trained-monkey.org>
        <167926378352.8008.3450187952660050637@noble.neil.brown.name>
        <c36ee145-c258-5a02-f268-30c145996759@trained-monkey.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 20 Mar 2023 13:15:35 -0400
Jes Sorensen <jes@trained-monkey.org> wrote:

> On 3/19/23 18:09, NeilBrown wrote:
> > On Mon, 20 Mar 2023, Jes Sorensen wrote:  
> >> On 3/13/23 20:06, NeilBrown wrote:  
> >>>
> >>> mdopen() will use create_named_array() to ask the kernel to create the
> >>> given md array, but only if it is given a number or name.
> >>> If it is NOT given a name and is required to choose one itself using
> >>> find_free_devnm() it does NOT use create_named_array().
> >>>
> >>> On kernels with CONFIG_BLOCK_LEGACY_AUTOLOAD not set, this can result in
> >>> failure to assemble an array.  This can particularly seen when the
> >>> "name" of the array begins with a host name different to the name of the
> >>> host running the command.
> >>>
> >>> So add the missing call to create_named_array().
> >>>
> >>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217074
> >>> Signed-off-by: NeilBrown <neilb@suse.de>  
> >>
> >> Applied!  
> > 
> > Thanks.
> > 
> > Do you have plans for releasing 4.3?  I'd like this patch to be in a
> > numbered release for at least a few months before we change the kernel
> > Kconfig to allow md to be built without CONFIG_BLOCK_LEGACY_AUTOLOAD.  
> 
> No immediate plans, but no reason why we shouldn't do it. I think
> Mariusz has some pending changes he wants to get in as well, like the
> error number stuff.
> 
> So lets make this a call for submitting changes for mdadm that are
> needed for the next release.
> 

Hi Jes,
My patches around names (where I added those errors) will be too risky to be
merged and released in short period. I'm going to limit the supported
characters for names- it could bring regressions in some non obvious cases and I
would like to give user time to accept it and adopt their solutions to new
naming policy.

Let me see if the patches recently merged doesn't bring any critical
regression, and we are free to go I think :) I will back with a results soon.

Thanks,
Mariusz