Date:   Tue, 21 Mar 2023 09:28:13 +0000
From:   Mark Rutland <mark.rutland@arm.com>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Tom Rix <trix@redhat.com>, mhiramat@kernel.org,
        linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] ftrace: set direct_ops storage-class-specifier to static
Message-ID: <ZBl4rZz/fULw+sWp@FVFF77S0Q05N>
References: <20230311135113.711824-1-trix@redhat.com>
 <ZBibbUQlkytYsoN9@FVFF77S0Q05N.cambridge.arm.com>
 <20230320135132.26b29f36@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230320135132.26b29f36@gandalf.local.home>
Precedence: bulk

On Mon, Mar 20, 2023 at 01:51:32PM -0400, Steven Rostedt wrote:
> On Mon, 20 Mar 2023 17:44:13 +0000
> Mark Rutland <mark.rutland@arm.com> wrote:
> > On Sat, Mar 11, 2023 at 08:51:13AM -0500, Tom Rix wrote:
> > > smatch reports this warning
> > > kernel/trace/ftrace.c:2594:19: warning:
> > >   symbol 'direct_ops' was not declared. Should it be static?
> > > 
> > > The variable direct_ops is only used in ftrace.c, so it should be static
> > > 
> > > Signed-off-by: Tom Rix <trix@redhat.com>  
> > 
> > This makes sense, and as this stands:
> > 
> > Acked-by: Mark Rutland <mark.rutland@arm.com>
> > 
> > ... but Florent's rework of the API is going to remove this anyway:
> > 
> >   https://lore.kernel.org/all/20230316173811.1223508-1-revest@chromium.org/
> >   https://lore.kernel.org/all/20230316173811.1223508-4-revest@chromium.org/
> > 
> > ... so if we take Florent's series, this patch isn't necessary.
> 
> Except that it's already upstream:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8732565549011cabbea08329a1aefd78a68d96c7
> 
> I had to rebase Florent's patch to accommodate this change.

Sorry for the noise; my fault for being so far behind with patch review!

Mark.