Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-221-gec32977366-fm-20230306.001-gec329773
Mime-Version: 1.0
Message-Id: <59c05b36-3370-4d7b-b8cc-39d6dc36cdd0@app.fastmail.com>
In-Reply-To: <CAFr9PXmKsequA3V7QWC2fKQYZgaNRj+q3q=UOBLmg6wxYKiVYg@mail.gmail.com>
References: <20230321033810.22017-1-lukas.bulwahn@gmail.com>
 <CAFr9PXmKsequA3V7QWC2fKQYZgaNRj+q3q=UOBLmg6wxYKiVYg@mail.gmail.com>
Date:   Tue, 21 Mar 2023 10:30:21 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Daniel Palmer" <daniel@thingy.jp>,
        "Lukas Bulwahn" <lukas.bulwahn@gmail.com>
Cc:     "Romain Perier" <romain.perier@gmail.com>,
        "Russell King" <linux@armlinux.org.uk>, soc@kernel.org,
        linux-arm-kernel@lists.infradead.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: mstar: remove unused config MACH_MERCURY
Content-Type: text/plain
Precedence: bulk

On Tue, Mar 21, 2023, at 09:33, Daniel Palmer wrote:
> Hi Lukas
>
> On Tue, 21 Mar 2023 at 12:38, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>>
>> Commit 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7
>> SoCs") adds the config MACH_INFINITY and MACH_MERCURY. The MACH_INFINITY
>> config is used in the gpio-msc313 driver, but the MACH_MERCURY config is
>> never used to configure anything in the kernel tree.
>>
>> Remove the unused config MACH_MERCURY.
>
> Because work is still on going to push that stuff.
>
> nak from me.

The symbol has been unused three year though, and will
show up every time someone runs a script to look for
orphaned Kconfig entries.

I'd still prefer removing it now and only bringing it
back when you actually add the code for it.

     Arnd