From:   "Sit, Michael Wei Hong" <michael.wei.hong.sit@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Looi, Hong Aun" <hong.aun.looi@intel.com>,
        "Voon, Weifeng" <weifeng.voon@intel.com>,
        "Lai, Peter Jun Ann" <peter.jun.ann.lai@intel.com>
Subject: RE: [PATCH net v2 2/2] net: stmmac: move fixed-link support fixup
 code
Thread-Topic: [PATCH net v2 2/2] net: stmmac: move fixed-link support fixup
 code
Thread-Index: AQHZWQtu+ICkP7bLzEy6mFAy7d+uRK8E7slg
Date:   Tue, 21 Mar 2023 10:17:46 +0000
Message-ID: <PH0PR11MB75877482FC5A666FC795F0179D819@PH0PR11MB7587.namprd11.prod.outlook.com>
References: <20230314070208.3703963-1-michael.wei.hong.sit@intel.com>
 <20230314070208.3703963-3-michael.wei.hong.sit@intel.com>
 <166f45dc-c27e-41fd-aa82-bad696f32184@lunn.ch>
In-Reply-To: <166f45dc-c27e-41fd-aa82-bad696f32184@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/8uvKwrHOJMF+aqBMxr93Xb3DdAsPGPBmZeIO3MHa9HGBcGQblK1qZ5bUUau?=
 =?us-ascii?Q?7EvEjz3dNURFCcuUaiMLeW9GggOn4U8EblPaGMcOmDgtxynl7etmitHNYjcx?=
 =?us-ascii?Q?chTKWXNv4BTgOROFYdu6kRXOxwSplu2q+hI/5a1NLZiH/bILZlXP+WkrbzAU?=
 =?us-ascii?Q?i7n+2LCBuCyEjCpjnCjFT9DIM5Ii9wehfORjebLKHG/yOFd66MEBYg83mj3w?=
 =?us-ascii?Q?KfffPdsYZEq5x45USINZVO16EvmOaIRdG8w87MT0ibCmIgsxxR0L3u1cFXEB?=
 =?us-ascii?Q?KFDJYTMjUhrpVqm9dj1rI1W1OwY+4fLgwzVJwQ7is+mF8NYKvenZYFgt4c3I?=
 =?us-ascii?Q?SRjcaIczMaQhLEywImZSMbBk++RK0H34zYzPfHOx8zL+MlJQSWIHKGTcCjIE?=
 =?us-ascii?Q?Un0A/cvuxrmL9skrpnjtWAKcgBg2fXaFL+PPcGKhvbdhB+fVhnkR482Pi5GC?=
 =?us-ascii?Q?59Gv1zHEPvHzskhzw772YVUhsC52kU7s53rfFETDoXTxj6DawW78Y+qHWdam?=
 =?us-ascii?Q?6a981w3s36RUJpKZ0u1bf9dtNLngWggMpNKUvFzBvqIsBuGnb1OsZcWim685?=
 =?us-ascii?Q?A6q0kR+RBA5Z5DJUU8ERXgf1xbJim+H5wvvZCBE27xWhnTeQeAId5fiU3hXM?=
 =?us-ascii?Q?aiox0BQo35cV+61I+0eF6vI1F1T2AOAIna/mKAKMDLdEZ8Gjhq67OO8kSq3r?=
 =?us-ascii?Q?ZSvZIJxkgtBiGKWQ+qaJTuTQ6SYzwboNX6VjqGF4aaWgCC1R4EOcle1cq7+F?=
 =?us-ascii?Q?abneuHA6ISBfjXm7kZtIWzV0Lp+EFehpYxcgm2IXJR1c+O+Zfbgn57ZRcBwd?=
 =?us-ascii?Q?SLlNs2Bm1mJfUcAypjZ3eM0Jn3xukIqztx7D/Th+v1uxm8KGVnnRW5rT4LN8?=
 =?us-ascii?Q?mYITGnbxxMSICXMqBs6W3011INXWlr1nS+YTOiOnrwRVd2lNXyd/6uKQDoPV?=
 =?us-ascii?Q?BGlbslQv2TUbVeRq1hy07nvzFvsGZOujJs80nZog5miT5CWEO0pqDv5w9jIJ?=
 =?us-ascii?Q?mh8PgsgtyeerrJp49uoJe2TRg3UijWQoZIS1ggJVOB3OU0cPDiZF5Xk5o9jO?=
 =?us-ascii?Q?6f1HGyfR510dY6IGRX4Gefw1EJBK6RAMjYKbbBPAmLZ28Ink46plPuquhdi7?=
 =?us-ascii?Q?aNd3t/cXJElpEkjMd+Nj01dDsfAKH1EFi8d2ltNSkk25ggH4ecsLeUH8NdHQ?=
 =?us-ascii?Q?6Om4el9KmVD8pX0x/zHeuU7/JvJLVi7HqrnDFgfc20G5pQ4zrtPus1X+zdH/?=
 =?us-ascii?Q?sbJ50ZMFRfPcQ37BDMdOMPyGxrFj//EHuAC0DRqfuDL8nXrORDlBHgUKdYla?=
 =?us-ascii?Q?jRR+/MWbtNMpkM71LUFGhH2DPqhtVz73oDr8055yM+L3xAK07pF+oA13Zhl6?=
 =?us-ascii?Q?5ujpofhwcTlQan9dZ/2U3H12HTq8GtlsWaagDuMNJ2kAdZVjFVnr0ZkVSUNt?=
 =?us-ascii?Q?p81eXwZ11v3gRbd3pxdRNYE4xrAH7/FdxQwbxrlR/Y6D43IZ89kUTs1VhyrA?=
 =?us-ascii?Q?MMVk+U3mVPtrsxNNfMP7yehT5sRGVv7KtDMMV9S3cBmMT8XQH+dSQsZp5HYV?=
 =?us-ascii?Q?/ErUalPOkscRVdZ85vH4LdrZNzVgevTWMeW4NLG2bx5oTcoJLwEEYBm/T50C?=
 =?us-ascii?Q?Fg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7587.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c785fc6-4d8b-4015-92c9-08db29f58471
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2023 10:17:46.8662
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QEhBIzgxa7K0ij8zDNMWzMT9xe1hZaCoTHgcfpXgmr3lF2Suo3pTSMw21cjgHAMLfWNMNHwnB6MIzulRHhC9kiTQucSJM0smbkJlGC4kw8w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5259
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Saturday, March 18, 2023 4:03 AM
> To: Sit, Michael Wei Hong <michael.wei.hong.sit@intel.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre
> Torgue <alexandre.torgue@foss.st.com>; Jose Abreu
> <joabreu@synopsys.com>; David S . Miller
> <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; Maxime Coquelin
> <mcoquelin.stm32@gmail.com>; Ong, Boon Leong
> <boon.leong.ong@intel.com>; netdev@vger.kernel.org; linux-
> stm32@st-md-mailman.stormreply.com; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Looi,
> Hong Aun <hong.aun.looi@intel.com>; Voon, Weifeng
> <weifeng.voon@intel.com>; Lai, Peter Jun Ann
> <peter.jun.ann.lai@intel.com>
> Subject: Re: [PATCH net v2 2/2] net: stmmac: move fixed-link
> support fixup code
>=20
> On Tue, Mar 14, 2023 at 03:02:08PM +0800, Michael Sit Wei Hong
> wrote:
> > xpcs_an_inband value is updated in the speed_mode_2500
> function which
> > turns on the xpcs_an_inband mode.
> >
> > Moving the fixed-link fixup code to right before phylink setup
> to
> > ensure no more fixup will affect the fixed-link mode
> configurations.
>=20
> Please could you explain why this is correct, when you could
> simple not set priv->plat->mdio_bus_data->xpcs_an_inband =3D
> true; in intel_speed_mode_2500()?
>=20
> This all seems like hacks, rather than a clean design.
>=20
>      Andrew
Makes sense, will test out with your suggestion and submit
the changes in next version, will feedback if there is any
findings.