Message-ID: <2aeb47d6-0577-f8e4-6070-331af15b1f83@linaro.org>
Date:   Tue, 21 Mar 2023 11:32:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: Add TI TPS6594 PMIC
Content-Language: en-US
To:     Julien Panis <jpanis@baylibre.com>, Rob Herring <robh@kernel.org>
Cc:     lee@kernel.org, krzysztof.kozlowski+dt@linaro.org, corbet@lwn.net,
        arnd@arndb.de, gregkh@linuxfoundation.org,
        derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com,
        eric.auger@redhat.com, jgg@ziepe.ca, razor@blackwall.org,
        stephen@networkplumber.org, davem@davemloft.net,
        christian.koenig@amd.com, contact@emersion.fr,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, sterzik@ti.com, u-kumar1@ti.com,
        eblanc@baylibre.com, jneanne@baylibre.com
References: <20230315110736.35506-1-jpanis@baylibre.com>
 <20230315110736.35506-2-jpanis@baylibre.com>
 <20230320155354.GB1733616-robh@kernel.org>
 <04914464-2bc2-9d86-e9e2-8a716b929f28@baylibre.com>
 <2dcfd9dc-6c43-20b7-e27b-8ec2883be237@linaro.org>
 <887d5e71-334c-b206-08e6-2cc822df9eda@baylibre.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <887d5e71-334c-b206-08e6-2cc822df9eda@baylibre.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/03/2023 10:03, Julien Panis wrote:
> 
> 
> On 3/21/23 08:36, Krzysztof Kozlowski wrote:
>> On 20/03/2023 17:35, Julien Panis wrote:
>>>
>>> On 3/20/23 16:53, Rob Herring wrote:
>>>> On Wed, Mar 15, 2023 at 12:07:33PM +0100, Julien Panis wrote:
>>>>> TPS6594 is a Power Management IC which provides regulators and others
>>>>> features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
>>>>> PFSM (Pre-configurable Finite State Machine) managing the state of the
>>>>> device.
>>>>> TPS6594 is the super-set device while TPS6593 and LP8764X are derivatives.
>>>> As mentioned, the binding needs to be complete. It's missing GPIO at
>>>> least. RTC and watchdog may or may not need binding changes.
>>> Thank you for your feedback.
>>>
>>> About GPIO, do you speak about 'gpio-controller'
>>> and/or '#gpio-cells' properties ?
>> Yes.
>>
>>> For RTC (and for watchdog, once the driver will be
>>> implemented), our driver do not require any node
>>> to work. What could make an explicit instantiation
>>> necessary in DT ?
>> Properties from RTC schema, e.g. start-year, wakeup etc.
> 
> TPS6594 RTC driver is being reviewed (this is another patch
> series, not merged yet). These properties are not used by our
> driver, that's why we did not have to add some RTC node in
> the DT (until now, using such properties in our driver was not
> requested by RTC sub-system maintainers).

Bindings should be complete, regardless whether you now need this in
driver or not. Does your comment mean that you will never need these,
because hardware does not support them, and never going to add?
Otherwise I don't get why you refer to driver when we talk about bindings...


Best regards,
Krzysztof