Date:   Tue, 21 Mar 2023 14:23:26 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To:     Varadarajan Narayanan <quic_varada@quicinc.com>, agross@kernel.org,
        andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org,
        kishon@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org,
        mturquette@baylibre.com, sboyd@kernel.org, quic_wcheng@quicinc.com,
        linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 7/8] arm64: dts: qcom: ipq9574: Add USB related nodes
User-Agent: K-9 Mail for Android
In-Reply-To: <644b4b0f17f72e109445a7b31f3e0d2e75dcc361.1679388632.git.quic_varada@quicinc.com>
References: <cover.1677749625.git.quic_varada@quicinc.com> <cover.1679388632.git.quic_varada@quicinc.com> <644b4b0f17f72e109445a7b31f3e0d2e75dcc361.1679388632.git.quic_varada@quicinc.com>
Message-ID: <122A5E4F-2794-43AE-8DAC-CC2D51279AC6@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 21 March 2023 11:54:25 GMT+03:00, Varadarajan Narayanan <quic_varada@qu=
icinc=2Ecom> wrote:
>Add USB phy and controller related nodes
>
>Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc=2Ecom>
>
>---
> Changes in v2:
>	- Fixed issues flagged by Krzysztof
>	- Fix issues reported by make dtbs_check
>	- Remove NOC related clocks (to be added with proper
>	  interconnect support)
>---
> arch/arm64/boot/dts/qcom/ipq9574=2Edtsi | 86 +++++++++++++++++++++++++++=
++++++++
> 1 file changed, 86 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/qcom/ipq9574=2Edtsi b/arch/arm64/boot/dt=
s/qcom/ipq9574=2Edtsi
>index 2bb4053=2E=2E513da74 100644
>--- a/arch/arm64/boot/dts/qcom/ipq9574=2Edtsi
>+++ b/arch/arm64/boot/dts/qcom/ipq9574=2Edtsi
>@@ -829,6 +829,92 @@
> 			msi-parent =3D <&v2m0>;
> 			status =3D "disabled";
> 		};

The last device node is pci@28000000=2E Thus you are trying to add all usb=
 nodes at the wrong place=2E Please move them so that all nodes are still s=
orted by the address part=2E


>+
>+		qusb_phy_0: phy@7b000 {
>+			compatible =3D "qcom,ipq9574-qusb2-phy";
>+			reg =3D <0x07b000 0x180>;
>+			#phy-cells =3D <0>;
>+
>+			clocks =3D <&gcc GCC_USB0_PHY_CFG_AHB_CLK>,
>+				<&xo_board_clk>;
>+			clock-names =3D "cfg_ahb", "ref";
>+
>+			resets =3D <&gcc GCC_QUSB2_0_PHY_BCR>;
>+			status =3D "disabled";
>+		};
>+
>+		ssphy_0: phy@7d000 {
>+			compatible =3D "qcom,ipq9574-qmp-usb3-phy";
>+			reg =3D <0x7d000 0x1c4>;
>+			#clock-cells =3D <1>;
>+			#address-cells =3D <1>;
>+			#size-cells =3D <1>;
>+			ranges;
>+
>+			clocks =3D <&gcc GCC_USB0_AUX_CLK>,
>+				 <&gcc GCC_USB0_PHY_CFG_AHB_CLK>;
>+			clock-names =3D "aux", "cfg_ahb";
>+
>+			resets =3D  <&gcc GCC_USB0_PHY_BCR>,
>+				 <&gcc GCC_USB3PHY_0_PHY_BCR>;
>+			reset-names =3D "phy","common";
>+			status =3D "disabled";
>+
>+			usb0_ssphy: phy@7d200 {
>+				reg =3D <0x0007d200 0x130>,	/* tx */
>+				      <0x0007d400 0x200>,	/* rx */
>+				      <0x0007d800 0x1f8>,	/* pcs  */
>+				      <0x0007d600 0x044>;	/* pcs misc */
>+				#phy-cells =3D <0>;
>+				clocks =3D <&gcc GCC_USB0_PIPE_CLK>;
>+				clock-names =3D "pipe0";
>+				clock-output-names =3D "usb0_pipe_clk";
>+			};
>+		};
>+
>+		usb3: usb3@8a00000 {
>+			compatible =3D "qcom,ipq9574-dwc3", "qcom,dwc3";
>+			reg =3D <0x8af8800 0x400>;
>+			#address-cells =3D <1>;
>+			#size-cells =3D <1>;
>+			ranges;
>+
>+			clocks =3D <&gcc GCC_SNOC_USB_CLK>,
>+				 <&gcc GCC_ANOC_USB_AXI_CLK>,
>+				 <&gcc GCC_USB0_MASTER_CLK>,
>+				 <&gcc GCC_USB0_SLEEP_CLK>,
>+				 <&gcc GCC_USB0_MOCK_UTMI_CLK>;
>+
>+			clock-names =3D "sys_noc_axi",
>+				      "anoc_axi",
>+				      "master",
>+				      "sleep",
>+				      "mock_utmi";
>+
>+			assigned-clocks =3D <&gcc GCC_USB0_MASTER_CLK>,
>+					  <&gcc GCC_USB0_MOCK_UTMI_CLK>;
>+			assigned-clock-rates =3D <200000000>,
>+					       <24000000>;
>+
>+			resets =3D <&gcc GCC_USB_BCR>;
>+			status =3D "disabled";
>+
>+			dwc_0: usb@8a00000 {
>+				compatible =3D "snps,dwc3";
>+				reg =3D <0x8a00000 0xcd00>;
>+				clocks =3D <&gcc GCC_USB0_MOCK_UTMI_CLK>;
>+				clock-names =3D "ref";
>+				interrupts =3D <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
>+				phys =3D <&qusb_phy_0>, <&usb0_ssphy>;
>+				phy-names =3D "usb2-phy", "usb3-phy";
>+				tx-fifo-resize;
>+				snps,is-utmi-l1-suspend;
>+				snps,hird-threshold =3D /bits/ 8 <0x0>;
>+				snps,dis_u2_susphy_quirk;
>+				snps,dis_u3_susphy_quirk;
>+				dr_mode =3D "host";
>+			};
>+		};
> 	};
>=20
> 	rpm-glink {

--=20
With best wishes
Dmitry