From:   Cornelia Huck <cohuck@redhat.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>,
        Viktor Prutyanov <viktor@daynix.com>
Cc:     Jason Wang <jasowang@redhat.com>, pasic@linux.ibm.com,
        farman@linux.ibm.com, linux-s390@vger.kernel.org,
        kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, yan@daynix.com
Subject: Re: [PATCH v2] virtio: add VIRTIO_F_NOTIFICATION_DATA feature support
In-Reply-To: <20230321050719-mutt-send-email-mst@kernel.org>
Organization: Red Hat GmbH
References: <20230320232115.1940587-1-viktor@daynix.com>
 <CACGkMEu5qa2KUHti3w59DcXNxBdh8_ogZ9oW9bo1_PHwbNiCBg@mail.gmail.com>
 <CAPv0NP5wTMG=3kT_FX4xi9kGbX0Dah4qTQfFQPutWYsWvK1i-g@mail.gmail.com>
 <20230321050719-mutt-send-email-mst@kernel.org>
User-Agent: Notmuch/0.37 (https://notmuchmail.org)
Date:   Tue, 21 Mar 2023 14:10:23 +0100
Message-ID: <87jzzamerk.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Mar 21 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Tue, Mar 21, 2023 at 12:00:42PM +0300, Viktor Prutyanov wrote:
>> On Tue, Mar 21, 2023 at 5:29=E2=80=AFAM Jason Wang <jasowang@redhat.com>=
 wrote:
>> >
>> > On Tue, Mar 21, 2023 at 7:21=E2=80=AFAM Viktor Prutyanov <viktor@dayni=
x.com> wrote:
>> > >
>> > > According to VirtIO spec v1.2, VIRTIO_F_NOTIFICATION_DATA feature
>> > > indicates that the driver passes extra data along with the queue
>> > > notifications.
>> > >
>> > > In a split queue case, the extra data is 16-bit available index. In a
>> > > packed queue case, the extra data is 1-bit wrap counter and 15-bit
>> > > available index.
>> > >
>> > > Add support for this feature for MMIO and PCI transports. Channel I/O
>> > > transport will not accept this feature.
>> > >
>> > > Signed-off-by: Viktor Prutyanov <viktor@daynix.com>
>> > > ---
>> > >
>> > >  v2: reject the feature in virtio_ccw, replace __le32 with u32
>> > >
>> > >  drivers/s390/virtio/virtio_ccw.c   |  4 +---
>> > >  drivers/virtio/virtio_mmio.c       | 15 ++++++++++++++-
>> > >  drivers/virtio/virtio_pci_common.c | 10 ++++++++++
>> > >  drivers/virtio/virtio_pci_common.h |  4 ++++
>> > >  drivers/virtio/virtio_pci_legacy.c |  2 +-
>> > >  drivers/virtio/virtio_pci_modern.c |  2 +-
>> > >  drivers/virtio/virtio_ring.c       | 17 +++++++++++++++++
>> > >  include/linux/virtio_ring.h        |  2 ++
>> > >  include/uapi/linux/virtio_config.h |  6 ++++++
>> > >  9 files changed, 56 insertions(+), 6 deletions(-)
>> > >
>> > > diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/=
virtio_ccw.c
>> > > index a10dbe632ef9..d72a59415527 100644
>> > > --- a/drivers/s390/virtio/virtio_ccw.c
>> > > +++ b/drivers/s390/virtio/virtio_ccw.c
>> > > @@ -789,9 +789,7 @@ static u64 virtio_ccw_get_features(struct virtio=
_device *vdev)
>> > >
>> > >  static void ccw_transport_features(struct virtio_device *vdev)
>> > >  {
>> > > -       /*
>> > > -        * Currently nothing to do here.
>> > > -        */
>> > > +       __virtio_clear_bit(vdev, VIRTIO_F_NOTIFICATION_DATA);
>> >
>> > Is there any restriction that prevents us from implementing
>> > VIRTIO_F_NOTIFICATION_DATA? (Spec seems doesn't limit us from this)
>>=20
>> Most likely, nothing.
>
> So pls code it up. It's the same format.

FWIW, the notification data needs to go via the third parameter of
kvm_hypercall3() in virtio_ccw_kvm_notify().