Message-ID: <a05cfc82-a9e9-ea96-aaca-612ff9c14219@gmail.com>
Date:   Tue, 21 Mar 2023 20:12:36 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] scripts/package: add back 'version' for builddeb
To:     David Wang <00107082@163.com>, linux-kernel@vger.kernel.org
Cc:     masahiroy@kernel.org
References: <20230320110819.23668-1-00107082@163.com>
Content-Language: en-US
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <20230320110819.23668-1-00107082@163.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/20/23 18:08, David Wang wrote:
> Fixes: 36862e14e316 (kbuild: deb-pkg: use dh_listpackages to know
> enabled packages)
> The 'version' variable is still needed for building
> debian 'linux-headers' packages, add it back.
> 
> Signed-off-by: David Wang <00107082@163.com>
> ---
>  scripts/package/builddeb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index c5ae57167d7c..5102d0903f9c 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -215,6 +215,7 @@ install_libc_headers () {
>  
>  rm -f debian/files
>  
> +version=$KERNELRELEASE
>  packages_enabled=$(dh_listpackages)
>  
>  for package in ${packages_enabled}

Hi,

Again, your patch looks like corrupted (tabs converted to spaces).
Please resubmit; this time; generate the patch via git-format-patch(1)
and then send the resulting patch with git-send-email(1).

Thanks.

-- 
An old man doll... just what I always wanted! - Clara