Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4119C7619A for ; Tue, 21 Mar 2023 14:33:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231243AbjCUOdN (ORCPT ); Tue, 21 Mar 2023 10:33:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230379AbjCUOdG (ORCPT ); Tue, 21 Mar 2023 10:33:06 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF2F728E9E for ; Tue, 21 Mar 2023 07:33:04 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id c19so18027899qtn.13 for ; Tue, 21 Mar 2023 07:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1679409184; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PE0Q2urSrQgTvUZSFNMrQiYswRteUmKjVjKK7YyvjOs=; b=pS1b6B4vl3/brpituXp0/WjTu4YeJGOtWmjmcBMPwY0q1e5UURFy0dHxKB2x6scs33 f7DZjyOjGFO4+xLcU/TWBMw8DgUSp3E+PSI8V4sm0UJgXlIkrtn8aJR60PiuSo8s1PeI lRWYRjw4JD3xGeDnuKmpl/Cu/o2dIBQvvfZzl1M/j6jTVdyrYP0if6ou0Twdt2CpEvvK Xo20K1JEGf88s6ynPckpcIL/FAbdgIo239hBDnVXOqebJ+uT2W60hkdTDPzf+NX6jDUK 2jxuok02LCb6kHGQ59iukpmOtG+9obX6tikY93CyL0AiQtaIstGdS5F4PiQ/e2nIRnC4 UcHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679409184; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PE0Q2urSrQgTvUZSFNMrQiYswRteUmKjVjKK7YyvjOs=; b=CuW+c9464U0j3VdYJZIOi0oMPbVzf2FH5GOGoiO3bALp8Fc0sQHYXrIfA4w67c7jEA e5krlmDYmPqb4zNHVk9nTJixYd7VK2KiMviTv/r4vkA5UKP25+19O3nPIYOe8dN1HSne zXKK/Dl3nZZLs9F/HS+P5PQnlG5E0xPDoXBC0H3Y14fYVumzOfrN6+aYi4Rs+wYhy3K3 c+Ya5qi/X7IfBEvltkdLthA3rk2GAmTdDS4SbQaZ1PVTqyDnEYkTh3OGGvyFveu1wkiH 2mYHWjzZX3qNmTADF31CaN9PuDfgY5Ee51ii/37Q2j7ZdcLP8KMAAaHi4infy7cQS0t1 Z7hQ== X-Gm-Message-State: AO0yUKU1B5jvzXQTF1EfmTm8ieOOUfM0ZsmSOhOSGmtl7LJAqjV06zfF maWXWox4SmtWDOr+uojJXER8Pw== X-Google-Smtp-Source: AK7set9R/JiYTa+wywUxBgEMSGSbgZkcQlBT/C6J1sAycNW5wTVKmIe6cUHx5pgx1Hsf4sp+7n0u1A== X-Received: by 2002:a05:622a:20e:b0:3bf:d7f8:4f85 with SMTP id b14-20020a05622a020e00b003bfd7f84f85mr161977qtx.12.1679409183856; Tue, 21 Mar 2023 07:33:03 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-25-194.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.25.194]) by smtp.gmail.com with ESMTPSA id i18-20020ac84f52000000b003d621964626sm8484287qtw.8.2023.03.21.07.33.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 07:33:03 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1ped2s-000VQL-PI; Tue, 21 Mar 2023 11:33:02 -0300 Date: Tue, 21 Mar 2023 11:33:02 -0300 From: Jason Gunthorpe To: Niklas Schnelle Cc: Arnd Bergmann , Greg Kroah-Hartman , Corey Minyard , Peter Huewe , Jarkko Sakkinen , Bjorn Helgaas , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org Subject: Re: [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT Message-ID: References: <20230314121216.413434-1-schnelle@linux.ibm.com> <20230314121216.413434-4-schnelle@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314121216.413434-4-schnelle@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 14, 2023 at 01:11:41PM +0100, Niklas Schnelle wrote: > diff --git a/drivers/char/tpm/tpm_infineon.c b/drivers/char/tpm/tpm_infineon.c > index 9c924a1440a9..2d2ae37153ba 100644 > --- a/drivers/char/tpm/tpm_infineon.c > +++ b/drivers/char/tpm/tpm_infineon.c > @@ -51,34 +51,40 @@ static struct tpm_inf_dev tpm_dev; > > static inline void tpm_data_out(unsigned char data, unsigned char offset) > { > +#ifdef CONFIG_HAS_IOPORT > if (tpm_dev.iotype == TPM_INF_IO_PORT) > outb(data, tpm_dev.data_regs + offset); You should ifdef away TPM_INF_IO_PORT as well Jason