Message-ID: <befeec9c-60ee-f13e-8bd1-9dd28c56811d@amd.com>
Date:   Tue, 21 Mar 2023 15:43:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH -next] i2c: xiic: Use
 devm_platform_get_and_ioremap_resource()
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>, michal.simek@xilinx.com
Cc:     linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230316054325.108457-1-yang.lee@linux.alibaba.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230316054325.108457-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEk5bytXRnkrQUwxdFdOalNQeW0weWJaekZWdHJvTEROVWR6K3RWY0dhcDBD?=
 =?utf-8?B?ZlBZOU1EcXFsejVmclV4bzZjWlRHeGpDeStwSHN3SGh5QnIvdzA1b2N4WGNO?=
 =?utf-8?B?eXdKOE5FVXNXdGVhODUyZStSNm4yL3FqRWJpYTRnNERsVS83a0pKMWswTHNT?=
 =?utf-8?B?ZUdoVEZNMDZCSGdmcGljRU41QjYwOVpVU2hkOVIxMDNuTXczcUNoNFFJVE1t?=
 =?utf-8?B?SWZUbnJyRVFwRFdBNWtSTEQyZkRuM1dnMGZpbjROWmtkOXBHTWsybFdMVWhU?=
 =?utf-8?B?cWhBYk1hWm1DdXd3a2N3d3lxRVRIT1l6TWM2YUIrYTRrc0liSzhxRWI5Zk5O?=
 =?utf-8?B?aG9raWJIVjJXbGJrWmtQQWZBREM3M3BPV0psWFhwZlJCdzNEUUduRG9rRVI5?=
 =?utf-8?B?Tm1oc0pzeGROYm90OTZ2N3FKbmFtYXZKWmVCODB5MFp1ZUlwVjdxZk1hUkJV?=
 =?utf-8?B?SXorWmZ4OWxWR05pem9adVJnbVROOGc1NnNDMVJFK01LQzhQeUp6MjhpNFBG?=
 =?utf-8?B?YVZoYU5sZkJsMEF0SkVaWmwvZnVUSXg2MHNhT1NVN3gxOGdjeUpoZ0dDOG5p?=
 =?utf-8?B?blF3UTgzcTVJZnUvMVdFUWdkbHBqcURqUlZxRVNsZ3d3UTkyYjZYRkRrRTF2?=
 =?utf-8?B?bWg1aUdsSVRuYms4RFViaFZDWmwxdmxLTnl1Y2hxd1NONExpOWpXK3RiSUor?=
 =?utf-8?B?cUdXdEQ0eWpVLzlELzBpRUtZa2JkQVl3Q0o4VkhkMEt0WEpwRks4anI0Ulpp?=
 =?utf-8?B?SFVRajBHWEl3ekZzR0U2dnZITThPRThScDFBdDE0TEVEZlYxcHhydlBmSThE?=
 =?utf-8?B?R2l3T3Zta3JXL1dsWTV2cmlsbnYzYzAvd2hCVDR0ekMwR1lXY2Y4bVZxYnVw?=
 =?utf-8?B?Q0w3azVOZzM5Q2NhRWlOVWF3c0FxbXJUbXZkRXRjZk5UakNpUlhDUnpaaTFv?=
 =?utf-8?B?WnkvRlNHbmwzNTJoRmtxL0IzaE12cjFHVmJoOTRXUDBhSHprQnQwWGl0M2Nz?=
 =?utf-8?B?UzZFZ2cwai81bVAxR2gydEZDcjQ2a0xZSkFDQVQ3d3N1VnZFM2RzZlNWWHRV?=
 =?utf-8?B?bXZkcE9Cd2F0U2ZudkQwYlZpM052VTlpaVdMaFczWVpWMXpsY0dXWlJCMXVi?=
 =?utf-8?B?Nld0V1NWNWwvRllVZlJBTVNpYUk2OUtERUdwaFpsUElZU0pjRm9NUGVGV091?=
 =?utf-8?B?RjN2N08vZCtQRzRNZ2ZZY21LaS9nSVVHK0ZNcXhZVHhqaGFRZGdub2hwTzVs?=
 =?utf-8?B?MWpLRG8vQzlwNzBKNis2bCtxTVh6LzNxNkxSUjRGMG13cnVrZDVzYTdLMW4r?=
 =?utf-8?B?M0Q2NUtwT05VdWVvWEk3UWFqc29xMEU3Q2d2MWkrQWlVSDBtdjBiZi9RSTJF?=
 =?utf-8?B?cGxJQ0MzVE1WMDArMGx1YWVqRHZEL1RxR28zQkdFWXFMKzV5OTRHNzFKOWJQ?=
 =?utf-8?B?aElPejl6MEFKRk9vcno2dDI5czYzOGVsSi9QMkRRa3B1WnR6MjlFZTB5eWZ3?=
 =?utf-8?B?YUQzMkNITCtVa000cFZ0MGtHUHk0WTNZWk9mRjFPNkZQTlNXelkwQzBBaDNI?=
 =?utf-8?B?a0dVNno4eHMxS21NaHJjMDFiRmJwUDdhNnVSbDhTNG1WejhoOUptWmRpcjAv?=
 =?utf-8?B?c3NlRjAwVDNQeVljUy83YVZCVWV6U0JoL1ZmSjYySUJvSWNEUkZRbmovSm1V?=
 =?utf-8?B?SW01dGphR1FYQTREem5QNTRHK3dGMXc0N0JqdmdCZkFBM202dERhOXAxM1kv?=
 =?utf-8?B?dWd1S2U1VW4zTFYwZUREVDFCS290MGptRFg4VWZrTUlXd2hCZVlmUXdlczF2?=
 =?utf-8?B?WjlhNVhKQzdrVmx4U1JSdE8zeUh5UldRWEFkc1BwN1pOeXEzQVRFa0hwU3h3?=
 =?utf-8?B?Q3lqT1hxQzFFTkg1anhHYS9KUjYxTXlyTjhsRW0zMFZtSTVzWlJScXYvY3J6?=
 =?utf-8?B?Q2FPbExmejNHd0loQ21CTHJIdGtrcmdnbExFL3pKV212S2xHNmdiR1lqbnA4?=
 =?utf-8?B?NFdqQW5jQmI0NmRub25BVlJ3K2hhU3d0TnVKSzdabmRzd0NoRWdTdEtHYmZY?=
 =?utf-8?B?YWczc2xFVFM3cVkrZkhPR0FyR2JzdDhKcTR1MFJhNEJ1Ky9Bd2lCYkxSK0Rk?=
 =?utf-8?Q?0irTLYE02/Akr3123BMkXC+Tp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ceecdfdc-10c9-486c-6af4-08db2a1abc2f
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 14:44:12.0297
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aKOoVUBZZAU2LpcOBUCM2MP2/6x8drFgE2jdScrr28LCbMX+KhnDCiNzyHK4haGF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6369
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/16/23 06:43, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   drivers/i2c/busses/i2c-xiic.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index dbb792fc197e..0eea00d10545 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1233,8 +1233,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
>                  i2c->quirks = data->quirks;
>          }
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       i2c->base = devm_ioremap_resource(&pdev->dev, res);
> +       i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>          if (IS_ERR(i2c->base))
>                  return PTR_ERR(i2c->base);
> 
> --
> 2.20.1.7.g153144c
> 

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal