Message-ID: <18eb81cf-5a86-781a-0a2a-457bf265e1f5@amd.com>
Date:   Tue, 21 Mar 2023 15:45:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] dmaengine: zynqmp_dma: Sync DMA and coherent masks
Content-Language: en-US
To:     Harini Katakam <harini.katakam@amd.com>, vkoul@kernel.org,
        romain.perier@gmail.com, allen.lkml@gmail.com, yukuai3@huawei.com
Cc:     dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, harinikatakamlinux@gmail.com,
        radhey.shyam.pandey@amd.com
References: <20230316093318.6722-1-harini.katakam@amd.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230316093318.6722-1-harini.katakam@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWU0NXh5bnhmOVBZZWtJRUlGY0lVaEZKM01nUUNicjAzVWViT1J5L1BaSjVt?=
 =?utf-8?B?VEhteDZ6RS9QM1psUVk4OVh5b0VCWHZGZHpkVm90dnc1akZLek10S2dGbFQ1?=
 =?utf-8?B?bEdTZkxEd3dEWmdKaWU4MkI1cWpLdDJRb29hSGRHaE9TOFB4V05HMG1RR2gr?=
 =?utf-8?B?eis0bHZoblBJTUdhVlF2Z3AyUnR1dG1TQUJ2RVloeDAzRklOajFoV2M5MkdX?=
 =?utf-8?B?OUcyY25vWURjOWRzZzY2VWF0SXArWTNObW04S3l1WTJFeXRQSkJTZWhaWFBV?=
 =?utf-8?B?dkM5d0xnSXpBTkFVMXZwSTZFVUxCU2gwNWtZa2lSTy84N2xId2RoTWx1MFZZ?=
 =?utf-8?B?NFl0TUgyelBiTGtLQkpIdmVnUlV3OFZMeS9YSmdHNFE4bG5uZmhibXRIRVFJ?=
 =?utf-8?B?U3VtOFVuNXhLckxHVVh2UndLQlZ6Q0hRUWJqdXBYK0N1T04yMmxLUzdYY3Bq?=
 =?utf-8?B?VkNpT3Frbk9lMjVwZlVGVVpkWVlPOW9sa2x0eFJ0OXkzTi9RTHJHdHNadVpr?=
 =?utf-8?B?VkM1QTVrVlczcFFtcWFwZ0JESkNRNG8wSFBpWXlLbXZlREhIblg2SDlFNDJN?=
 =?utf-8?B?RS9pd0RZWTFHcE11UHdFSVdJL04wamc5Y1FIaGNWT2xYNk5FNVRQaW45TjQx?=
 =?utf-8?B?MEdqT1J1TFd0cmRreWtVU08wS1QvVVhRdjdVN0tnVmFpcXhxVS9LUEdxZ3Nu?=
 =?utf-8?B?UmNzazg1ZWlHZHJDalVEYThSTElrSTloQ3MycVBVR29nV1REQ0VQLzhHSTlS?=
 =?utf-8?B?OC9FSk9Jcmc1clpuS2U2VkFkeHFFdUZVQ3NRSFU3UXMwdXBaUVNEN1N5VnhD?=
 =?utf-8?B?N2pwZktZNHRWZG5xVGwzclE1TDRYWHhucW9BT2NrSFpYSWdRZllxNXRjQitF?=
 =?utf-8?B?Lyt2NUZXMUl6UVZlOTNlT3E0Zzh5VnZwQytNT2NTZnlnd0Y3MGRyTERGN2Nl?=
 =?utf-8?B?RTFZdzJDK0xrOVo4UElvRXFHWVNUaGlkOWNLMFI4SDdVcU1oc2JBWDg4WlVJ?=
 =?utf-8?B?bjJjVStISmNmK1hYVS81YitqTlBRUm9qSGJXQ0MycFZHUUQ3blVjWkt0OUJG?=
 =?utf-8?B?UUJuQWFMWnlnRWhtR2RLcDc4Wlk4TFZ6U1RvTmtrNi94MkNkTzA2NXpxa01X?=
 =?utf-8?B?eFROYk56MklpSnhKK2tBRFRlRmhpSW5jRDdjN0FLL1UxYUpxQnh5bTRPM3d2?=
 =?utf-8?B?VWt6YlF5WVQ4Nml1cFFyVjlZbGFTSUIxNUFVYkNOYkxIQ0lGRWo2Um9SRTg2?=
 =?utf-8?B?Q0xacFJ2OFlCeW00S3p0V1d2b1lvdHgxN3gwazQ1RTlWL1BDcWRLM1BMUWdj?=
 =?utf-8?B?VVRBYTB2cFN3WllSQXhFMTFvQ3UrTElybUNPa3I0eEFQb0hBLzlFUlZ3MVBn?=
 =?utf-8?B?bmNRMCtkK1hIZFlPVXNicmJxN01hbTNFaTRsVWJ6U3lFQ3ZPbVFDVlc4L3pn?=
 =?utf-8?B?RzRYT1FVR1ViZHRQOHl6eHFGQWVlZlh5ZVMyalczZm9KU3RnRllRU1VBY3Ju?=
 =?utf-8?B?N0I0QWFnOE1CQkFvRmZ3dzVGUHZ1OVRHQm4wRDdEcTBoQVpqTkYzRXNBMEVU?=
 =?utf-8?B?SUZ1dW85VXlUQjdKR2N6a25kY2FyeHFTVi9Ha1A1V3B1WkNQaGJ1L0RFYmJq?=
 =?utf-8?B?QjRxTG1UWEx5QTVwYjlobmVTak52WjJNMVYxU1oxNk9HcUtOanRUMHNuT05B?=
 =?utf-8?B?NUtSSWhpejEyMktJNXoyOGRweVkyQys3MlE3MkJwNGE2bStGZ0NPVE1Kd0Jr?=
 =?utf-8?B?YVhqYUU1M2w4MDExN1dBR1VudnFWUlFtQklSSWlTS1dsOE5uUm1qTmM2VHpt?=
 =?utf-8?B?ZVN5UWdtQUE4eElDQ3Y1QUdDS0tZenpoOGtWSkxDangxU0N6STVyeGdodGMy?=
 =?utf-8?B?Z3NTelU2bzFkQmhsUGRlbiszL0h2dURVeWh6ck1hSDExTG82TTJwRXlUQWk1?=
 =?utf-8?B?ZFFJSUI0RWpQb0RpK0tIYWVpdk9ac1Q1YVIxRytlQ1ZzeGRYdU1JbjBsT0FU?=
 =?utf-8?B?azFFTlJuNSswSUtsZFl3RWltY2oyOWoyWmJobytyTDhCeCtzRUNIOVRmaXdz?=
 =?utf-8?B?VFNoMlVjYlNLbVJXd0h2Vk94WkxXL3B3YjNXdStzc2x4TjlSNUhlbEl4bXNt?=
 =?utf-8?Q?rxVS9SLrUVP+qnp3VSLrPYWHT?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4046372-2036-449e-6c44-08db2a1ae45e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 14:45:19.5091
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DOd35rgEjnw4g42Rt6GDm3dagng44dQaLoPfciayA/9YWDTsqVakV9Qj37XNzuhc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6369
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/16/23 10:33, Harini Katakam wrote:
> Align ZDMA DMA as well as coherent memory masks to 44 bit. This is
> required when using >32 bit memory regions.

It doesn't look like description aligned with the change below.
You are using 44 bit already and the patch itself just checking return value 
from that function.

M