MIME-Version: 1.0
References: <20230310160610.742382-1-james.clark@arm.com> <20230310160610.742382-2-james.clark@arm.com>
 <b16a31ab-907c-1478-3a07-44d588318768@arm.com>
In-Reply-To: <b16a31ab-907c-1478-3a07-44d588318768@arm.com>
From:   Mike Leach <mike.leach@linaro.org>
Date:   Tue, 21 Mar 2023 15:12:18 +0000
Message-ID: <CAJ9a7ViOgz7xHGN6H2s+4TgAuswKfhQamRHQZZif0zNCv--uMg@mail.gmail.com>
Subject: Re: [PATCH v2 1/9] coresight: Use enum type for cs_mode wherever possible
To:     Suzuki K Poulose <suzuki.poulose@arm.com>
Cc:     James Clark <james.clark@arm.com>, coresight@lists.linaro.org,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 16 Mar 2023 at 16:47, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>
> On 10/03/2023 16:06, James Clark wrote:
> > mode is stored as a local_t, but it is also passed around a lot as a
> > plain u32, so use the correct type wherever local_t isn't currently
> > used. This helps a little bit with readability.
> >
> > Signed-off-by: James Clark <james.clark@arm.com>
> > ---
> >   drivers/hwtracing/coresight/coresight-core.c       |  7 ++++---
> >   drivers/hwtracing/coresight/coresight-etb10.c      |  3 ++-
> >   drivers/hwtracing/coresight/coresight-etm3x-core.c |  6 +++---
> >   drivers/hwtracing/coresight/coresight-etm4x-core.c |  6 +++---
> >   drivers/hwtracing/coresight/coresight-priv.h       |  9 ++-------
> >   drivers/hwtracing/coresight/coresight-stm.c        |  6 +++---
> >   drivers/hwtracing/coresight/coresight-tmc-etf.c    |  2 +-
> >   drivers/hwtracing/coresight/coresight-tmc-etr.c    |  7 +++----
> >   drivers/hwtracing/coresight/coresight-tpdm.c       |  4 ++--
> >   drivers/hwtracing/coresight/coresight-tpiu.c       |  3 ++-
> >   drivers/hwtracing/coresight/coresight-trbe.c       |  3 ++-
> >   drivers/hwtracing/coresight/ultrasoc-smb.c         |  3 ++-
> >   drivers/hwtracing/coresight/ultrasoc-smb.h         |  2 +-
> >   include/linux/coresight.h                          | 13 ++++++++++---
> >   14 files changed, 40 insertions(+), 34 deletions(-)
> >
>
> Looks good to me.
>
> Suzuki
>
>
Reviewed-by: Mike Leach <mike.leach@linaro.org>


--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK