Message-ID: <1e44aa00-9896-8869-1707-fe8e5815e9c7@amd.com>
Date:   Tue, 21 Mar 2023 16:15:55 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] dmaengine: zynqmp_dma: Sync DMA and coherent masks
Content-Language: en-US
To:     "Katakam, Harini" <harini.katakam@amd.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "romain.perier@gmail.com" <romain.perier@gmail.com>,
        "allen.lkml@gmail.com" <allen.lkml@gmail.com>,
        "yukuai3@huawei.com" <yukuai3@huawei.com>
Cc:     "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "harinikatakamlinux@gmail.com" <harinikatakamlinux@gmail.com>,
        "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
References: <20230316093318.6722-1-harini.katakam@amd.com>
 <18eb81cf-5a86-781a-0a2a-457bf265e1f5@amd.com>
 <BYAPR12MB47737C53AA67606A94B223C59E819@BYAPR12MB4773.namprd12.prod.outlook.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <BYAPR12MB47737C53AA67606A94B223C59E819@BYAPR12MB4773.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEErd21XT0QwNDBMQllqZ3FDaGJxVEQwSXA3RTF3RkZUTXFjVmtPSU5WZ1Za?=
 =?utf-8?B?c2h3QnU2aktpcnpsL2licHgvR2hhcXppVHpVTlpxeTlnT2Zwbm1tVStGdXI1?=
 =?utf-8?B?cldUSDViZFlRVVNYcFh3RXk4QU1iWDVxZFlRbGRkeXhGSkpKVFRqb3hwZHJL?=
 =?utf-8?B?clRrTDlDL3FkWThhK1RQdTJjTWtrTjBkeHRUQlprRk8vSjFxLzJPM3kvYmxF?=
 =?utf-8?B?OE00OTh4ZkVKSjdhUldPK1FZRllVTk9iNzVDQnNLS1E4Tk16bUZvUENXNldW?=
 =?utf-8?B?bmpocUtwSVZ6d0FXdEJXNmM1eTg1MysvNG9VdENoZWpjaDIyNERZYTVaSXZM?=
 =?utf-8?B?NFA2ZEZBalpMR3U0WWFHMHNCYnE4VFZ4VjVDcm5qY1NGVnJWdjA4YmpRbnpD?=
 =?utf-8?B?NWxWMGVXKzh5SWJoRFhiSHhuZnJJY240SUV1ZDhWTjNqV0UzZmNOSGVSdzha?=
 =?utf-8?B?bjdYeTRnaWFpUStCTUhIRll6VU8yVVZHTUZvSHFNK0UvaWd5YlptRWNiR2Z1?=
 =?utf-8?B?cGM2MjNUc2d4SzFBVEd6Z09EbkRWSnlUcHUwUjZ4R2RNQ2NVMUxSaW1kRTA5?=
 =?utf-8?B?ZlB2RklPK3pBTWduc0Z0NDlOTFRjRm5nckczTTlwOHRYY1hUMStTSmZ2VG52?=
 =?utf-8?B?blh4RGcyaTY0WXQ5cS85UVBCbzYwbHNzejFkMi9lK2tjWTc1QUJSZlB4Lytu?=
 =?utf-8?B?NEZpRnhHcmNNTUNWZDFGNy9uZTB4NkYrLzFSWHQ4bXVWdENIQzgxTzVXOC8z?=
 =?utf-8?B?L1JXUWZPVGJJOTVqRy9sb0JoZ2ZXcUZrNzVPVVkwMTFwUTh1Ujc3MFlnT3ls?=
 =?utf-8?B?dTAxejNyWUM4anNUVTZOME9GTXlaN2xtMm1qd2tCdWtMdlIwaThUS1d1TVJi?=
 =?utf-8?B?MlpSY1d5cmUrWXR1SUEvR2RLbWY4Z0pvcXlEQVRrMk1BRFJqUEN0ZjNPd28y?=
 =?utf-8?B?aTR3VUtWR2JNNzZyZ0dwTUh2cmhKL2JWZGZWNHlxOFFQajBGbThGaGxQampa?=
 =?utf-8?B?T1VTQnhVSUMrUkljdVBINGltZEJKNWZ0NUFWSnVJekJ2dGVuRnJjZ0dXSGlL?=
 =?utf-8?B?c0FWaytzUWgwODF0cUZLblpSRUtzTjdwQUJwbnRLU0JMZ3BnSDhOKzhKQTU2?=
 =?utf-8?B?VXJ3azdJMTM2M0lyT2NTMmlueUQrZVdoTnJiM0wvS2hPR0UrOU1rTS9WWXQr?=
 =?utf-8?B?aHBnMk9oUHkwdm1qSnA5aFRoMnVlU1Foa0dlRlZ1M2owWVBicWFPcGw2YTc5?=
 =?utf-8?B?ZVRSeVVxSEN4R2w5NFpPbVdjQ1FvaldVOGFlTWFFU01BR242bVgrT3pWRGVZ?=
 =?utf-8?B?NHBSTmJGNXE5MUhHQ0VqdVg1d002NjZkWkt0TCtwaXFIemxNRE5Bd1BiU0d5?=
 =?utf-8?B?QXduR1FsbzBRUlpSbFFVRVZueEwxbVRSYzNlT0FlTlVhL0tHOG1vRXZxQlI3?=
 =?utf-8?B?WXVPRzRQMTVaTVdMd0NuUEdRQkEzemUzQURUMjNwaktVdFFmQmhSenJ4c29j?=
 =?utf-8?B?anpCLzFvT09ETjZpWGF0UlJCTjJMdHQ2UmRHejFpL0laRFhuSVpkdFJPeWRx?=
 =?utf-8?B?UEN6UE9QYlNVRi9ZUFZsV2MxaS9IWDJUekxkK1pFbC9UTFc3Uks2S3dZVTFH?=
 =?utf-8?B?TmlxNS9rMjZObU0vOTk4RFBNbC9obzFZa0FlYU14NVNOK09jbXBNUUNuK2ow?=
 =?utf-8?B?bEtTY29lWDZBNW5CZVpBREVNN2pLbk9HK3VRNHRxV01zdVg1eWFCQkVjellM?=
 =?utf-8?B?NWEvVW9zOG82aWx2ckxRMzM3UmkvU0VKSk5OQjZmWEkyejhQYldvMmRNK0ln?=
 =?utf-8?B?dmNJemlhakx3NXJPQVFjWFc2YXJ3MmRUUk9sRlNMKys0di9vN2dtZDZTSDFU?=
 =?utf-8?B?VnA5N0pFWDdWZWhuaUdNK0J4bTZLb0hXTWRQRlgxQW1sNTVuQlVPc0JtK0JH?=
 =?utf-8?B?cEVHbXViRWtldFgxY0oydm1MQUF0UWZuV0VRSk1yN1QxaGVUQklIRVA3bWxq?=
 =?utf-8?B?L3lhM3hlTjNWM1Y2R2N3UWdsZjBZS2RQc2c2YnFUcHRDaEl2SWJOeDZmNi9D?=
 =?utf-8?B?WDBRTjByYitCODlQWVgweENGN1FMU2hBaHVOcTNkWmxGY1pSQ3I2S3NKc1dH?=
 =?utf-8?Q?PmXuziBIP8BUgCxGJmksfOR2d?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1ca0936-a9d4-4f5e-a212-08db2a1f3476
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 15:16:11.6693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dQO5iI1F6KEnvZvaQtd75j87sIz0AnOhJEpSk55wSVrmIMu50avpg6hWhOrljrz/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6949
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/21/23 16:04, Katakam, Harini wrote:
> Hi Michal,
> 
>> -----Original Message-----
>> From: Simek, Michal <michal.simek@amd.com>
>> Sent: Tuesday, March 21, 2023 8:15 PM
>> To: Katakam, Harini <harini.katakam@amd.com>; vkoul@kernel.org;
>> romain.perier@gmail.com; allen.lkml@gmail.com; yukuai3@huawei.com
>> Cc: dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>> kernel@vger.kernel.org; harinikatakamlinux@gmail.com; Pandey, Radhey
>> Shyam <radhey.shyam.pandey@amd.com>
>> Subject: Re: [PATCH] dmaengine: zynqmp_dma: Sync DMA and coherent
>> masks
>>
>>
>>
>> On 3/16/23 10:33, Harini Katakam wrote:
>>> Align ZDMA DMA as well as coherent memory masks to 44 bit. This is
>>> required when using >32 bit memory regions.
>>
>> It doesn't look like description aligned with the change below.
>> You are using 44 bit already and the patch itself just checking return value
>> from that function.
> 
> Current code sets dma_set_mask; I changed it to dma_set_mask_and_coherent

Ah ok. Then

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal