Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\))
Subject: Re: [PATCH v3 2/2] media: meson: vdec: add HEVC decode codec
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <558a8afc-f62d-aec7-aca5-5d26471ba332@xs4all.nl>
Date:   Tue, 21 Mar 2023 19:30:01 +0400
Cc:     Neil Armstrong <neil.armstrong@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        linux-media@vger.kernel.org,
        AML <linux-amlogic@lists.infradead.org>,
        linux-staging@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Maxime Jourdan <mjourdan@baylibre.com>,
        Benjamin Roszak <benjamin545@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <AEAFD8D1-D7F4-470A-A84B-E18DD9FDA735@gmail.com>
References: <20230314114318.4057353-1-christianshewitt@gmail.com>
 <20230314114318.4057353-3-christianshewitt@gmail.com>
 <558a8afc-f62d-aec7-aca5-5d26471ba332@xs4all.nl>
To:     Hans Verkuil <hverkuil@xs4all.nl>
Precedence: bulk


> On 21 Mar 2023, at 6:25 pm, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>=20
> On 14/03/2023 12:43, Christian Hewitt wrote:
>> From: Maxime Jourdan <mjourdan@baylibre.com>
>>=20
>> Add initial HEVC codec for the Amlogic GXBB/GXL/GXM SoCs using
>> the common "HEVC" decoder driver.
>>=20
>> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
>> [codec alignment to upstream changes and frame handling improvements]
>> Signed-off-by: Benjamin Roszak <benjamin545@gmail.com>
>> ---
>> drivers/staging/media/meson/vdec/Makefile     |    2 +-
>> drivers/staging/media/meson/vdec/codec_hevc.c | 1463 =
+++++++++++++++++
>> drivers/staging/media/meson/vdec/codec_hevc.h |   13 +
>> drivers/staging/media/meson/vdec/esparser.c   |    3 +-
>> drivers/staging/media/meson/vdec/hevc_regs.h  |    1 +
>> .../staging/media/meson/vdec/vdec_platform.c  |   37 +
>> 6 files changed, 1517 insertions(+), 2 deletions(-)
>> create mode 100644 drivers/staging/media/meson/vdec/codec_hevc.c
>> create mode 100644 drivers/staging/media/meson/vdec/codec_hevc.h
>>=20
>=20
> <snip>
>=20
>> diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c =
b/drivers/staging/media/meson/vdec/vdec_platform.c
>> index 88c9d72e1c83..ea2aa0e8cf0b 100644
>> --- a/drivers/staging/media/meson/vdec/vdec_platform.c
>> +++ b/drivers/staging/media/meson/vdec/vdec_platform.c
>> @@ -11,10 +11,23 @@
>> #include "vdec_hevc.h"
>> #include "codec_mpeg12.h"
>> #include "codec_h264.h"
>> +#include "codec_hevc.h"
>> #include "codec_vp9.h"
>>=20
>> static const struct amvdec_format vdec_formats_gxbb[] =3D {
>> 	{
>> +		.pixfmt =3D V4L2_PIX_FMT_HEVC,
>> +		.min_buffers =3D 4,
>> +		.max_buffers =3D 24,
>> +		.max_width =3D 3840,
>> +		.max_height =3D 2160,
>> +		.vdec_ops =3D &vdec_hevc_ops,
>> +		.codec_ops =3D &codec_hevc_ops,
>> +		.firmware_path =3D "meson/vdec/gxl_hevc.bin",
>> +		.pixfmts_cap =3D { V4L2_PIX_FMT_NV12M, 0 },
>> +		.flags =3D V4L2_FMT_FLAG_COMPRESSED |
>> +			 V4L2_FMT_FLAG_DYN_RESOLUTION,
>> +	}, {
>> 		.pixfmt =3D V4L2_PIX_FMT_H264,
>> 		.min_buffers =3D 2,
>> 		.max_buffers =3D 24,
>> @@ -64,6 +77,18 @@ static const struct amvdec_format =
vdec_formats_gxl[] =3D {
>> 		.pixfmts_cap =3D { V4L2_PIX_FMT_NV12M, 0 },
>> 		.flags =3D V4L2_FMT_FLAG_COMPRESSED |
>> 			 V4L2_FMT_FLAG_DYN_RESOLUTION,
>> +	}, {
>> +		.pixfmt =3D V4L2_PIX_FMT_HEVC,
>> +		.min_buffers =3D 4,
>> +		.max_buffers =3D 24,
>> +		.max_width =3D 3840,
>> +		.max_height =3D 2160,
>> +		.vdec_ops =3D &vdec_hevc_ops,
>> +		.codec_ops =3D &codec_hevc_ops,
>> +		.firmware_path =3D "meson/vdec/gxl_hevc.bin",
>> +		.pixfmts_cap =3D { V4L2_PIX_FMT_NV12M, 0 },
>> +		.flags =3D V4L2_FMT_FLAG_COMPRESSED |
>> +			 V4L2_FMT_FLAG_DYN_RESOLUTION,
>> 	}, {
>> 		.pixfmt =3D V4L2_PIX_FMT_H264,
>> 		.min_buffers =3D 2,
>> @@ -114,6 +139,18 @@ static const struct amvdec_format =
vdec_formats_gxm[] =3D {
>> 		.pixfmts_cap =3D { V4L2_PIX_FMT_NV12M, 0 },
>> 		.flags =3D V4L2_FMT_FLAG_COMPRESSED |
>> 			 V4L2_FMT_FLAG_DYN_RESOLUTION,
>> +	}, {
>> +		.pixfmt =3D V4L2_PIX_FMT_HEVC,
>> +		.min_buffers =3D 4,
>> +		.max_buffers =3D 24,
>> +		.max_width =3D 3840,
>> +		.max_height =3D 2160,
>> +		.vdec_ops =3D &vdec_hevc_ops,
>> +		.codec_ops =3D &codec_hevc_ops,
>> +		.firmware_path =3D "meson/vdec/gxl_hevc.bin",
>=20
> Hmm, I don't see this firmware in any debian package. Is it made =
available to
> linux-firmware? This actually applies to *all* meson/vdec/ firmwares.

Yes, was upstreamed by Maxime in 2019 and updated 2020:

=
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.gi=
t/tree/meson/vdec

Christian

>> +		.pixfmts_cap =3D { V4L2_PIX_FMT_NV12M, 0 },
>> +		.flags =3D V4L2_FMT_FLAG_COMPRESSED |
>> +			 V4L2_FMT_FLAG_DYN_RESOLUTION,
>> 	}, {
>> 		.pixfmt =3D V4L2_PIX_FMT_H264,
>> 		.min_buffers =3D 2,