Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41528C74A5B for ; Tue, 21 Mar 2023 15:47:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231686AbjCUPrE (ORCPT ); Tue, 21 Mar 2023 11:47:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231270AbjCUPrB (ORCPT ); Tue, 21 Mar 2023 11:47:01 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8380650991; Tue, 21 Mar 2023 08:46:59 -0700 (PDT) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32LEgnAr000634; Tue, 21 Mar 2023 15:46:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=mDGXDVU2C3HSFzQ1Pxmq4HXPZhrMWbS2e7aCSFHT8bc=; b=cZTn17EjUFI3hfyCfH33B8Af+9MzkjqYW3CE6EA8uhq3GW5gceF4yKFHCQ4Y3K6l/dfe W/NKa48kkILB40jorhWVNlkLfgdtqnki2XzUtw7sPDIl6x8yB7X/dxthDn553Okc9txX uDoGifHe7QjJIX5mp5cb9u/rH5i5qoMizET4YLm38fKyN4fVJ/oVW9OzrhZDPxNPdczM evL3C6f0oXhTDIwl6jPsVQ/q0z6a50lELx8JAHNgpQSQl2aefE7r9wDDTaB5HgASOrlg iZB61fgrHrLZ9eosVBZKeUo3jdFHD1f8XzFR5aDYzfejyu9kXNfTOGxUBL+6CCzlpj3r cQ== Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pf3ruhfje-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Mar 2023 15:46:46 +0000 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 32LFUJQa020574; Tue, 21 Mar 2023 15:46:45 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([9.208.129.119]) by ppma02wdc.us.ibm.com (PPS) with ESMTPS id 3pd4x73bfe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Mar 2023 15:46:45 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 32LFkiHN37093672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Mar 2023 15:46:44 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DE9B15805D; Tue, 21 Mar 2023 15:46:43 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D0AFD58062; Tue, 21 Mar 2023 15:46:42 +0000 (GMT) Received: from [9.160.111.39] (unknown [9.160.111.39]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 21 Mar 2023 15:46:42 +0000 (GMT) Message-ID: Date: Tue, 21 Mar 2023 10:46:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 2/4] doc: Add Atmel AT30TSE serial eeprom To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org, andrew@aj.id.au, joel@jms.id.au, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org References: <20230321151642.461618-1-eajames@linux.ibm.com> <20230321151642.461618-3-eajames@linux.ibm.com> <6d4cf513-0787-6b39-8d38-30484be7ddff@linaro.org> Content-Language: en-US From: Eddie James In-Reply-To: <6d4cf513-0787-6b39-8d38-30484be7ddff@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-GUID: LepCtECvJPy7TmQStdzOD8-FrTSvSg3v X-Proofpoint-ORIG-GUID: LepCtECvJPy7TmQStdzOD8-FrTSvSg3v Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-21_11,2023-03-21_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 phishscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 mlxscore=0 spamscore=0 priorityscore=1501 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303210121 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/21/23 10:19, Krzysztof Kozlowski wrote: > On 21/03/2023 16:16, Eddie James wrote: >> The AT30TSE is compatible with the JEDEC EE1004 standard. Document it >> as a trivial I2C device. >> >> Signed-off-by: Eddie James > Use subject prefixes matching the subsystem (which you can get for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching). Oops, sorry, will fix. > >> --- >> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml >> index 6f482a254a1d..43e26c73a95f 100644 >> --- a/Documentation/devicetree/bindings/trivial-devices.yaml >> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml >> @@ -47,6 +47,8 @@ properties: >> - ams,iaq-core >> # i2c serial eeprom (24cxx) >> - at,24c08 >> + # i2c serial eeprom (EE1004 standard) > AT30TSE? > >> + - atmel,at30tse > Microchip does not find anything on AT30TSE. Are you sure this is the > model name? Yes: https://www.microchip.com/content/dam/mchp/documents/OTH/ProductDocuments/DataSheets/Atmel-8868-DTS-AT30TSE004A-Datasheet.pdf Maybe it's actually an 8868? Or should I include the 004A as well? Thanks, Eddie > > > Best regards, > Krzysztof >