Message-ID: <c083cfb4-3282-2aeb-c704-9cc21ada918e@amd.com>
Date:   Tue, 21 Mar 2023 10:54:48 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v3 4/7] x86/resctrl: Re-arrange RFTYPE flags based on
 hierarchy
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>, corbet@lwn.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc:     fenghua.yu@intel.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <167778850105.1053859.14596357862185564029.stgit@bmoger-ubuntu>
 <167778868692.1053859.13490646651097380957.stgit@bmoger-ubuntu>
 <26400c6a-dcde-9ac2-df7a-117a12875f0c@intel.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <26400c6a-dcde-9ac2-df7a-117a12875f0c@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTZ4YmYyUnB3anpjN0RqYU4xLzdrUVdwQWVhNVo2aWM5ZlZtbkhoRWgxaTdL?=
 =?utf-8?B?UGRTbWppS21PQmFRcy9WcFdNRCs4eHorM04vd2V4aUdRTGdTUTFFNGR4Vi93?=
 =?utf-8?B?OHVoUHRHblBPNElQREk5SUJoN3RyelZmVStMVWFUQ1FkYjhTTlR3ckhBejVz?=
 =?utf-8?B?RlUyQW9wbXcrbUU2RWtSZWtCK2RVK2FrNFVsVVMrZjU4YmVMeElEblZjRDhV?=
 =?utf-8?B?bHFiUXVXQXVBOCtpdHowK1BOMktmaStxYWk0WVZIOXQ1U1FZRHJpeVBNQ3dC?=
 =?utf-8?B?R0RNeG15SzQ5aVlOYk5LZVRyUlMzNUFpL3RwK0JNbDhZMXVuOFZUV3Zvb00x?=
 =?utf-8?B?UGFDSkpITzFRcnkwWlEvVndMdVVPckhTV3gwU28vSTY3L3ZIbFFLV0lqdE8x?=
 =?utf-8?B?OUtTdmhSNTM5TVhQYlNpV1AzUDFLRk9MblR3Nk80OEMwcytsUzdhSkE2SVhH?=
 =?utf-8?B?WXM4YnMxWkx4VEt6Q1FvVmF4dHZUamRYSXk1YWdFazZNRjZOSTNXQ3d3TURN?=
 =?utf-8?B?eDVoUkEyRzdMYmFEdEtGVWlRVGgvVUovendKRm5yckdWMHcvUUdWWC9GelpC?=
 =?utf-8?B?SFpHOTBQUmFYdVZ6V2dqMVBLY2lXTDdhUDJWbTc2NU1XQWYzYmtETld2ZWNt?=
 =?utf-8?B?V1Ztd3lKbVdLZW00dDl4cmFYa3hSUUhWNmx5RkhRcXF1M2RpZ1Q1dDZ2eUFJ?=
 =?utf-8?B?Mmptd0VpSjV6S0hLd0pyM0hLNDc3TEFEK2lsdkxPZXVlbGYwK0RkRVZjV21v?=
 =?utf-8?B?cGE5SmJjYVV4VnVtaGxXbkI1L1VoYThicEJFOS8zMnZkc0ZiRWlpTEpvUC9X?=
 =?utf-8?B?ZGlVNjF5TkdQeEEwV0tsUTNoc0t6Q2tBczR5dGpmcUl5ZVZrRXdabWE4VXlP?=
 =?utf-8?B?czl3bk53NEZ0NDNpZXlpTEVyL1ozRHI1MDZPV20ySzZ4SWpuSHRIMkVNUzZP?=
 =?utf-8?B?VEZ1VEtHV09KdldWeldZbUo3a1ZMK3NDbTI4RFByMnRUMlQ0d2pSeEtvSU5j?=
 =?utf-8?B?bVppVUhsSjZYQytoMjlYNitWaytIL3FJOFB1SUNsRTgxMkUzcUQ4UzBVNmN1?=
 =?utf-8?B?M25DVWUwcEdsWUtZbG9uT09YdlJMdTQrV1hiYk5kbHRPa2FZVmFBazJYaGlJ?=
 =?utf-8?B?dlNIZTVjTWIyR2NCbVF1UzZUQUhTK1NyTVNMVXlieENCUnlaNURzVEpPaUVR?=
 =?utf-8?B?ZGU0eC9SSmNwTVVjN2pCb2xlVENaWlJCREhKN0tCakVIbjhQZjA5U3JGL1RM?=
 =?utf-8?B?TVdGYUpDL0RObzZXWndCZnZ5Tndod0ZGaU83M2JMUmJmbDZTUkxhWncvMU00?=
 =?utf-8?B?U2NBOGVWejhLSG85OHNDeUxSZEwycUh1VlhjdzBNZDlsRXFnZ0pCWjRoNVRY?=
 =?utf-8?B?N3paMjFtalJiT0srS09RYzhFVUlZUnpKL0p4d1BNNXh4azRjcFVQUDJFZTVi?=
 =?utf-8?B?ajBxT0dZaS9IMFJueW04Y28wNVp2Qms2ZzlRZFRER3RUZWlGRWpNN1V1c1d4?=
 =?utf-8?B?SitvekxrSkdpcGd6TEJKTEVScEx3Mmt6bjFDbzZWWnBmWGtIYVBzQUpYbHJT?=
 =?utf-8?B?SkZVcVNNVnZTRzQwSnFRd0pLSGtnSS8wNmcxM3h0ZElSbmNtQzlUaGoxTi9N?=
 =?utf-8?B?a293UUtFS1dlaWw2YlZPMytmWmhRTWZoOFNkTjNGTDd3aEI1NkRkUmxuZy8w?=
 =?utf-8?B?aHdQa3JYNTNOYk1GYTU4dTVyNzBUMndJeWx2enUwYUVkZWlIVk5DUmdhbXNR?=
 =?utf-8?B?cEFsR0h0WFNwOXlsWjNuTTE5aG1CUm80bTJFRVVVWERFd09Gang1SWtxQUFr?=
 =?utf-8?B?dS9qS1kzREhxMDRPMGxiRkgwSS9ra2ZSVjBnOWFZdmtzU0t3ZDRoUDhhN3Fr?=
 =?utf-8?B?NnFTUm1GUVdOY0dNdGo4OUhLTFBrbnJEQWRZVU5YRkJNTnZRVUppV1UveWs3?=
 =?utf-8?B?ZE5aK1lyTmFpL04vci9zbFVCa2ZLb2wxTTBWWHczQWNCSUhlbGovdGJJMGVI?=
 =?utf-8?B?K2FQSWNkU1FsMWYwYXVrQXVJUS9rRzI3V1NMbWEyWCtxZWtWN2xHS1huV0lz?=
 =?utf-8?B?ZUNUMDBBemVTakU3OUw5dXYzSVp0eVNBSDVVMnl4U3ZlTWFvVllrVWk2RHQ0?=
 =?utf-8?Q?F1AOk2qNZeNXYPyl8S9ffGs6p?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85eb2150-770b-446a-7bd5-08db2a249c20
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 15:54:53.3370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G19qAhTw8waPvTKN0/g1B1rREavfhZAmSkZYAZN4AwIgh/1ON53P9Itkq6jkeDWx
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8698
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Reinette,
To be honest, I had tough time understanding these flags. Also, I need to
add more files in the future. So, I am trying make these these things
clear before I do those changes.

These flags decoding is pretty confusing. Also, there are some flags which
are duplicate. Not really required.

For example:
  In group structure, we have control group or mon group. We just need two
bits here. The code uses combination of 3 flags here.
#define RFTYPE_BASE                     BIT(1)
#define RFTYPE_CTRL                     BIT(4)
#define RFTYPE_MON                      BIT(5)

Also, the flag RFTYPE_MON again used in creation on info directory.
Basically, very confusing to add anything new.

I will try to minimize the changes in the next version but still make it
clear.


On 3/15/23 13:37, Reinette Chatre wrote:
> Hi Babu,
> 
> On 3/2/2023 12:24 PM, Babu Moger wrote:
>> RESCTRL filesystem has two main components:
>> a. info (Details on resources and monitoring)
>> b. base (Details on CONTROL and MON groups)
>>
>> The rftype flags can be renamed accordingly for better understanding.
>> For example:
>> RFTYPE_INFO     : Files with these flags go in info directory
> 
> This is not a rename but the current name.

Agree. I am giving some example here. I may not need to change the text here.
> 
>> RFTYPE_INFO_MON : Files with these flags go in info/L3_MON
> 
> How does this improve the current RFTYPE_MON_INFO?

RFTYPE_INFO_MON -> info/L3_MON.

I tried to improve some readability based on hierarchy. Basically, looking
at the flags we know exaclty where these files land.


> 
>> RFTYPE_BASE     : Files with these flags go in group's(control or mon)
>>                   base directory
> This is not a rename but the current name.
> 
>> RFTYPE_BASE_CTRL: Files with these flags go in only CONTROL groups
> 
> How does this improve current RFTYPE_CTRL_BASE ?

Again, same explanation as above. Started with RFTYPE_BASE and added
RFTYPE_BASE_CTRL to say these files are on top of base.


> 
>>
>> Add comments to make it easy for future additions.
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
>>  arch/x86/kernel/cpu/resctrl/core.c     |    8 ++--
>>  arch/x86/kernel/cpu/resctrl/internal.h |   64 ++++++++++++++++++++++++++++----
>>  arch/x86/kernel/cpu/resctrl/rdtgroup.c |   44 +++++++++++-----------
>>  3 files changed, 81 insertions(+), 35 deletions(-)
>>
>> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
>> index 030d3b409768..d1c6b2cc8611 100644
>> --- a/arch/x86/kernel/cpu/resctrl/core.c
>> +++ b/arch/x86/kernel/cpu/resctrl/core.c
>> @@ -69,7 +69,7 @@ struct rdt_hw_resource rdt_resources_all[] = {
>>  			.domains		= domain_init(RDT_RESOURCE_L3),
>>  			.parse_ctrlval		= parse_cbm,
>>  			.format_str		= "%d=%0*x",
>> -			.fflags			= RFTYPE_RES_CACHE,
>> +			.fflags			= RFTYPE_CACHE,
>>  		},
> 
> How does this rename improve understanding?

Agree. This change may not be required. I can actually remove these changes
> 
> ...
> 
>> @@ -97,7 +97,7 @@ struct rdt_hw_resource rdt_resources_all[] = {
>>  			.domains		= domain_init(RDT_RESOURCE_MBA),
>>  			.parse_ctrlval		= parse_bw,
>>  			.format_str		= "%d=%*u",
>> -			.fflags			= RFTYPE_RES_MB,
>> +			.fflags			= RFTYPE_MB,
>>  		},
>>  	},
>>  	[RDT_RESOURCE_SMBA] =
> 
> ditto.

Agree. This change may not be required. I can actually remove these changes
.
> 
> 
> ...
> 
>> + *
>>   */
>>  #define RFTYPE_INFO			BIT(0)
>>  #define RFTYPE_BASE			BIT(1)
>> -#define RFTYPE_CTRL			BIT(4)
>> -#define RFTYPE_MON			BIT(5)
>> -#define RFTYPE_TOP			BIT(6)
>> -#define RFTYPE_RES_CACHE		BIT(8)
>> -#define RFTYPE_RES_MB			BIT(9)
>> -#define RFTYPE_CTRL_INFO		(RFTYPE_INFO | RFTYPE_CTRL)
>> -#define RFTYPE_MON_INFO			(RFTYPE_INFO | RFTYPE_MON)
>> -#define RFTYPE_TOP_INFO			(RFTYPE_INFO | RFTYPE_TOP)
>> -#define RFTYPE_CTRL_BASE		(RFTYPE_BASE | RFTYPE_CTRL)
>> +
>> +#define RFTYPE_TOP			BIT(2)
>> +#define RFTYPE_MON			BIT(3)
>> +#define RFTYPE_RES			BIT(4)
>> +
>> +#define RFTYPE_CACHE			BIT(5)
>> +#define RFTYPE_MB			BIT(6)
>> +
>> +#define RFTYPE_CTRL			BIT(8)
>> +
>> +#define RFTYPE_INFO_TOP			(RFTYPE_INFO | RFTYPE_TOP)
>> +#define RFTYPE_INFO_MON			(RFTYPE_INFO | RFTYPE_MON)
>> +#define RFTYPE_INFO_RES			(RFTYPE_INFO | RFTYPE_RES)
>> +
>> +#define RFTYPE_BASE_CTRL		(RFTYPE_BASE | RFTYPE_CTRL)
>>  
> 
> It is not clear to me how any of the renames improves understanding.
> 
> How does renaming RFTYPE_CTRL_BASE to RFTYPE_BASE_CTRL improve
> understanding? Renaming RFTYPE_MON_INFO to RFTYPE_INFO_MON?
> 
> This all seems unnecessary.

Again see my comments in the beginning.
> 
> ...
> 
>> @@ -3218,7 +3218,7 @@ static int mkdir_rdt_prepare(struct kernfs_node *parent_kn,
>>  	if (rtype == RDTCTRL_GROUP)
>>  		fflags = RFTYPE_BASE | RFTYPE_CTRL;
>>  	else
>> -		fflags = RFTYPE_BASE | RFTYPE_MON;
>> +		fflags = RFTYPE_BASE;
>>  
> 
> Is this intended?

Yes. We don't need this extra flag (RFTYPE_MON) here.
Thanks
Babu Moger